From: Greg KH <gregkh@linuxfoundation.org>
To: Guillaume Morin <guillaume@morinfr.org>
Cc: linux-raid@vger.kernel.org, stable@vger.kernel.org,
guoqing.jiang@linux.dev, artur.paszkiewicz@intel.com,
song@kernel.org
Subject: Re: [PATCH backport for 5.10]: md: revert io stats accounting
Date: Wed, 12 Jan 2022 19:15:04 +0100 [thread overview]
Message-ID: <Yd8aqDgZqSapNB52@kroah.com> (raw)
In-Reply-To: <Yd8PVH8rBepVYXwg@bender.morinfr.org>
On Wed, Jan 12, 2022 at 06:26:44PM +0100, Guillaume Morin wrote:
> commit ad3fc798800fb7ca04c1dfc439dba946818048d8 upstream.
>
> The commit 41d2d848e5c0 ("md: improve io stats accounting") could cause
> double fault problem per the report [1], and also it is not correct to
> change ->bi_end_io if md don't own it, so let's revert it.
>
> And io stats accounting will be replemented in later commits.
>
> [1]. https://lore.kernel.org/linux-raid/3bf04253-3fad-434a-63a7-20214e38cf26@gmail.com/T/#t
>
> Fixes: 41d2d848e5c0 ("md: improve io stats accounting")
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> Signed-off-by: Song Liu <song@kernel.org>
> [GM: backport to 5.10-stable]
> Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
> ---
> drivers/md/md.c | 57 +++++++++++--------------------------------------
> drivers/md/md.h | 1 -
> 2 files changed, 12 insertions(+), 46 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-01-12 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 18:40 [md] Missing revert in 5.10 Guillaume Morin
2022-01-11 18:54 ` Greg KH
2022-01-12 17:26 ` [PATCH backport for 5.10]: md: revert io stats accounting Guillaume Morin
2022-01-12 18:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8aqDgZqSapNB52@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=artur.paszkiewicz@intel.com \
--cc=guillaume@morinfr.org \
--cc=guoqing.jiang@linux.dev \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.