From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E5A2C80 for ; Sun, 2 Jan 2022 17:38:55 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id i22so65789318wrb.13 for ; Sun, 02 Jan 2022 09:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wWLcKGVB1L+M/AiUcBrGPhY5Q0k7V6b5eY3DoUOJMD8=; b=csZHGY26pjatP+CDAnS2WMlOd0K0PgW1V0FMFl7ejbepqwQz/MGKn+eRen/1UweBeu GGi0g8PdQ87eLfPzL1mDNUcGf3cF70JSGhz3D4AYURckPR/vcZ3y5hpw1fP40aIJgfTn Fne7LZ7shhqEYP3gT8cXawpvhAYyPbm5mBHWnTKcaEag+ms7hlf3U+q9D+b3NiF3paUS eRwVJxbpHMBEPdatzAl7z648n5OBTRNH16Ll703ovq0c/3RGCxYPje9jcq+QIMe1Olj+ +FpO7R98DAJZnP+/fbvUbBUNQrivxylkP2iIcUBAk16cbT7oMhGBtvfiq1+SlNZg2Xnp yj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wWLcKGVB1L+M/AiUcBrGPhY5Q0k7V6b5eY3DoUOJMD8=; b=PHQfv508GP2L2CPSw5HmYNQcn59Y+jlDhEvufdYChobG7+C6gQL4Bd/ofzP2HZp6PI jxydzKyqL440+l5EZFDY6GpchmpgHmJHmITDOGHkhuMHtFASkrfALG7vAJPYC2jR4enj f6ch1+2lKctJRNZbYpzYhhYZYL9sSMBrO0oe+WlY6tMbDHokjk3LSHU+y1D6ni5r4MnM vC6og7qpmBTyAivZOEcDoMqv4Rbvt4n/kDmxjFHg/s2bQa9G0nk89qK9rRO4S0W8kMnh d4H2ytZngSY5alr/g0dKk5AOAZzwXZs7vAxYiY6PIP4M9LaOwqHWuYCzLo4b6k2w4J9Y x01g== X-Gm-Message-State: AOAM530WmC2i+u1d7BgvySc++LQhz+aAJz8A6J3oGmrVAL9ut4c8Jdfb pv/i/gGzlEPka75tV9fZ+2w= X-Google-Smtp-Source: ABdhPJx3omdWEPyY14zY26ZL/okoE6UgJ7jwIZfMCKhDBqivpngpgjI4u0TAz3uLzlOh77rjr6U7+A== X-Received: by 2002:a5d:4ac1:: with SMTP id y1mr24447262wrs.588.1641145134005; Sun, 02 Jan 2022 09:38:54 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id b16sm35872809wmq.41.2022.01.02.09.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 09:38:53 -0800 (PST) Date: Sun, 2 Jan 2022 18:38:51 +0100 From: Corentin Labbe To: Conley Lee Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org, wens@csie.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, jernej.skrabec@gmail.com Subject: Re: [PATCH v6] sun4i-emac.c: add dma support Message-ID: References: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Le Sat, Jan 01, 2022 at 03:09:01PM +0800, Conley Lee a écrit : > On 12/31/21 at 11:43上午, Corentin Labbe wrote: > > Date: Fri, 31 Dec 2021 11:43:53 +0100 > > From: Corentin Labbe > > To: conleylee@foxmail.com > > Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org, > > wens@csie.org, netdev@vger.kernel.org, > > linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v6] sun4i-emac.c: add dma support > > > > Le Wed, Dec 29, 2021 at 09:43:51AM +0800, conleylee@foxmail.com a écrit : > > > From: Conley Lee > > > > > > Thanks for your review. Here is the new version for this patch. > > > > > > This patch adds support for the emac rx dma present on sun4i. The emac > > > is able to move packets from rx fifo to RAM by using dma. > > > > > > Change since v4. > > > - rename sbk field to skb > > > - rename alloc_emac_dma_req to emac_alloc_dma_req > > > - using kzalloc(..., GPF_ATOMIC) in interrupt context to avoid > > > sleeping > > > - retry by using emac_inblk_32bit when emac_dma_inblk_32bit fails > > > - fix some code style issues > > > > > > Change since v5. > > > - fix some code style issue > > > > > > > Hello > > > > I just tested this on a sun4i-a10-olinuxino-lime > > > > I got: > > [ 2.922812] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): get io resource from device: 0x1c0b000, size = 4096 > > [ 2.934512] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): failed to request dma channel. dma is disabled > > [ 2.945740] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): configure dma failed. disable dma. > > [ 2.957887] sun4i-emac 1c0b000.ethernet: eth0: at (ptrval), IRQ 19 MAC: 02:49:09:40:ab:3d > > > > On which board did you test it and how ? > > > > Regards > > Sorry. I sent the email with text/html format. This email is an clean version. > > In order to enable dma rx channel. `dmas` and `dma-names` properties > should be added to emac section in dts: > > emac: ethernet@1c0b000 { > ... > dmas = <&dma SUN4I_DMA_DEDICATED 7>; > dma-names = "rx"; > ... > } Helo Yes I figured that out. But you should have done a patch serie adding this. Your patch is now applied but it is a useless change without the dtb change. You should also probably update the driver binding (Documentation/devicetree/bindings/net/allwinner,sun4i-a10-emac.yaml) since you add new members to DT node. Furthermore, why did you add RX only and not TX dma also ? Probably it is too late since patch is applied but it is: Tested-by: Corentin Labbe Tested-on: sun4i-a10-olinuxino-lime Regards From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3284C433F5 for ; Sun, 2 Jan 2022 17:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+K4zteU+dUX7bPbCRmf8Vrlsk2O2wGlbCESd8fT2EeI=; b=vCcfAaOwWLTOwl 70fXWewf2TuqWyONBSHgU2Zew50x3DtvB5+LMr7oo3b2p7On7IcfrtPu8sKM+SqzUcF4SqEQ9f3tS gqR8UhRXjgUbnnLpfRyjXC+6nIf2l6CO/r1KdeNRPGv5j0iFEdnzPA64Y8BvjcY21Gg0Dq930qf+H twGlMYF9IrHZt4k/Vyc1sj9yYSO/G8ryBjDU+s8/8QKz+AcmIY/qENfkwoQ2LDqdyX0JV4pQoFpvj x3gp/+d76G6pObT6ITrOJpJyfvHGRlcI2v4hMf1tGkGV7RA2CZufjkyQoD4aF5TVziqvgn2rH3BHm 72pT7VLcApVUTgW+wAqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n44ou-0083EE-Jz; Sun, 02 Jan 2022 17:39:00 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n44or-0083DL-1v for linux-arm-kernel@lists.infradead.org; Sun, 02 Jan 2022 17:38:58 +0000 Received: by mail-wr1-x433.google.com with SMTP id v6so4094301wra.8 for ; Sun, 02 Jan 2022 09:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wWLcKGVB1L+M/AiUcBrGPhY5Q0k7V6b5eY3DoUOJMD8=; b=csZHGY26pjatP+CDAnS2WMlOd0K0PgW1V0FMFl7ejbepqwQz/MGKn+eRen/1UweBeu GGi0g8PdQ87eLfPzL1mDNUcGf3cF70JSGhz3D4AYURckPR/vcZ3y5hpw1fP40aIJgfTn Fne7LZ7shhqEYP3gT8cXawpvhAYyPbm5mBHWnTKcaEag+ms7hlf3U+q9D+b3NiF3paUS eRwVJxbpHMBEPdatzAl7z648n5OBTRNH16Ll703ovq0c/3RGCxYPje9jcq+QIMe1Olj+ +FpO7R98DAJZnP+/fbvUbBUNQrivxylkP2iIcUBAk16cbT7oMhGBtvfiq1+SlNZg2Xnp yj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wWLcKGVB1L+M/AiUcBrGPhY5Q0k7V6b5eY3DoUOJMD8=; b=gs0kzSM2V6VMwG6Wq/VWJeAqr9ZYjE9uSaqjWUJ76bPqz1AEN0PhQ++9Y2Oos+Ja0v /VAAHu3vlPrU0C7DYm9Z707dcv4/ZgHiE8cM1Ycc9xWd3VKeHQxYwKt4PA61rF0wUXM6 gzmc4xIFvoycKOcsikrUvxz0DlwGE2j/1j6oWiEc5TFeCJkecSwwCR1MK7EFyAt96atD fHYGshc4sKfydX8+RfyjaoklSofKHcCGsu5i0e+xpqrAqctr/sNdGkLa4U15CS0yQRnU T/nIERCSPWReLhYGdWYDwmtN3wYM+nbEUv2tJe+wdHcz6oN5Gy4OKnEYKJW1dDE0iEJM JwJw== X-Gm-Message-State: AOAM530JUDy3XEm+oYSAY0Vc4/P+JmxtcG2i1EoLSm+ypXpoyxbdOQFz g2apXk+Y02OPDeph0nQHgGU= X-Google-Smtp-Source: ABdhPJx3omdWEPyY14zY26ZL/okoE6UgJ7jwIZfMCKhDBqivpngpgjI4u0TAz3uLzlOh77rjr6U7+A== X-Received: by 2002:a5d:4ac1:: with SMTP id y1mr24447262wrs.588.1641145134005; Sun, 02 Jan 2022 09:38:54 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id b16sm35872809wmq.41.2022.01.02.09.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 09:38:53 -0800 (PST) Date: Sun, 2 Jan 2022 18:38:51 +0100 From: Corentin Labbe To: Conley Lee Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org, wens@csie.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, jernej.skrabec@gmail.com Subject: Re: [PATCH v6] sun4i-emac.c: add dma support Message-ID: References: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_093857_146694_FA7BBDFF X-CRM114-Status: GOOD ( 26.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgU2F0LCBKYW4gMDEsIDIwMjIgYXQgMDM6MDk6MDFQTSArMDgwMCwgQ29ubGV5IExlZSBhIMOp Y3JpdCA6Cj4gT24gMTIvMzEvMjEgYXQgMTE6NDPkuIrljYgsIENvcmVudGluIExhYmJlIHdyb3Rl Ogo+ID4gRGF0ZTogRnJpLCAzMSBEZWMgMjAyMSAxMTo0Mzo1MyArMDEwMAo+ID4gRnJvbTogQ29y ZW50aW4gTGFiYmUgPGNsYWJiZS5tb250am9pZUBnbWFpbC5jb20+Cj4gPiBUbzogY29ubGV5bGVl QGZveG1haWwuY29tCj4gPiBDYzogZGF2ZW1AZGF2ZW1sb2Z0Lm5ldCwga3ViYUBrZXJuZWwub3Jn LCBtcmlwYXJkQGtlcm5lbC5vcmcsCj4gPiAgd2Vuc0Bjc2llLm9yZywgbmV0ZGV2QHZnZXIua2Vy bmVsLm9yZywKPiA+ICBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcsIGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjZdIHN1bjRp LWVtYWMuYzogYWRkIGRtYSBzdXBwb3J0Cj4gPiAKPiA+IExlIFdlZCwgRGVjIDI5LCAyMDIxIGF0 IDA5OjQzOjUxQU0gKzA4MDAsIGNvbmxleWxlZUBmb3htYWlsLmNvbSBhIMOpY3JpdCA6Cj4gPiA+ IEZyb206IENvbmxleSBMZWUgPGNvbmxleWxlZUBmb3htYWlsLmNvbT4KPiA+ID4gCj4gPiA+IFRo YW5rcyBmb3IgeW91ciByZXZpZXcuIEhlcmUgaXMgdGhlIG5ldyB2ZXJzaW9uIGZvciB0aGlzIHBh dGNoLgo+ID4gPiAKPiA+ID4gVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgZm9yIHRoZSBlbWFjIHJ4 IGRtYSBwcmVzZW50IG9uIHN1bjRpLiBUaGUgZW1hYwo+ID4gPiBpcyBhYmxlIHRvIG1vdmUgcGFj a2V0cyBmcm9tIHJ4IGZpZm8gdG8gUkFNIGJ5IHVzaW5nIGRtYS4KPiA+ID4gCj4gPiA+IENoYW5n ZSBzaW5jZSB2NC4KPiA+ID4gICAtIHJlbmFtZSBzYmsgZmllbGQgdG8gc2tiCj4gPiA+ICAgLSBy ZW5hbWUgYWxsb2NfZW1hY19kbWFfcmVxIHRvIGVtYWNfYWxsb2NfZG1hX3JlcQo+ID4gPiAgIC0g dXNpbmcga3phbGxvYyguLi4sIEdQRl9BVE9NSUMpIGluIGludGVycnVwdCBjb250ZXh0IHRvIGF2 b2lkCj4gPiA+ICAgICBzbGVlcGluZwo+ID4gPiAgIC0gcmV0cnkgYnkgdXNpbmcgZW1hY19pbmJs a18zMmJpdCB3aGVuIGVtYWNfZG1hX2luYmxrXzMyYml0IGZhaWxzCj4gPiA+ICAgLSBmaXggc29t ZSBjb2RlIHN0eWxlIGlzc3VlcyAKPiA+ID4gCj4gPiA+IENoYW5nZSBzaW5jZSB2NS4KPiA+ID4g ICAtIGZpeCBzb21lIGNvZGUgc3R5bGUgaXNzdWUKPiA+ID4gCj4gPiAKPiA+IEhlbGxvCj4gPiAK PiA+IEkganVzdCB0ZXN0ZWQgdGhpcyBvbiBhIHN1bjRpLWExMC1vbGludXhpbm8tbGltZQo+ID4g Cj4gPiBJIGdvdDoKPiA+IFsgICAgMi45MjI4MTJdIHN1bjRpLWVtYWMgMWMwYjAwMC5ldGhlcm5l dCAodW5uYW1lZCBuZXRfZGV2aWNlKSAodW5pbml0aWFsaXplZCk6IGdldCBpbyByZXNvdXJjZSBm cm9tIGRldmljZTogMHgxYzBiMDAwLCBzaXplID0gNDA5Ngo+ID4gWyAgICAyLjkzNDUxMl0gc3Vu NGktZW1hYyAxYzBiMDAwLmV0aGVybmV0ICh1bm5hbWVkIG5ldF9kZXZpY2UpICh1bmluaXRpYWxp emVkKTogZmFpbGVkIHRvIHJlcXVlc3QgZG1hIGNoYW5uZWwuIGRtYSBpcyBkaXNhYmxlZAo+ID4g WyAgICAyLjk0NTc0MF0gc3VuNGktZW1hYyAxYzBiMDAwLmV0aGVybmV0ICh1bm5hbWVkIG5ldF9k ZXZpY2UpICh1bmluaXRpYWxpemVkKTogY29uZmlndXJlIGRtYSBmYWlsZWQuIGRpc2FibGUgZG1h Lgo+ID4gWyAgICAyLjk1Nzg4N10gc3VuNGktZW1hYyAxYzBiMDAwLmV0aGVybmV0OiBldGgwOiBh dCAocHRydmFsKSwgSVJRIDE5IE1BQzogMDI6NDk6MDk6NDA6YWI6M2QKPiA+IAo+ID4gT24gd2hp Y2ggYm9hcmQgZGlkIHlvdSB0ZXN0IGl0IGFuZCBob3cgPwo+ID4gCj4gPiBSZWdhcmRzCj4gCj4g U29ycnkuIEkgc2VudCB0aGUgZW1haWwgd2l0aCB0ZXh0L2h0bWwgZm9ybWF0LiBUaGlzIGVtYWls IGlzIGFuIGNsZWFuIHZlcnNpb24uCj4gCj4gSW4gb3JkZXIgdG8gZW5hYmxlIGRtYSByeCBjaGFu bmVsLiBgZG1hc2AgYW5kIGBkbWEtbmFtZXNgIHByb3BlcnRpZXMKPiBzaG91bGQgYmUgYWRkZWQg dG8gZW1hYyBzZWN0aW9uIGluIGR0czoKPiAKPiBlbWFjOiBldGhlcm5ldEAxYzBiMDAwIHsKPiAJ Li4uCj4gCWRtYXMgPSA8JmRtYSBTVU40SV9ETUFfREVESUNBVEVEIDc+Owo+IAlkbWEtbmFtZXMg PSAicngiOwo+IAkuLi4KPiB9CgpIZWxvCgpZZXMgSSBmaWd1cmVkIHRoYXQgb3V0LiBCdXQgeW91 IHNob3VsZCBoYXZlIGRvbmUgYSBwYXRjaCBzZXJpZSBhZGRpbmcgdGhpcy4KWW91ciBwYXRjaCBp cyBub3cgYXBwbGllZCBidXQgaXQgaXMgYSB1c2VsZXNzIGNoYW5nZSB3aXRob3V0IHRoZSBkdGIg Y2hhbmdlLgpZb3Ugc2hvdWxkIGFsc28gcHJvYmFibHkgdXBkYXRlIHRoZSBkcml2ZXIgYmluZGlu ZyAoRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9hbGx3aW5uZXIsc3VuNGkt YTEwLWVtYWMueWFtbCkgc2luY2UgeW91IGFkZCBuZXcgbWVtYmVycyB0byBEVCBub2RlLgoKRnVy dGhlcm1vcmUsIHdoeSBkaWQgeW91IGFkZCBSWCBvbmx5IGFuZCBub3QgVFggZG1hIGFsc28gPwoK UHJvYmFibHkgaXQgaXMgdG9vIGxhdGUgc2luY2UgcGF0Y2ggaXMgYXBwbGllZCBidXQgaXQgaXM6 ClRlc3RlZC1ieTogQ29yZW50aW4gTGFiYmUgPGNsYWJiZS5tb250am9pZUBnbWFpbC5jb20+ClRl c3RlZC1vbjogc3VuNGktYTEwLW9saW51eGluby1saW1lCgpSZWdhcmRzCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==