From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D1CC433EF for ; Mon, 3 Jan 2022 18:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235504AbiACSXF (ORCPT ); Mon, 3 Jan 2022 13:23:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235464AbiACSXE (ORCPT ); Mon, 3 Jan 2022 13:23:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F602C061761 for ; Mon, 3 Jan 2022 10:23:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54E44B80662 for ; Mon, 3 Jan 2022 18:23:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBCEC36AEF; Mon, 3 Jan 2022 18:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641234182; bh=a76zGH+Q3eGcTdvExp7rfkYP8GLNTvDU7E5GlOHQ+iM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E9KDhMIdVFXbmbaEJGo+TlnHQnNmCEIZpiTo9gKyyPq9msDvpuAZbZLtH5Ngvpxnk zuEuoRpt3SmWUGKBtdtZ5Hlyn9UC2WGCoEoK+PYu7uQJizSLV+dlu0X598mFu4ZXqG 7++vWLAIayLNHc5tp2arKZCPlchUIXvAFt4CzWRUnXImqCE+cRaCzcduQGlDJSQ0YM EeUzj7Ytn2GjXgYHDUcZSBNSKA5VV0SRGUj1VZ+HhBJrbaJaWppCOROuYoo71k2zDl DMBKEdNJZm/KhLTTm1rExrLjJTTZFJb+zCmgayJy2ZdpZPqcoCClozmj/2qSxsIGNV WUy1WIGSgbZSA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BB2C340B92; Mon, 3 Jan 2022 15:22:59 -0300 (-03) Date: Mon, 3 Jan 2022 15:22:59 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, H Peter Anvin , chang.seok.bae@intel.com, Masami Hiramatsu Subject: Re: [PATCH 0/6] x86/insn: Add instructions to instruction decoder Message-ID: References: <20211202095029.2165714-1-adrian.hunter@intel.com> <20211223153808.cddab56b114e5ddf755bd2d0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 03, 2022 at 05:40:00PM +0200, Adrian Hunter escreveu: > On 03/01/2022 17:01, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jan 03, 2022 at 11:56:08AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Mon, Jan 03, 2022 at 10:13:24AM +0200, Adrian Hunter escreveu: > >>> On 23/12/2021 08:38, Masami Hiramatsu wrote: > >>>> Hi, > >>>> > >>>> Sorry, I missed this series. > >>>> > >>>> On Thu, 2 Dec 2021 11:50:23 +0200 > >>>> Adrian Hunter wrote: > >>>> > >>>>> Hi > >>>>> > >>>>> Here are patches to bring the kernel and tools x86 instruction decoder > >>>>> more up to date. > >>>>> > >>>>> x86 instruction decoder is used for both kernel instructions and user space > >>>>> instructions (e.g. uprobes, perf tools Intel PT), so it is good to update > >>>>> it with new instructions. > >>>> > >>>> Hmm, I thought perf used objdump for that purpose internally. > >>>> Anyway, this series looks good to me. I'm a bit surprised that the > >>>> insn decoder can actually support those instructions only changing > >>>> X86_EVEX_M() macro :-) > >>>> > >>>> Acked-by: Masami Hiramatsu > >>>> > >>>> Thank you! > >>> > >>> Thanks! > >>> > >>> Arnaldo, could you consider taking these patches? > >> > >> I can pick the tools/ bits, the arch/x86/ should go via PeterZ, right? > >> Peter? > > > > I tried applying the whole shebang and got: > > > > ⬢[acme@toolbox perf]$ git am ./20211202_adrian_hunter_x86_insn_add_instructions_to_instruction_decoder.mbx > > Applying: perf tests: Add AMX instructions to x86 instruction decoder test > > Applying: x86/insn: Add AMX instructions to x86 instruction decoder > > Applying: perf tests: Add misc instructions to x86 instruction decoder test > > Applying: x86/insn: Add misc instructions to x86 instruction decoder > > Applying: perf tests: Add AVX512-FP16 instructions to x86 instruction decoder test > > Applying: x86/insn: Add AVX512-FP16 instructions to x86 instruction decoder > > error: patch failed: arch/x86/lib/x86-opcode-map.txt:896 > > error: arch/x86/lib/x86-opcode-map.txt: patch does not apply > > Patch failed at 0006 x86/insn: Add AVX512-FP16 instructions to x86 instruction decoder > > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > When you have resolved this problem, run "git am --continue". > > If you prefer to skip this patch, run "git am --skip" instead. > > To restore the original branch and stop patching, run "git am --abort". > > ⬢[acme@toolbox perf]$ > > > > So since this needs rebasing, could you please split it into two > > patchsets, one for tools/ and another for arch and send two batches? > > This way I'll pick the tools/ one, the x86 maintainers the other bits. > > > > Otherwise the x86 maintainers would have to test if the tools/ bits > > works as expected, etc. > > It seems not to be happening for me. What tree/branch is it? tmp.perf/core https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=tmp.perf/core I merged torvalds/master today, but it should work as that file was last changed looong ago: ⬢[acme@toolbox perf]$ git log arch/x86/lib/x86-opcode-map.txt | head commit 5790921bc18b1eb5c0c61371e31114fd4c4b0154 Author: Yu-cheng Yu Date: Tue Feb 4 09:14:24 2020 -0800 x86/insn: Add Control-flow Enforcement (CET) instructions to the opcode map Add the following CET instructions to the opcode map: INCSSP: Increment Shadow Stack pointer (SSP). ⬢[acme@toolbox perf]$ Perhaps related to b4? I'll try updating it and retrying... - Arnaldo