From: Sam Ravnborg <sam@ravnborg.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master 1/5] pwm: atmel: point MMIO accesses at correct address
Date: Mon, 3 Jan 2022 17:18:28 +0100 [thread overview]
Message-ID: <YdMh1FIPwhP9ga9C@ravnborg.org> (raw)
In-Reply-To: <YdMgSbOoD/1csUNT@ravnborg.org>
On Mon, Jan 03, 2022 at 05:11:53PM +0100, Sam Ravnborg wrote:
> Hi Ahmad,
>
> On Mon, Jan 03, 2022 at 12:57:14PM +0100, Ahmad Fatoum wrote:
> > The base address for MMIO writes was the address of the resource struct,
> > not the start address pointed at by it.
> >
> > Change untested, but it doesn't look like this driver could ever have
> > worked.
>
> You are right that I never got around to see backlight dimming work.
> I recall that backlight worked and then the pwm driver was added as part
> of several other patches for barebox.
> I should have dropped the patch until I had seen it actually work.
>
> But nice catch!
>
> I may try to dust of the skov board where this is used to test it.
> But these days I play with an i.MX6 board which has a bit more power,
> so no promises.
For the patch btw:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-01-03 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 11:57 [PATCH master 0/5] misc fixes Ahmad Fatoum
2022-01-03 11:57 ` [PATCH master 1/5] pwm: atmel: point MMIO accesses at correct address Ahmad Fatoum
2022-01-03 16:11 ` Sam Ravnborg
2022-01-03 16:18 ` Sam Ravnborg [this message]
2022-01-03 11:57 ` [PATCH master 2/5] clk: fixed: record parent name in clk_register_fixed_rate Ahmad Fatoum
2022-01-03 11:57 ` [PATCH master 3/5] imx-bbu-nand-fcb: suppress compiler warning about uninitialized use Ahmad Fatoum
2022-01-03 11:57 ` [PATCH master 4/5] regulator: fix broken reference counting on disable Ahmad Fatoum
2022-01-03 11:57 ` [PATCH master 5/5] regulator: respect "regulator-always-on" property Ahmad Fatoum
2022-01-05 7:28 ` [PATCH master 0/5] misc fixes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdMh1FIPwhP9ga9C@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.