From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Jakub Kicinski <kuba@kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Miroslav Lichvar <mlichvar@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH RFC V1 net-next 2/4] net: Expose available time stamping layers to user space.
Date: Mon, 3 Jan 2022 23:51:00 +0000 [thread overview]
Message-ID: <YdOL5Dc19lSAGTuj@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220103232555.19791-3-richardcochran@gmail.com>
On Mon, Jan 03, 2022 at 03:25:53PM -0800, Richard Cochran wrote:
> Time stamping on network packets may happen either in the MAC or in
> the PHY, but not both. In preparation for making the choice
> selectable, expose both the current and available layers via sysfs.
>
> In accordance with the kernel implementation as it stands, the current
> layer will always read as "phy" when a PHY time stamping device is
> present. Future patches will allow changing the current layer
> administratively.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Did you mean to introduce "selected_timestamping_layer" in this patch -
it appears to be a write only variable.
As it stands, it gets set to indicate PHY mode just by a network driver
binding to a PHY. If this gets used based on that decision to direct
where get_ts_info() goes, then this will break mvpp2 PTP.
I suggest that the introduction of "selected_timestamping_layer" is
moved to the patch where it's actually used for a better review.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-01-03 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 23:25 [PATCH RFC V1 net-next 2/4] net: Expose available time stamping layers to user space Richard Cochran
2022-01-03 23:51 ` Russell King (Oracle) [this message]
2022-01-04 10:00 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-08 21:19 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdOL5Dc19lSAGTuj@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.