From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>,
Christoph Hellwig <hch@infradead.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: The question of Q_XQUOTARM ioctl
Date: Mon, 3 Jan 2022 23:21:07 -0800 [thread overview]
Message-ID: <YdP1Y8FAeu871lr7@infradead.org> (raw)
In-Reply-To: <20220104023456.GE31606@magnolia>
On Mon, Jan 03, 2022 at 06:34:56PM -0800, Darrick J. Wong wrote:
> >
> > I don't know the right intention for Q_XQUOTARM now. Can you give me
> > some advise? Or, we should remove Q_XQUOTARM ioctl and
> > xfs_qm_scall_trunc_qfile code.
>
> I think xfs_qm_scall_trunc_qfiles probably should be doing:
>
> if (xfs_has_quota(mp) || flags == 0 ||
> (flags & ~XFS_QMOPT_QUOTALL)) {
> xfs_debug(...);
> return -EINVAL;
> }
>
> Note the inversion in the has_quota test. That would make it so that
> you can truncate the quota files if quota is not on.
Yes, that sounds reasonable. Although I'd split the xfs_has_quota
file into a separate check with a separate debug message.
next prev parent reply other threads:[~2022-01-04 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <616F9367.3030801@fujitsu.com>
2022-01-04 2:34 ` The question of Q_XQUOTARM ioctl Darrick J. Wong
2022-01-04 7:21 ` Christoph Hellwig [this message]
2022-01-04 20:46 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdP1Y8FAeu871lr7@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.