From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECF3CC433F5 for ; Tue, 4 Jan 2022 15:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=opZsk9rBT3G4La6LeWT8OdY+jBoUlOO3DaZDTXrUdpw=; b=0zWQgztJjPpzfH KYehlyy1ovlEX48ZPQgxlIPUsdxMDkZ8WfJzLBNzyaohgQxCxK0EtCIJIVwe7LYtwTXdNWDQYPqfR VTgfSmi4Vcijsg1dFdrMFZgCwe1TX/I2ZIRTs3RljIs9FaYKIo0Le67SCjTTivfnaFbeqW59dVcGu Je7Bk5AmmLQLODe34j9e5Ed64lISVJP59zpnElKi9V2ZctitOxxbfvtV4j088GW21EsAL/1tUwZ8c NHITtyYChkgqkWCRj5nzZqEl58MEIb/Oyj4hcECADpVhV8/JQE5Wi55zNwI6IaVlm1fOGac6lSI7X maO/xSVOjDAP+u9BrvFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4lL1-00Bqo8-9T; Tue, 04 Jan 2022 15:02:59 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4lKt-00Bqm7-U3 for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 15:02:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=09yxHMawDZ1z7mKKYD6EvM/m9RBDRbBGLNGga/wkLxY=; b=Aq8VGdFksWWCYmQGjMkY3Yuauv 48uEw3tJbJzwy+EIZA1QBynJF3WoUdUz/czXggGL0owr6v2Vxgc3+fEyWfducR71K7DIimCJ/k3hy 77wlD4rNhTXO65wv3cxpmw2OCbCHIMFOL3aucbH553pMpe6jysyoKcO0T1C/JBcU7tgg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n4lKo-000TVw-0W; Tue, 04 Jan 2022 16:02:46 +0100 Date: Tue, 4 Jan 2022 16:02:45 +0100 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Corentin Labbe , linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_070252_016197_5845FC92 X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > #define MII_88E1121_PHY_MSCR_RX_DELAY BIT(5) > > #define MII_88E1121_PHY_MSCR_TX_DELAY BIT(4) > > #define MII_88E1121_PHY_MSCR_DELAY_MASK (BIT(5) | BIT(4)) > > > > Bits 6 is the MSB of the default MAC speed. > > Bit 13 is the LSB of the default MAC speed. These two should default to 10b = 1000Mbps > > Bit 12 is reserved, and should be written 1. > > Hmm, seems odd that these speed bits match BMCR, and I'm not sure why > the default MAC speed would have any bearing on whether gigabit mode > is enabled. If they default to 10b, then the write should have no effect > unless boot firmware has changed them. There is a bit more, which is did not copy: Also, used for setting speed of MAC interface during MAC side loop-back. Requires that customer set both these bits and force speed using register 0 to the same speed. MAC Interface Speed during Link down. So i don't think they matter during normal operation. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0F0C433F5 for ; Tue, 4 Jan 2022 15:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234600AbiADPDE (ORCPT ); Tue, 4 Jan 2022 10:03:04 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50966 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234570AbiADPCw (ORCPT ); Tue, 4 Jan 2022 10:02:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=09yxHMawDZ1z7mKKYD6EvM/m9RBDRbBGLNGga/wkLxY=; b=Aq8VGdFksWWCYmQGjMkY3Yuauv 48uEw3tJbJzwy+EIZA1QBynJF3WoUdUz/czXggGL0owr6v2Vxgc3+fEyWfducR71K7DIimCJ/k3hy 77wlD4rNhTXO65wv3cxpmw2OCbCHIMFOL3aucbH553pMpe6jysyoKcO0T1C/JBcU7tgg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n4lKo-000TVw-0W; Tue, 04 Jan 2022 16:02:46 +0100 Date: Tue, 4 Jan 2022 16:02:45 +0100 From: Andrew Lunn To: "Russell King (Oracle)" Cc: Corentin Labbe , linus.walleij@linaro.org, ulli.kroll@googlemail.com, kuba@kernel.org, davem@davemloft.net, hkallweit1@gmail.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: net: phy: marvell: network working with generic PHY and not with marvell PHY Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > #define MII_88E1121_PHY_MSCR_RX_DELAY BIT(5) > > #define MII_88E1121_PHY_MSCR_TX_DELAY BIT(4) > > #define MII_88E1121_PHY_MSCR_DELAY_MASK (BIT(5) | BIT(4)) > > > > Bits 6 is the MSB of the default MAC speed. > > Bit 13 is the LSB of the default MAC speed. These two should default to 10b = 1000Mbps > > Bit 12 is reserved, and should be written 1. > > Hmm, seems odd that these speed bits match BMCR, and I'm not sure why > the default MAC speed would have any bearing on whether gigabit mode > is enabled. If they default to 10b, then the write should have no effect > unless boot firmware has changed them. There is a bit more, which is did not copy: Also, used for setting speed of MAC interface during MAC side loop-back. Requires that customer set both these bits and force speed using register 0 to the same speed. MAC Interface Speed during Link down. So i don't think they matter during normal operation. Andrew