From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Williams Date: Tue, 4 Jan 2022 12:20:26 -0600 Subject: [PATCH] mtd: aspeed-smc: improve probe resilience In-Reply-To: <20220103171721.46c8e697@xps13> References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> <20220103171721.46c8e697@xps13> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Miquel, On Mon, Jan 03, 2022 at 05:17:21PM +0100, Miquel Raynal wrote: > > I am fine with taking in bug fixes but no longer want to take in any new > > features. My main intention was to nudge you to convert it to SPI MEM > > regardless of whether this is a bug fix or a new feature, because > > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and > > the API that comes along with it. > > I totally agree with Pratyush here, we no longer want to support the > spi-nor controller API so if, as you say, there are boards failing > in the field, it means there are still users and these users must be > warned that at some point we might discontinue the support of these > drivers if it becomes too painful. > Your response here makes it seem like you don't realize the scope of this driver. There are probably, by my estimates, on the order of 10s of millions of deployed systems using this driver in the world. The vast majority of servers in the world use an AST2400, AST2500, or AST2600 chip, which needs this driver in order access its own flash storage device. Both OpenBMC and most of the proprietary alternatives use this driver. The company I work for has a LOT of systems using this code. After I made this fix, for a new design being developed, it was pointed out to me that our ODM ran into this problem a few years ago and we've been really bad about upstreaming those fixes. For this new system I'm trying to keep us on top of all upstreaming efforts. To me the inability to access your own storage, resulting in a kernel panic, is a pretty serious issue. Bug or feature I guess is always in the eye of the beholder though. I think this is pretty valuable to get in, from an impact standpoint, and pretty minimal in terms of maintenance efforts on the maintainers part. I had an offline discussion with someone who knew more history on this driver. My understanding is that the linux-aspeed team is aware of this being deprecated but that there was some missing support for interface training that nobody has gotten around to write? If that is the case this really isn't even a "simple" port to a new API at this point. -- Patrick Williams -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51731C433F5 for ; Tue, 4 Jan 2022 18:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GTTVQGyykEDU9U7C+sdXSGmTxJkKS2ToXzdq2AQ7DLc=; b=si8pZXtz3OIf7tLTJcLmUMf7Kx cUtl68uC3e9Npk8G186KvCCx7id3urTuwAOGPTOOXrC4ldbhuF+TCsUrLQAITEJhxoYIwvrH20OrW 6HcSNi/p1EzPjyw+bhIp9gVwdPf8NDRgeatMEZxXou/umAhiYTT4oxMrVqb28HKZ+HmoklDKUhMDy GIZHIjnU0CNu7P4dNJPzpkL3Tx3wpNIgc4zYJgBumVchNB9qWJKts5PnpQwnCnnCepi5GZsHT6s1x Vs/fk5YEMyq5kBfuuoFo6+nYc2qAuZdINWAwY98zXr3vdiLtNQJWBi/riGPBQOpF0u3RoQs9zZk+B 7bX9ypGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4oQR-00CSvF-9j; Tue, 04 Jan 2022 18:20:47 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4oQE-00CSsA-IP; Tue, 04 Jan 2022 18:20:36 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 6F60B58047C; Tue, 4 Jan 2022 13:20:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 04 Jan 2022 13:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=nzizLnHIDJLE77dWtL0gicrfFax qw30Dc5elZuFF93g=; b=NaBkrqt8rYn8R2HOjWvwZ8OGokiJNs/NYZ021cHzQhG MM4BVbxMYaYSGv8FiTSQF1FZkWenPDu/Wi6nYywU/gGqxppZZ5Ps7w8R5JDfwLsb oFkEZ0JutReD+E3byu180IYKBvU2N5wGlHsUNStxWGyfliIXTCC2rEum4ThGOntn D3gb/hXHhkzaFmMqncOajpS9tdGCB5d8NxsvmaROrj6Seci04C8vhw2QrWuc5sB+ CbjO7r1BTXVhOxDDJpzbpSZ52nF70ClOWgO1HziZt1gUzN6yj7/+pvzm41HKY8Dv h1B0WZlutBicN0XEEOsWqO9zyFQHU+Ry1hTP9OcmjEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nzizLn HIDJLE77dWtL0gicrfFaxqw30Dc5elZuFF93g=; b=UUeHByumxn11Uyq3tcYTjY Zk85hhI2yLQNfcA/jemzA86Tzm8+/9HM4r0oGWW1pIEeJ/lfU1XHWVqQTf/VTa2V rM1Iir5vPaPZHtii8CFp2wk+mZEz8YiAjK/I8jzGBMcZw/38WvoyRTnMf2ofDetD aYxdZILKOEoVt1YsdpTXdzUnCVR7A/Y2LHDxOghmLNQsZqgBf26AaY3c6EHORqlw 6cxLlZ77JlWoQ8T6tNVmaiZrBVrmva40XwH5bFdTXOfLb5WRozc5y5XLaTefc9te HQKFi6xblrvuOwbXVhlKytgYuAti0yUMEdpNP7SmCNRNQ71YZ7Q6UFxVLgXypB5Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeffedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghkse hsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpeegheehfeffgeekveehtdfhgfdu hfegfefgtdehhfektdelffevkefgueffhedtieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehprghtrhhitghksehsthiftgigrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jan 2022 13:20:27 -0500 (EST) Date: Tue, 4 Jan 2022 12:20:26 -0600 From: Patrick Williams To: Miquel Raynal Cc: Pratyush Yadav , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> <20220103171721.46c8e697@xps13> MIME-Version: 1.0 In-Reply-To: <20220103171721.46c8e697@xps13> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_102034_819462_70724B84 X-CRM114-Status: GOOD ( 24.94 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5699569607151195039==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============5699569607151195039== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4uGk4mNj2n7MOyWq" Content-Disposition: inline --4uGk4mNj2n7MOyWq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Miquel, On Mon, Jan 03, 2022 at 05:17:21PM +0100, Miquel Raynal wrote: > > I am fine with taking in bug fixes but no longer want to take in any ne= w=20 > > features. My main intention was to nudge you to convert it to SPI MEM= =20 > > regardless of whether this is a bug fix or a new feature, because=20 > > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and= =20 > > the API that comes along with it. >=20 > I totally agree with Pratyush here, we no longer want to support the > spi-nor controller API so if, as you say, there are boards failing > in the field, it means there are still users and these users must be > warned that at some point we might discontinue the support of these > drivers if it becomes too painful. > Your response here makes it seem like you don't realize the scope of this driver. There are probably, by my estimates, on the order of 10s of millio= ns of deployed systems using this driver in the world. The vast majority of serv= ers in the world use an AST2400, AST2500, or AST2600 chip, which needs this dri= ver in order access its own flash storage device. Both OpenBMC and most of the proprietary alternatives use this driver. The company I work for has a LOT of systems using this code. After I made = this fix, for a new design being developed, it was pointed out to me that our OD= M ran into this problem a few years ago and we've been really bad about upstreami= ng those fixes. For this new system I'm trying to keep us on top of all upstreaming efforts. To me the inability to access your own storage, resulting in a kernel panic= , is a pretty serious issue. Bug or feature I guess is always in the eye of the beholder though. I think this is pretty valuable to get in, from an impact standpoint, and pretty minimal in terms of maintenance efforts on the maintainers part. I had an offline discussion with someone who knew more history on this driv= er. My understanding is that the linux-aspeed team is aware of this being depre= cated but that there was some missing support for interface training that nobody = has gotten around to write? If that is the case this really isn't even a "simp= le" port to a new API at this point. --=20 Patrick Williams --4uGk4mNj2n7MOyWq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmHUj+gACgkQqwNHzC0A wRkIcBAAkolp24FJ1nPPX2egEXt6f48Kvsbrft91uSjMBg4RfefxO0fmpFDGNZFr edf5GnNtwVGM5sXAUKN5MixoKpb/fPN4ivCyBS7GixnoNxwc76pgOfhnGsSKCkrO SoRrdNWyOswuGzi5yBeGSUdcHRaVsTSSl5YdssCLfDvza1KrtVnKXnHJUaI4EB3o JB/zEh2p5C+TnOdR0ADhw6DuvFRb5mGq/XV2AfK4OGBDU/EoWE3m15zWCE5Wdu5d RjE6KooRKsGFR6NDw3yg8B3LZVEjLx/ehe9FZSJLn3jHQEeIXGbiulsrGQAIe7rN K3v04ZK+41Vx2NcavLKH8cCr4mtJ6jQbtQ0ups/EPuY8TLctc8sW27KGol/OJ4WU t6tAba0EfkGxa4GOy73fBZDzfax+Yr86G86xL1q1wiqnLiO2yGyyrrwJNj2KmkO8 uCzI+oStA4EE8lpUgZYHNVmeyc1cU6G1+bnG+0ekVeKcHZqixCGyBfHGNHpmMpkO p7YxULRCnX8GQwry+Ws1Iskk8e0MMVIRKLH7LAT7okT+TWVHsplnGL9binqqLpQ8 KLWR7QAEQBdNXi3XAwv8W6mfeeJ2sdG2WGZLUrabY3be9VwrbMLkCkT+smISoTtb Y0ALpgxI9OZzHfwpXWpkW3ecNdVf9AIARnceoSukBWZdrgmwDBU= =lc+5 -----END PGP SIGNATURE----- --4uGk4mNj2n7MOyWq-- --===============5699569607151195039== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============5699569607151195039==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C2ADC433EF for ; Tue, 4 Jan 2022 18:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1kuSHLzkpBZnmk4cFWSxqWT6DF8G48BJB0hFoRSkdzg=; b=3b3Yw5R6PPoJcm9DVxDnelDrE8 gzhT+gknG7ccM/0XURmxj8GAPfajhdrtyZiDrcd86RgjlsePv2A2LFInam/D9xI7p5juSSQoRJM3O neyTNpQ05cizxkc+J/ReVsHikiA/s+3oXUapH7+W3SlqPp0b1mVujzjlE3Y7hqCGjNx8PlJeIrck8 SHvV4V6LDNH6MCQW0Ld6SbQ/WSB1xBeJ1OYRytrzHUm9ut63qpCoKMY1zXft57uSYdhH3cQeyWW/B l3qtWg7QoE8MA1QK3jIth9XxUS2O1EY0Ma59J+f5iWtRF+hjcX2mk3Ye2fuiGvsSwWTwoGqGuufMl SRyv8RIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4oQH-00CStc-F3; Tue, 04 Jan 2022 18:20:37 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4oQE-00CSsA-IP; Tue, 04 Jan 2022 18:20:36 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 6F60B58047C; Tue, 4 Jan 2022 13:20:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 04 Jan 2022 13:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=nzizLnHIDJLE77dWtL0gicrfFax qw30Dc5elZuFF93g=; b=NaBkrqt8rYn8R2HOjWvwZ8OGokiJNs/NYZ021cHzQhG MM4BVbxMYaYSGv8FiTSQF1FZkWenPDu/Wi6nYywU/gGqxppZZ5Ps7w8R5JDfwLsb oFkEZ0JutReD+E3byu180IYKBvU2N5wGlHsUNStxWGyfliIXTCC2rEum4ThGOntn D3gb/hXHhkzaFmMqncOajpS9tdGCB5d8NxsvmaROrj6Seci04C8vhw2QrWuc5sB+ CbjO7r1BTXVhOxDDJpzbpSZ52nF70ClOWgO1HziZt1gUzN6yj7/+pvzm41HKY8Dv h1B0WZlutBicN0XEEOsWqO9zyFQHU+Ry1hTP9OcmjEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nzizLn HIDJLE77dWtL0gicrfFaxqw30Dc5elZuFF93g=; b=UUeHByumxn11Uyq3tcYTjY Zk85hhI2yLQNfcA/jemzA86Tzm8+/9HM4r0oGWW1pIEeJ/lfU1XHWVqQTf/VTa2V rM1Iir5vPaPZHtii8CFp2wk+mZEz8YiAjK/I8jzGBMcZw/38WvoyRTnMf2ofDetD aYxdZILKOEoVt1YsdpTXdzUnCVR7A/Y2LHDxOghmLNQsZqgBf26AaY3c6EHORqlw 6cxLlZ77JlWoQ8T6tNVmaiZrBVrmva40XwH5bFdTXOfLb5WRozc5y5XLaTefc9te HQKFi6xblrvuOwbXVhlKytgYuAti0yUMEdpNP7SmCNRNQ71YZ7Q6UFxVLgXypB5Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeffedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghkse hsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpeegheehfeffgeekveehtdfhgfdu hfegfefgtdehhfektdelffevkefgueffhedtieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehprghtrhhitghksehsthiftgigrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jan 2022 13:20:27 -0500 (EST) Date: Tue, 4 Jan 2022 12:20:26 -0600 From: Patrick Williams To: Miquel Raynal Cc: Pratyush Yadav , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> <20220103171721.46c8e697@xps13> MIME-Version: 1.0 In-Reply-To: <20220103171721.46c8e697@xps13> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_102034_819462_70724B84 X-CRM114-Status: GOOD ( 24.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3134137185538283001==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3134137185538283001== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4uGk4mNj2n7MOyWq" Content-Disposition: inline --4uGk4mNj2n7MOyWq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Miquel, On Mon, Jan 03, 2022 at 05:17:21PM +0100, Miquel Raynal wrote: > > I am fine with taking in bug fixes but no longer want to take in any ne= w=20 > > features. My main intention was to nudge you to convert it to SPI MEM= =20 > > regardless of whether this is a bug fix or a new feature, because=20 > > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and= =20 > > the API that comes along with it. >=20 > I totally agree with Pratyush here, we no longer want to support the > spi-nor controller API so if, as you say, there are boards failing > in the field, it means there are still users and these users must be > warned that at some point we might discontinue the support of these > drivers if it becomes too painful. > Your response here makes it seem like you don't realize the scope of this driver. There are probably, by my estimates, on the order of 10s of millio= ns of deployed systems using this driver in the world. The vast majority of serv= ers in the world use an AST2400, AST2500, or AST2600 chip, which needs this dri= ver in order access its own flash storage device. Both OpenBMC and most of the proprietary alternatives use this driver. The company I work for has a LOT of systems using this code. After I made = this fix, for a new design being developed, it was pointed out to me that our OD= M ran into this problem a few years ago and we've been really bad about upstreami= ng those fixes. For this new system I'm trying to keep us on top of all upstreaming efforts. To me the inability to access your own storage, resulting in a kernel panic= , is a pretty serious issue. Bug or feature I guess is always in the eye of the beholder though. I think this is pretty valuable to get in, from an impact standpoint, and pretty minimal in terms of maintenance efforts on the maintainers part. I had an offline discussion with someone who knew more history on this driv= er. My understanding is that the linux-aspeed team is aware of this being depre= cated but that there was some missing support for interface training that nobody = has gotten around to write? If that is the case this really isn't even a "simp= le" port to a new API at this point. --=20 Patrick Williams --4uGk4mNj2n7MOyWq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmHUj+gACgkQqwNHzC0A wRkIcBAAkolp24FJ1nPPX2egEXt6f48Kvsbrft91uSjMBg4RfefxO0fmpFDGNZFr edf5GnNtwVGM5sXAUKN5MixoKpb/fPN4ivCyBS7GixnoNxwc76pgOfhnGsSKCkrO SoRrdNWyOswuGzi5yBeGSUdcHRaVsTSSl5YdssCLfDvza1KrtVnKXnHJUaI4EB3o JB/zEh2p5C+TnOdR0ADhw6DuvFRb5mGq/XV2AfK4OGBDU/EoWE3m15zWCE5Wdu5d RjE6KooRKsGFR6NDw3yg8B3LZVEjLx/ehe9FZSJLn3jHQEeIXGbiulsrGQAIe7rN K3v04ZK+41Vx2NcavLKH8cCr4mtJ6jQbtQ0ups/EPuY8TLctc8sW27KGol/OJ4WU t6tAba0EfkGxa4GOy73fBZDzfax+Yr86G86xL1q1wiqnLiO2yGyyrrwJNj2KmkO8 uCzI+oStA4EE8lpUgZYHNVmeyc1cU6G1+bnG+0ekVeKcHZqixCGyBfHGNHpmMpkO p7YxULRCnX8GQwry+Ws1Iskk8e0MMVIRKLH7LAT7okT+TWVHsplnGL9binqqLpQ8 KLWR7QAEQBdNXi3XAwv8W6mfeeJ2sdG2WGZLUrabY3be9VwrbMLkCkT+smISoTtb Y0ALpgxI9OZzHfwpXWpkW3ecNdVf9AIARnceoSukBWZdrgmwDBU= =lc+5 -----END PGP SIGNATURE----- --4uGk4mNj2n7MOyWq-- --===============3134137185538283001== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3134137185538283001==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65969C433F5 for ; Tue, 4 Jan 2022 18:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236212AbiADSUe (ORCPT ); Tue, 4 Jan 2022 13:20:34 -0500 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:52555 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236208AbiADSUc (ORCPT ); Tue, 4 Jan 2022 13:20:32 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 6F60B58047C; Tue, 4 Jan 2022 13:20:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 04 Jan 2022 13:20:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=nzizLnHIDJLE77dWtL0gicrfFax qw30Dc5elZuFF93g=; b=NaBkrqt8rYn8R2HOjWvwZ8OGokiJNs/NYZ021cHzQhG MM4BVbxMYaYSGv8FiTSQF1FZkWenPDu/Wi6nYywU/gGqxppZZ5Ps7w8R5JDfwLsb oFkEZ0JutReD+E3byu180IYKBvU2N5wGlHsUNStxWGyfliIXTCC2rEum4ThGOntn D3gb/hXHhkzaFmMqncOajpS9tdGCB5d8NxsvmaROrj6Seci04C8vhw2QrWuc5sB+ CbjO7r1BTXVhOxDDJpzbpSZ52nF70ClOWgO1HziZt1gUzN6yj7/+pvzm41HKY8Dv h1B0WZlutBicN0XEEOsWqO9zyFQHU+Ry1hTP9OcmjEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nzizLn HIDJLE77dWtL0gicrfFaxqw30Dc5elZuFF93g=; b=UUeHByumxn11Uyq3tcYTjY Zk85hhI2yLQNfcA/jemzA86Tzm8+/9HM4r0oGWW1pIEeJ/lfU1XHWVqQTf/VTa2V rM1Iir5vPaPZHtii8CFp2wk+mZEz8YiAjK/I8jzGBMcZw/38WvoyRTnMf2ofDetD aYxdZILKOEoVt1YsdpTXdzUnCVR7A/Y2LHDxOghmLNQsZqgBf26AaY3c6EHORqlw 6cxLlZ77JlWoQ8T6tNVmaiZrBVrmva40XwH5bFdTXOfLb5WRozc5y5XLaTefc9te HQKFi6xblrvuOwbXVhlKytgYuAti0yUMEdpNP7SmCNRNQ71YZ7Q6UFxVLgXypB5Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeffedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghkse hsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpeegheehfeffgeekveehtdfhgfdu hfegfefgtdehhfektdelffevkefgueffhedtieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehprghtrhhitghksehsthiftgigrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jan 2022 13:20:27 -0500 (EST) Date: Tue, 4 Jan 2022 12:20:26 -0600 From: Patrick Williams To: Miquel Raynal Cc: Pratyush Yadav , Joel Stanley , Tudor Ambarus , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Andrew Jeffery , Potin Lai , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: aspeed-smc: improve probe resilience Message-ID: References: <20211229143334.297305-1-patrick@stwcx.xyz> <20211229173411.l2bipmi4x3arqjoo@ti.com> <20211231102623.izaqlzjvracbbgmp@ti.com> <20220103171721.46c8e697@xps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4uGk4mNj2n7MOyWq" Content-Disposition: inline In-Reply-To: <20220103171721.46c8e697@xps13> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4uGk4mNj2n7MOyWq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Miquel, On Mon, Jan 03, 2022 at 05:17:21PM +0100, Miquel Raynal wrote: > > I am fine with taking in bug fixes but no longer want to take in any ne= w=20 > > features. My main intention was to nudge you to convert it to SPI MEM= =20 > > regardless of whether this is a bug fix or a new feature, because=20 > > eventually we want to get rid of drivers/mtd/spi-nor/controllers/ and= =20 > > the API that comes along with it. >=20 > I totally agree with Pratyush here, we no longer want to support the > spi-nor controller API so if, as you say, there are boards failing > in the field, it means there are still users and these users must be > warned that at some point we might discontinue the support of these > drivers if it becomes too painful. > Your response here makes it seem like you don't realize the scope of this driver. There are probably, by my estimates, on the order of 10s of millio= ns of deployed systems using this driver in the world. The vast majority of serv= ers in the world use an AST2400, AST2500, or AST2600 chip, which needs this dri= ver in order access its own flash storage device. Both OpenBMC and most of the proprietary alternatives use this driver. The company I work for has a LOT of systems using this code. After I made = this fix, for a new design being developed, it was pointed out to me that our OD= M ran into this problem a few years ago and we've been really bad about upstreami= ng those fixes. For this new system I'm trying to keep us on top of all upstreaming efforts. To me the inability to access your own storage, resulting in a kernel panic= , is a pretty serious issue. Bug or feature I guess is always in the eye of the beholder though. I think this is pretty valuable to get in, from an impact standpoint, and pretty minimal in terms of maintenance efforts on the maintainers part. I had an offline discussion with someone who knew more history on this driv= er. My understanding is that the linux-aspeed team is aware of this being depre= cated but that there was some missing support for interface training that nobody = has gotten around to write? If that is the case this really isn't even a "simp= le" port to a new API at this point. --=20 Patrick Williams --4uGk4mNj2n7MOyWq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmHUj+gACgkQqwNHzC0A wRkIcBAAkolp24FJ1nPPX2egEXt6f48Kvsbrft91uSjMBg4RfefxO0fmpFDGNZFr edf5GnNtwVGM5sXAUKN5MixoKpb/fPN4ivCyBS7GixnoNxwc76pgOfhnGsSKCkrO SoRrdNWyOswuGzi5yBeGSUdcHRaVsTSSl5YdssCLfDvza1KrtVnKXnHJUaI4EB3o JB/zEh2p5C+TnOdR0ADhw6DuvFRb5mGq/XV2AfK4OGBDU/EoWE3m15zWCE5Wdu5d RjE6KooRKsGFR6NDw3yg8B3LZVEjLx/ehe9FZSJLn3jHQEeIXGbiulsrGQAIe7rN K3v04ZK+41Vx2NcavLKH8cCr4mtJ6jQbtQ0ups/EPuY8TLctc8sW27KGol/OJ4WU t6tAba0EfkGxa4GOy73fBZDzfax+Yr86G86xL1q1wiqnLiO2yGyyrrwJNj2KmkO8 uCzI+oStA4EE8lpUgZYHNVmeyc1cU6G1+bnG+0ekVeKcHZqixCGyBfHGNHpmMpkO p7YxULRCnX8GQwry+Ws1Iskk8e0MMVIRKLH7LAT7okT+TWVHsplnGL9binqqLpQ8 KLWR7QAEQBdNXi3XAwv8W6mfeeJ2sdG2WGZLUrabY3be9VwrbMLkCkT+smISoTtb Y0ALpgxI9OZzHfwpXWpkW3ecNdVf9AIARnceoSukBWZdrgmwDBU= =lc+5 -----END PGP SIGNATURE----- --4uGk4mNj2n7MOyWq--