From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B497C433F5 for ; Tue, 4 Jan 2022 23:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236572AbiADXor (ORCPT ); Tue, 4 Jan 2022 18:44:47 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55469 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236566AbiADXoq (ORCPT ); Tue, 4 Jan 2022 18:44:46 -0500 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 021401C0006; Tue, 4 Jan 2022 23:44:44 +0000 (UTC) Date: Wed, 5 Jan 2022 00:44:44 +0100 From: Alexandre Belloni To: Radhey Shyam Pandey Cc: Srinivas Neeli , "a.zummo@towertech.it" , Michal Simek , Srinivas Goud , Shubhrajyoti Datta , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , git Subject: Re: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information Message-ID: References: <20211130055541.2789-1-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hello Srinivas, On 30/11/2021 06:37:45+0000, Radhey Shyam Pandey wrote: > > -----Original Message----- > > From: Srinivas Neeli > > Sent: Tuesday, November 30, 2021 11:26 AM > > To: a.zummo@towertech.it; alexandre.belloni@bootlin.com; Michal Simek > > ; Srinivas Goud ; Shubhrajyoti Datta > > ; Radhey Shyam Pandey > > Cc: linux-rtc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; git ; Srinivas Neeli > > > > Subject: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information > > > > Added clock information and deprecated calibration support. > > Better to also add some background for this change. > > > > Signed-off-by: Srinivas Neeli > > Please add Rob and DT mailing list. > I'm indeed waiting on Rob's review... > ./scripts/get_maintainer.pl <.patch> > > --- > > Changes in V3: > > -New patch > > --- > > .../bindings/rtc/xlnx,zynqmp-rtc.yaml | 20 +++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > index bdb72d3ddf2a..7e87bc1ef9df 100644 > > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > @@ -26,20 +26,19 @@ properties: > > interrupts: > > minItems: 2 > > > > + clocks: > > + items: > > + - description: rtc_clk is the operating frequency of crystal. > > + > > + clock-names: > > + items: > > + - const: "rtc_clk" > > + > > interrupt-names: > > items: > > - const: alarm > > - const: sec > > > > - calibration: > > What about existing users for this property? > > - description: | > > - calibration value for 1 sec period which will > > - be programmed directly to calibration register. > > - $ref: /schemas/types.yaml#/definitions/uint32 > > - minimum: 0x1 > > - maximum: 0x1FFFFF > > - default: 0x198233 > > - I think this needs to stay to mark it as deprecated. > > required: > > - compatible > > - reg > > @@ -60,6 +59,7 @@ examples: > > interrupt-parent = <&gic>; > > interrupts = <0 26 4>, <0 27 4>; > > interrupt-names = "alarm", "sec"; > > - calibration = <0x198233>; > > + clock-names = "rtc_clk"; > > + clocks = <&rtc_clk>; > > }; > > }; > > -- > > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA396C433F5 for ; Tue, 4 Jan 2022 23:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7QfXl2WAqGqWCzydAnTwcY7Egfl+TyGXExsAmX3Izhg=; b=EgDy4/BElJXDlz vtIRKW0IlQIOZKxZ+Rykub/4PtLG7mp3b/wpvQ7APhsFhYQ5ZhB5GhGppTsfiUwaRAiutxd+djjAN oDPfO8PccRopoH0B4OkpcRs7MlSv6BLhkjIRMkgSQaozVbpilmov1Zudx6jm0nQJbQ2bOPy8H0Kh6 XDw/PC/x5HB5yu01LwjMLIcRpUzZiLeLA9/yWeN3+jbISiwWJvJcFKNUogjTZqb9nXumtsG/FsO1V F1ptgKn+s+tgCfSiKVrUBTQ17KjwRqbFi3O1OXkHM00IYS3IMBdPAMKYmxpvr25xgruIGqBJdk0Qa G1z3y1n8stg1kDIyiGOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4tU6-00D83h-GW; Tue, 04 Jan 2022 23:44:54 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4tU2-00D82X-BP for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 23:44:52 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 021401C0006; Tue, 4 Jan 2022 23:44:44 +0000 (UTC) Date: Wed, 5 Jan 2022 00:44:44 +0100 From: Alexandre Belloni To: Radhey Shyam Pandey Cc: Srinivas Neeli , "a.zummo@towertech.it" , Michal Simek , Srinivas Goud , Shubhrajyoti Datta , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , git Subject: Re: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information Message-ID: References: <20211130055541.2789-1-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_154450_580193_FB11C99C X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Srinivas, On 30/11/2021 06:37:45+0000, Radhey Shyam Pandey wrote: > > -----Original Message----- > > From: Srinivas Neeli > > Sent: Tuesday, November 30, 2021 11:26 AM > > To: a.zummo@towertech.it; alexandre.belloni@bootlin.com; Michal Simek > > ; Srinivas Goud ; Shubhrajyoti Datta > > ; Radhey Shyam Pandey > > Cc: linux-rtc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; git ; Srinivas Neeli > > > > Subject: [PATCH V3 1/2] dt-bindings: rtc: zynqmp: Add clock information > > > > Added clock information and deprecated calibration support. > > Better to also add some background for this change. > > > > Signed-off-by: Srinivas Neeli > > Please add Rob and DT mailing list. > I'm indeed waiting on Rob's review... > ./scripts/get_maintainer.pl <.patch> > > --- > > Changes in V3: > > -New patch > > --- > > .../bindings/rtc/xlnx,zynqmp-rtc.yaml | 20 +++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > index bdb72d3ddf2a..7e87bc1ef9df 100644 > > --- a/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/xlnx,zynqmp-rtc.yaml > > @@ -26,20 +26,19 @@ properties: > > interrupts: > > minItems: 2 > > > > + clocks: > > + items: > > + - description: rtc_clk is the operating frequency of crystal. > > + > > + clock-names: > > + items: > > + - const: "rtc_clk" > > + > > interrupt-names: > > items: > > - const: alarm > > - const: sec > > > > - calibration: > > What about existing users for this property? > > - description: | > > - calibration value for 1 sec period which will > > - be programmed directly to calibration register. > > - $ref: /schemas/types.yaml#/definitions/uint32 > > - minimum: 0x1 > > - maximum: 0x1FFFFF > > - default: 0x198233 > > - I think this needs to stay to mark it as deprecated. > > required: > > - compatible > > - reg > > @@ -60,6 +59,7 @@ examples: > > interrupt-parent = <&gic>; > > interrupts = <0 26 4>, <0 27 4>; > > interrupt-names = "alarm", "sec"; > > - calibration = <0x198233>; > > + clock-names = "rtc_clk"; > > + clocks = <&rtc_clk>; > > }; > > }; > > -- > > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel