All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] tst_af_alg: Moving tst_res(TCONF) to tst_have_alg()
Date: Wed, 5 Jan 2022 15:41:08 +0100	[thread overview]
Message-ID: <YdWuBJ2vF9N8zCWQ@yuki> (raw)
In-Reply-To: <20211222192604.16839-1-pvorel@suse.cz>

Hi!
> +bool tst_have_alg(const char *algtype, const char *algname)
> +{
> +	int ret;
> +
> +	ret = tst_try_alg(algtype, algname);
> +
> +	switch (ret) {
> +	case 0:
> +		return true;
> +	case ENOENT:
> +		tst_res(TCONF, "kernel doesn't have %s algorithm '%s'",
> +			algtype, algname);
> +		return false;
> +	default:
> +		errno = ret;
> +		tst_brk(TBROK | TERRNO,
> +			"unexpected error binding AF_ALG socket to %s algorithm '%s'",
> +			algtype, algname);
> +		return false;
> +	break;

This break is useless, otherwise:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-01-05 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 19:26 [LTP] [PATCH v3 1/2] tst_af_alg: Moving tst_res(TCONF) to tst_have_alg() Petr Vorel
2021-12-22 19:26 ` [LTP] [PATCH v3 2/2] tst_af_alg: TCONF on ciphers disabled by FIPS Petr Vorel
2022-01-05 14:44   ` Cyril Hrubis
2022-01-05 15:04   ` Eric Biggers
2022-01-05 16:52     ` Petr Vorel
2022-01-05 14:41 ` Cyril Hrubis [this message]
2022-01-05 15:03 ` [LTP] [PATCH v3 1/2] tst_af_alg: Moving tst_res(TCONF) to tst_have_alg() Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdWuBJ2vF9N8zCWQ@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.