From: Yevhen Orlov <yevhen.orlov@plvision.eu>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
andrew@lunn.ch, Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Taras Chornyi <tchornyi@marvell.com>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 6/6] net: marvell: prestera: Implement initial inetaddr notifiers
Date: Thu, 6 Jan 2022 06:31:06 +0200 [thread overview]
Message-ID: <YdZwigIn6IG3a4h4@yorlov.ow.s> (raw)
In-Reply-To: <Yc3EmyltW1BVQv2n@shredder>
On Thu, Dec 30, 2021 at 04:39:23PM +0200, Ido Schimmel wrote:
> > + return -EEXIST;
> > + }
> > + re = prestera_rif_entry_create(port->sw, &re_key,
> > + prestera_fix_tb_id(kern_tb_id),
> > + port_dev->dev_addr);
> > + if (!re) {
> > + NL_SET_ERR_MSG_MOD(extack, "Can't create rif_entry");
> > + return -EINVAL;
> > + }
> > + dev_hold(port_dev);
>
> What is the purpose of this dev_hold()?
>
To make sure the port_dev is not freed before rif destroyed.
prev parent reply other threads:[~2022-01-06 4:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 21:52 [PATCH net-next v2 0/6] prestera: add basic router driver support Yevhen Orlov
2021-12-27 21:52 ` [PATCH net-next v2 1/6] net: marvell: prestera: add virtual router ABI Yevhen Orlov
2021-12-30 13:41 ` Ido Schimmel
2021-12-27 21:52 ` [PATCH net-next v2 2/6] net: marvell: prestera: Add router interface ABI Yevhen Orlov
2021-12-30 13:44 ` Ido Schimmel
2022-01-07 2:15 ` Yevhen Orlov
2021-12-27 21:52 ` [PATCH net-next v2 3/6] net: marvell: prestera: Add prestera router infra Yevhen Orlov
2021-12-30 13:48 ` Ido Schimmel
2021-12-27 21:52 ` [PATCH net-next v2 4/6] net: marvell: prestera: add hardware router objects accounting Yevhen Orlov
2021-12-30 14:19 ` Ido Schimmel
2021-12-27 21:52 ` [PATCH net-next v2 5/6] net: marvell: prestera: Register inetaddr stub notifiers Yevhen Orlov
2021-12-30 14:34 ` Ido Schimmel
2022-01-07 1:42 ` Yevhen Orlov
2022-01-07 13:43 ` Andrew Lunn
2022-01-11 1:00 ` Yevhen Orlov
2021-12-27 21:52 ` [PATCH net-next v2 6/6] net: marvell: prestera: Implement initial inetaddr notifiers Yevhen Orlov
2021-12-30 14:39 ` Ido Schimmel
2022-01-06 4:31 ` Yevhen Orlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdZwigIn6IG3a4h4@yorlov.ow.s \
--to=yevhen.orlov@plvision.eu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=stephen@networkplumber.org \
--cc=taras.chornyi@plvision.eu \
--cc=tchornyi@marvell.com \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.