From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1923C433F5 for ; Thu, 6 Jan 2022 13:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239560AbiAFNZg (ORCPT ); Thu, 6 Jan 2022 08:25:36 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:43828 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239534AbiAFNZf (ORCPT ); Thu, 6 Jan 2022 08:25:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F1FE61C15 for ; Thu, 6 Jan 2022 13:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8685EC36AE3; Thu, 6 Jan 2022 13:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641475535; bh=buV0gYWbk3HVWfvOrcfUs3J4fxNfedsrK8daEDtIzx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hD91Fm1JArQgrZOznJTSwWQEL/6hIlrqxutgzox5t1nFaTWlgdyHlSKHCIk29EqM7 q0jq3/k1z/szOUrbA/H2GMjBYnnw9U2nKArcAeNP1QtN6yHgHcGAduWoZsob0X+1CW /ZGsqaX0JXae6lNEvno75wK3IZ5gebq9lSaltiYg= Date: Thu, 6 Jan 2022 14:25:32 +0100 From: Greg Kroah-Hartman To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Gabriel Somlo , qemu-devel@nongnu.org Subject: Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type Message-ID: References: <20220105183133.2812848-1-gregkh@linuxfoundation.org> <20220105175546-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220105175546-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote: > > There are currently 2 ways to create a set of sysfs files for a > > kobj_type, through the default_attrs field, and the default_groups > > field. Move the firmware qemu_fw_cfg sysfs code to use default_groups > > field which has been the preferred way since aa30f47cf666 ("kobject: Add > > support for default attribute groups to kobj_type") so that we can soon > > get rid of the obsolete default_attrs field. > > > > Cc: Gabriel Somlo > > Cc: "Michael S. Tsirkin" > > Cc: qemu-devel@nongnu.org > > Signed-off-by: Greg Kroah-Hartman > > OK then you know best I guess > > Acked-by: Michael S. Tsirkin > > feel free to queue. Thanks, will do! greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 079D5C433FE for ; Thu, 6 Jan 2022 14:10:05 +0000 (UTC) Received: from localhost ([::1]:45338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5TSu-00009E-2Q for qemu-devel@archiver.kernel.org; Thu, 06 Jan 2022 09:10:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Slz-00079c-59 for qemu-devel@nongnu.org; Thu, 06 Jan 2022 08:25:43 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:45042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Slx-0002TZ-6N for qemu-devel@nongnu.org; Thu, 06 Jan 2022 08:25:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 55B5BB8212E; Thu, 6 Jan 2022 13:25:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8685EC36AE3; Thu, 6 Jan 2022 13:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641475535; bh=buV0gYWbk3HVWfvOrcfUs3J4fxNfedsrK8daEDtIzx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hD91Fm1JArQgrZOznJTSwWQEL/6hIlrqxutgzox5t1nFaTWlgdyHlSKHCIk29EqM7 q0jq3/k1z/szOUrbA/H2GMjBYnnw9U2nKArcAeNP1QtN6yHgHcGAduWoZsob0X+1CW /ZGsqaX0JXae6lNEvno75wK3IZ5gebq9lSaltiYg= Date: Thu, 6 Jan 2022 14:25:32 +0100 From: Greg Kroah-Hartman To: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu_fw_cfg: use default_groups in kobj_type Message-ID: References: <20220105183133.2812848-1-gregkh@linuxfoundation.org> <20220105175546-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220105175546-mutt-send-email-mst@kernel.org> Received-SPF: pass client-ip=145.40.68.75; envelope-from=gregkh@linuxfoundation.org; helo=ams.source.kernel.org X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.372, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gabriel Somlo , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jan 05, 2022 at 05:56:26PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 05, 2022 at 07:31:33PM +0100, Greg Kroah-Hartman wrote: > > There are currently 2 ways to create a set of sysfs files for a > > kobj_type, through the default_attrs field, and the default_groups > > field. Move the firmware qemu_fw_cfg sysfs code to use default_groups > > field which has been the preferred way since aa30f47cf666 ("kobject: Add > > support for default attribute groups to kobj_type") so that we can soon > > get rid of the obsolete default_attrs field. > > > > Cc: Gabriel Somlo > > Cc: "Michael S. Tsirkin" > > Cc: qemu-devel@nongnu.org > > Signed-off-by: Greg Kroah-Hartman > > OK then you know best I guess > > Acked-by: Michael S. Tsirkin > > feel free to queue. Thanks, will do! greg k-h