From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-trace-devel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
torvalds@linux-foundation.org, eranian@google.com
Subject: Re: [PATCH] perf build: Lower the priority of tools/lib includes
Date: Thu, 6 Jan 2022 16:28:58 -0300 [thread overview]
Message-ID: <YddC+lzAO1Urj0TF@kernel.org> (raw)
In-Reply-To: <20220106072627.476524-1-irogers@google.com>
Em Wed, Jan 05, 2022 at 11:26:27PM -0800, Ian Rogers escreveu:
> tools/lib has a 1.1.0 copy of libtraceevent. If a newer system
> version is installed then its headers will go in /usr/include. As -I has
> priority over system headers the 1.1.0 version gets used in preference
> to the system one, which isn't what is wanted. To make the behavior
> match expectations use -idirafter so that any system headers have priority
> over the tools/lib version.
>
> Fixes: 08efcb4a638d ("libtraceevent: Increase libtraceevent logging when verbose")
Hi,
You forgot to add your Signed-off-by:, I'm adding it as you
usually provide it, ok?
- Arnaldo
> ---
> tools/perf/Makefile.config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 96ad944ca6a8..0627286380fa 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -346,7 +346,7 @@ endif
>
> INC_FLAGS += -I$(src-perf)/util
> INC_FLAGS += -I$(src-perf)
> -INC_FLAGS += -I$(srctree)/tools/lib/
> +INC_FLAGS += -idirafter$(srctree)/tools/lib/
>
> CORE_CFLAGS += -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
>
> --
> 2.34.1.448.ga2b2bfdf31-goog
--
- Arnaldo
next prev parent reply other threads:[~2022-01-06 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 7:26 [PATCH] perf build: Lower the priority of tools/lib includes Ian Rogers
2022-01-06 19:28 ` Arnaldo Carvalho de Melo [this message]
2022-01-06 19:30 ` Arnaldo Carvalho de Melo
2022-01-06 20:24 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YddC+lzAO1Urj0TF@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jirislaby@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.