From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Antoine Viallon via Linux-f2fs-devel
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] fsck.f2fs: Add progression feedback
Date: Thu, 6 Jan 2022 11:48:38 -0800 [thread overview]
Message-ID: <YddHlrYFwudXfh8e@google.com> (raw)
In-Reply-To: <c22ac22e-f545-1c2b-0479-34d32b3c960a@kernel.org>
Hi Antonie,
I actually took a look at the patch yesterday and tested a bit to avoid too many
messages. Could you please check this out?
https://github.com/jaegeuk/f2fs-tools/commit/45b3c75ac3c07d444180a3598f0d48c80abe9934
On 01/06, Chao Yu wrote:
> On 2022/1/6 23:33, Antoine Viallon wrote:
> > Thank you for your reply.
> >
> > > How about showing this message in debug mode? may be under level one?
> >
> > > Thanks,
> >
> >
> > The debug output is extremely verbose, even at level one (I measured hundreds of messages per SECOND on a SATA SSD).
> > If we print the progress in this output, it would be completely drawn in the other messages, therefore making it useless.
>
> Yup, :-p
>
> >
> > Thus, we should either decrease the debug 1 verbosity (hard), or add a new, independent flag (or way) to control it.
>
> Maybe -v?
>
> Thanks,
>
> >
> > What do you think?
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-01-06 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 0:29 [f2fs-dev] [PATCH] fsck.f2fs: Add progression feedback Antoine Viallon via Linux-f2fs-devel
2021-12-30 0:59 ` Antoine Viallon via Linux-f2fs-devel
2022-01-06 11:40 ` Antoine Viallon via Linux-f2fs-devel
2022-01-06 11:48 ` Chao Yu via Linux-f2fs-devel
2022-01-06 11:48 ` Chao Yu
2022-01-06 15:33 ` Antoine Viallon via Linux-f2fs-devel
2022-01-06 15:42 ` Chao Yu
2022-01-06 19:48 ` Jaegeuk Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-30 0:25 Antoine Viallon via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YddHlrYFwudXfh8e@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.