All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pintu Kumar <quic_pintu@quicinc.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org, ebiederm@xmission.com,
	christian.brauner@ubuntu.com, sfr@canb.auug.org.au,
	legion@kernel.org, sashal@kernel.org, chris.hyser@oracle.com,
	ccross@google.com, pcc@google.com, dave@stgolabs.net,
	caoxiaofeng@yulong.com, david@redhat.com, pintu.ping@gmail.com,
	vbabka@suse.cz, linux-api@vger.kernel.org
Subject: Re: [PATCH v2] sysinfo: include availram field in sysinfo struct
Date: Sat, 8 Jan 2022 00:01:32 +0300	[thread overview]
Message-ID: <YdiqLKS5Sv9eWwu2@grain> (raw)
In-Reply-To: <1641578854-14232-1-git-send-email-quic_pintu@quicinc.com>

On Fri, Jan 07, 2022 at 11:37:34PM +0530, Pintu Kumar wrote:
> The sysinfo member does not have any "available ram" field and
> the bufferram field is not much helpful either, to get a rough
> estimate of available ram needed for allocation.
> 
> One needs to parse MemAvailable field separately from /proc/meminfo
> to get this info instead of directly getting if from sysinfo itself.

Who exactly needs this change? Do you have some application for which
parsing /proc/meminfo is a hot path so it needs this information via
sysinfo interface?

Don't get me wrong please but such extension really need a strong
justification because they are part of UAPI and there is not that much
space left in sysinfo structure. We will _have_ to live with this new
field forever so I propose to not introduce anything new here until
we have no other choise or parsing meminfo become a really bottleneck.

> diff --git a/kernel/sys.c b/kernel/sys.c
> index ecc4cf0..7059515 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -2671,6 +2671,7 @@ static int do_sysinfo(struct sysinfo *info)
>  	info->freeram <<= bitcount;
>  	info->sharedram <<= bitcount;
>  	info->bufferram <<= bitcount;
> +	info->availram <<= bitcount;
>  	info->totalswap <<= bitcount;
>  	info->freeswap <<= bitcount;
>  	info->totalhigh <<= bitcount;
> @@ -2700,6 +2701,7 @@ struct compat_sysinfo {
>  	u32 freeram;
>  	u32 sharedram;
>  	u32 bufferram;
> +	u32 availram;

If only I'm not missing something ovious, this is part of UAPI as well.

  reply	other threads:[~2022-01-07 21:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 15:34 [PATCH] sysinfo: include availram field in sysinfo struct Pintu Kumar
2022-01-06 16:11 ` Cyrill Gorcunov
2022-01-06 16:49   ` Pintu Agarwal
2022-01-06 17:27     ` Cyrill Gorcunov
2022-01-07 12:04       ` Christian Brauner
2022-01-07 13:44         ` Pintu Agarwal
2022-01-07 16:58           ` Vlastimil Babka
2022-01-07 17:47             ` Pintu Agarwal
2022-01-07 22:18             ` David Laight
2022-01-07 19:51         ` Cyrill Gorcunov
2022-01-06 17:41     ` David Laight
2022-01-06 17:59       ` Pintu Agarwal
2022-01-06 19:20         ` Eric W. Biederman
2022-01-07 18:07 ` [PATCH v2] " Pintu Kumar
2022-01-07 21:01   ` Cyrill Gorcunov [this message]
2022-01-08 16:24     ` Pintu Agarwal
2022-01-10  8:11       ` Cyrill Gorcunov
2022-01-07 22:22   ` David Laight
2022-01-08 16:53     ` Pintu Agarwal
2022-01-08 22:35       ` David Laight
2022-01-10 14:55         ` Pintu Agarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdiqLKS5Sv9eWwu2@grain \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=caoxiaofeng@yulong.com \
    --cc=ccross@google.com \
    --cc=chris.hyser@oracle.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=legion@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=pintu.ping@gmail.com \
    --cc=quic_pintu@quicinc.com \
    --cc=sashal@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.