From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>
Subject: Re: [PATCHSET 0/6] perf lock: Random updates for the locking analysis (v1)
Date: Sun, 9 Jan 2022 14:13:09 +0100 [thread overview]
Message-ID: <YdrfZViFXdGF+3vc@krava> (raw)
In-Reply-To: <20220104182054.25009-1-namhyung@kernel.org>
On Tue, Jan 04, 2022 at 10:20:48AM -0800, Namhyung Kim wrote:
SNIP
> With -c option, the hrtimer_bases.lock would be combined into a single
> entry. Also note that the lock names are correctly displayed now.
>
> # perf lock report -c
> Name acquired contended avg wait (ns) total wait (ns) max wait (ns) min wait (ns)
>
> rcu_read_lock 251225 0 0 0 0 0
> hrtimer_bases.lock 39449 0 0 0 0 0
> &sb->s_type->i_l... 10301 1 662 662 662 662
> ptlock_ptr(page) 10173 2 701 1402 760 642
> &(ei->i_block_re... 8732 0 0 0 0 0
> &base->lock 6705 0 0 0 0 0
> &p->pi_lock 5549 0 0 0 0 0
> &dentry->d_lockr... 5010 4 1274 5097 1844 789
> &ep->lock 2750 0 0 0 0 0
> &(__futex_data.q... 2331 0 0 0 0 0
> (null) 1878 0 0 0 0 0
> cpu_hotplug_lock 1350 0 0 0 0 0
> &____s->seqcount 1349 0 0 0 0 0
> &newf->file_lock 1001 15 1025 15388 2279 618
> ...
>
> Maybe we can make it default later (with a config and --no-combine-locks).
>
> You can get it from 'perf/lock-combine-v1' branch at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Thanks,
> Namhyung
>
>
> Namhyung Kim (6):
> perf lock: Convert lockhash_table to use hlist
> perf lock: Change type of lock_stat->addr to u64
> perf lock: Sort map info based on class name
> perf lock: Fix lock name length check for printing
> perf lock: Add -c/--combine-locks option
> perf lock: Carefully combine lock stats for discarded entries
>
> tools/perf/Documentation/perf-lock.txt | 4 +
> tools/perf/builtin-lock.c | 155 +++++++++++++++++++------
> 2 files changed, 124 insertions(+), 35 deletions(-)
LGTM
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
>
> base-commit: b9f6fbb3b2c29736970ae9fcc0e82b0bd459442b
> --
> 2.34.1.448.ga2b2bfdf31-goog
>
prev parent reply other threads:[~2022-01-09 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 18:20 [PATCHSET 0/6] perf lock: Random updates for the locking analysis (v1) Namhyung Kim
2022-01-04 18:20 ` [PATCH 1/6] perf lock: Convert lockhash_table to use hlist Namhyung Kim
2022-01-04 18:20 ` [PATCH 2/6] perf lock: Change type of lock_stat->addr to u64 Namhyung Kim
2022-01-04 18:20 ` [PATCH 3/6] perf lock: Sort map info based on class name Namhyung Kim
2022-01-04 18:20 ` [PATCH 4/6] perf lock: Fix lock name length check for printing Namhyung Kim
2022-01-04 18:20 ` [PATCH 5/6] perf lock: Add -c/--combine-locks option Namhyung Kim
2022-01-04 18:20 ` [PATCH 6/6] perf lock: Carefully combine lock stats for discarded entries Namhyung Kim
2022-01-09 13:13 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdrfZViFXdGF+3vc@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.