From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5B2C433EF for ; Mon, 10 Jan 2022 19:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243032AbiAJTEN (ORCPT ); Mon, 10 Jan 2022 14:04:13 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:57838 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242133AbiAJTEK (ORCPT ); Mon, 10 Jan 2022 14:04:10 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55CF061371; Mon, 10 Jan 2022 19:04:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BF16C36AE9; Mon, 10 Jan 2022 19:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641841449; bh=cdjGtgT7hFFoUrAC32QBfLrZvKnHOeTvpFGV2AAGOFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E7XMICfaoJ1MVoUOhRdUcUDzBhr76wkrRK6dgRH3uWfb6zHaZM9/flUzmSvoUOPk0 c2ozT8wl6dGVfPpbfpTQqohi+/NdXCZhe/kyiPo7uZN/M8O34FgZ3b96YKL7GY/tO9 6Vet8VSpeA+x/0FKRLxEmOTGBCDNJGGyKj62+2SfIscXmcVFP3hqTUThOPyR83SHg1 tI7/cunPxNR1AWWknYE2G1TZxdVJ7bDI+4FWFBUJZapDVAYtfwX14omWZ3YvdFhhSr TlNh4q6W0lbzg8bjDW0Fp978vbi6fmfCRWiq/QaUxYkdDWVx/hA+Ww5J/l//xG5X++ FfcGc7CmCSysQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 101B540B92; Mon, 10 Jan 2022 16:04:08 -0300 (-03) Date: Mon, 10 Jan 2022 16:04:08 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 17/48] perf cpumap: Remove cpu_map__cpu, use libperf function. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-18-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Mon, Jan 10, 2022 at 04:02:49PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 04, 2022 at 10:13:20PM -0800, Ian Rogers escreveu: > > Switch the remaining few users of cpu_map__cpu to perf_cpu_map__cpu and > > remove the function. > > > > Reviewed-by: James Clark > > Signed-off-by: Ian Rogers > > util/bpf_ftrace.c: In function ‘perf_ftrace__latency_prepare_bpf’: > util/bpf_ftrace.c:66:31: error: implicit declaration of function ‘cpu_map__cpu’; did you mean ‘cpu_map__has’? [-Werror=implicit-function-declaration] > 66 | cpu = cpu_map__cpu(ftrace->evlist->core.cpus, i); > | ^~~~~~~~~~~~ > | cpu_map__has > cc1: all warnings being treated as errors > make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/util/bpf_ftrace.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > LD /tmp/build/perf/ui/browsers/perf-in.o > LD /tmp/build/perf/ui/perf-in.o > LD /tmp/build/perf/util/scripting-engines/perf-in.o > make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:139: util] Error 2 > make[2]: *** [Makefile.perf:665: /tmp/build/perf/perf-in.o] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [Makefile.perf:240: sub-make] Error 2 > make: *** [Makefile:113: install-bin] Error 2 > make: Leaving directory '/var/home/acme/git/perf/tools/perf' > > Performance counter stats for 'make -k BUILD_BPF_SKEL=1 CORESIGHT=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin': > > 163,635,422,196 cycles:u > 213,602,262,800 instructions:u # 1.31 insn per cycle > > 3.804738555 seconds time elapsed > > 40.622581000 seconds user > 6.589980000 seconds sys > > > ⬢[acme@toolbox perf]$ git log --oneline -1 > dfe103e757aeff79 (HEAD) perf cpumap: Remove cpu_map__cpu, use libperf function. > > This is the first breakage, trying to fix now. ⬢[acme@toolbox perf]$ find tools/perf/ -name "*.c" | xargs grep -w cpu_map__cpu tools/perf/util/bpf_ftrace.c: cpu = cpu_map__cpu(ftrace->evlist->core.cpus, i); ⬢[acme@toolbox perf]$ Only this one remaining, so just moving to perf_cpu_map__cpu() like done elsewhere in this patch. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76638C433EF for ; Mon, 10 Jan 2022 19:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h3qPvTwE2difwu7i/9mnvliAkFP91sDQBBRYADKfaUQ=; b=2zTUPrH2eQoVwb 4+79zB3BYkOhCpYjyiSYZejmmUaRkxXKLRtjTLT65kYE93A2Gs1fCKDLlKT2PMIWd9l2LhIk09KHA LTTRsR4BNoSxbgLQ/YqWfIhO+yyR2pvu/Nn8+spgCBUxXG2dI3R3qJopRSF0FuLVsLw9Sqe5ufCVa 3X0rKugVp/EHCv4vYF5yYDpo0kdNBIB7UhWNQ34Eulfi9oAmVEwsYwgW0LbgUDI5Vw7IrVE110Vmh 9KsdA9nce0jynDNuciN7uAoITIKbfHSFBLAqmKLw41u0PlLse3mlgZsj+i3yNnDNGAUmF9Abt0di1 owGLyWxdk0ox0JSAHNOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zxl-00CvaF-9y; Mon, 10 Jan 2022 19:04:13 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zxj-00CvZD-P1 for linux-arm-kernel@bombadil.infradead.org; Mon, 10 Jan 2022 19:04:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=7c4LFU8oZUFjO/7FO6MRnvp5/Vihjh+LKXbu6F7SUxM=; b=FM1ZaULESjeSAWgTnTDm0/RWW8 Qtcp4CYy/jtZrhiICDpWtdEUk+tt/M7GrayVLLPkFYlE4pT1PZJKD0KUsr/UtoQJFoLJGrbvmanm/ LN2bNKL+Wmw3Io+lpcgM5hhRANkLtbocZQJn70pzNpDY7E36n/bg3eJr/WPGzzVU/+R3NTX+GG1mu jkVTPQD4r/75PSviqJ1v9dbEfKEmIhtECzxKOJJUnU8sc3A55widZVjxw11vc+XsuV8kRXrCkm6UH jdwbMVO4gG6cFVOE6WpLbfscAGle1BJe9S9E70nnF72KWCzF9N/L1L3mJ2WpIDYuoi3zW/k7PCF3d aFnFZBaA==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zxh-002eyx-U1; Mon, 10 Jan 2022 19:04:10 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 101B540B92; Mon, 10 Jan 2022 16:04:08 -0300 (-03) Date: Mon, 10 Jan 2022 16:04:08 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 17/48] perf cpumap: Remove cpu_map__cpu, use libperf function. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-18-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gTW9uLCBKYW4gMTAsIDIwMjIgYXQgMDQ6MDI6NDlQTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIFR1ZSwgSmFuIDA0LCAyMDIyIGF0IDEwOjEzOjIwUE0g LTA4MDAsIElhbiBSb2dlcnMgZXNjcmV2ZXU6Cj4gPiBTd2l0Y2ggdGhlIHJlbWFpbmluZyBmZXcg dXNlcnMgb2YgY3B1X21hcF9fY3B1IHRvIHBlcmZfY3B1X21hcF9fY3B1IGFuZAo+ID4gcmVtb3Zl IHRoZSBmdW5jdGlvbi4KPiA+IAo+ID4gUmV2aWV3ZWQtYnk6IEphbWVzIENsYXJrIDxqYW1lcy5j bGFya0Bhcm0uY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29n bGUuY29tPgo+IAo+IHV0aWwvYnBmX2Z0cmFjZS5jOiBJbiBmdW5jdGlvbiDigJhwZXJmX2Z0cmFj ZV9fbGF0ZW5jeV9wcmVwYXJlX2JwZuKAmToKPiB1dGlsL2JwZl9mdHJhY2UuYzo2NjozMTogZXJy b3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmGNwdV9tYXBfX2NwdeKAmTsg ZGlkIHlvdSBtZWFuIOKAmGNwdV9tYXBfX2hhc+KAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rp b24tZGVjbGFyYXRpb25dCj4gICAgNjYgfCAgICAgICAgICAgICAgICAgICAgICAgICBjcHUgPSBj cHVfbWFwX19jcHUoZnRyYWNlLT5ldmxpc3QtPmNvcmUuY3B1cywgaSk7Cj4gICAgICAgfCAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn4KPiAgICAgICB8ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNwdV9tYXBfX2hhcwo+IGNjMTogYWxsIHdhcm5pbmdzIGJl aW5nIHRyZWF0ZWQgYXMgZXJyb3JzCj4gbWFrZVs0XTogKioqIFsvdmFyL2hvbWUvYWNtZS9naXQv cGVyZi90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDo5NjogL3RtcC9idWlsZC9wZXJmL3V0aWwv YnBmX2Z0cmFjZS5vXSBFcnJvciAxCj4gbWFrZVs0XTogKioqIFdhaXRpbmcgZm9yIHVuZmluaXNo ZWQgam9icy4uLi4KPiAgIExEICAgICAgL3RtcC9idWlsZC9wZXJmL3VpL2Jyb3dzZXJzL3BlcmYt aW4ubwo+ICAgTEQgICAgICAvdG1wL2J1aWxkL3BlcmYvdWkvcGVyZi1pbi5vCj4gICBMRCAgICAg IC90bXAvYnVpbGQvcGVyZi91dGlsL3NjcmlwdGluZy1lbmdpbmVzL3BlcmYtaW4ubwo+IG1ha2Vb M106ICoqKiBbL3Zhci9ob21lL2FjbWUvZ2l0L3BlcmYvdG9vbHMvYnVpbGQvTWFrZWZpbGUuYnVp bGQ6MTM5OiB1dGlsXSBFcnJvciAyCj4gbWFrZVsyXTogKioqIFtNYWtlZmlsZS5wZXJmOjY2NTog L3RtcC9idWlsZC9wZXJmL3BlcmYtaW4ub10gRXJyb3IgMgo+IG1ha2VbMl06ICoqKiBXYWl0aW5n IGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCj4gbWFrZVsxXTogKioqIFtNYWtlZmlsZS5wZXJmOjI0 MDogc3ViLW1ha2VdIEVycm9yIDIKPiBtYWtlOiAqKiogW01ha2VmaWxlOjExMzogaW5zdGFsbC1i aW5dIEVycm9yIDIKPiBtYWtlOiBMZWF2aW5nIGRpcmVjdG9yeSAnL3Zhci9ob21lL2FjbWUvZ2l0 L3BlcmYvdG9vbHMvcGVyZicKPiAKPiAgUGVyZm9ybWFuY2UgY291bnRlciBzdGF0cyBmb3IgJ21h a2UgLWsgQlVJTERfQlBGX1NLRUw9MSBDT1JFU0lHSFQ9MSBQWVRIT049cHl0aG9uMyBPPS90bXAv YnVpbGQvcGVyZiAtQyB0b29scy9wZXJmIGluc3RhbGwtYmluJzoKPiAKPiAgICAxNjMsNjM1LDQy MiwxOTYgICAgICBjeWNsZXM6dSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKPiAgICAyMTMsNjAyLDI2Miw4MDAgICAgICBpbnN0cnVjdGlvbnM6dSAg ICAgICAgICAgICMgICAgMS4zMSAgaW5zbiBwZXIgY3ljbGUgICAgICAgICAKPiAKPiAgICAgICAg My44MDQ3Mzg1NTUgc2Vjb25kcyB0aW1lIGVsYXBzZWQKPiAKPiAgICAgICA0MC42MjI1ODEwMDAg c2Vjb25kcyB1c2VyCj4gICAgICAgIDYuNTg5OTgwMDAwIHNlY29uZHMgc3lzCj4gCj4gCj4g4qyi W2FjbWVAdG9vbGJveCBwZXJmXSQgZ2l0IGxvZyAtLW9uZWxpbmUgLTEKPiBkZmUxMDNlNzU3YWVm Zjc5IChIRUFEKSBwZXJmIGNwdW1hcDogUmVtb3ZlIGNwdV9tYXBfX2NwdSwgdXNlIGxpYnBlcmYg ZnVuY3Rpb24uCj4gCj4gVGhpcyBpcyB0aGUgZmlyc3QgYnJlYWthZ2UsIHRyeWluZyB0byBmaXgg bm93LgoK4qyiW2FjbWVAdG9vbGJveCBwZXJmXSQgZmluZCB0b29scy9wZXJmLyAtbmFtZSAiKi5j IiB8IHhhcmdzIGdyZXAgLXcgY3B1X21hcF9fY3B1CnRvb2xzL3BlcmYvdXRpbC9icGZfZnRyYWNl LmM6CQkJY3B1ID0gY3B1X21hcF9fY3B1KGZ0cmFjZS0+ZXZsaXN0LT5jb3JlLmNwdXMsIGkpOwri rKJbYWNtZUB0b29sYm94IHBlcmZdJAoKT25seSB0aGlzIG9uZSByZW1haW5pbmcsIHNvIGp1c3Qg bW92aW5nIHRvIHBlcmZfY3B1X21hcF9fY3B1KCkgbGlrZSBkb25lCmVsc2V3aGVyZSBpbiB0aGlz IHBhdGNoLgoKLSBBcm5hbGRvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==