All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing
Date: Tue, 25 Jan 2022 11:56:33 +0100	[thread overview]
Message-ID: <Ye/XYWGiAEdzuhLT@pevik> (raw)
In-Reply-To: <20220125025008.xlnm3uwafi4dvaun@xzhoux.usersys.redhat.com>

Hi Murphy,

> This will cause file not found errors.
...

> +++ b/include/mk/env_pre.mk
> @@ -88,9 +88,6 @@ endif
>  # autotools, *clean, and help don't require config.mk, features.mk, etc...
>  ifeq ($(filter autotools %clean .gitignore gitignore.% help,$(MAKECMDGOALS)),)

> -include $(abs_top_builddir)/include/mk/config.mk
> -include $(abs_top_builddir)/include/mk/features.mk
> -
This is most certainly wrong, these includes are needed.

I guess you run make without running:
make autotools && ./configure

https://github.com/linux-test-project/ltp#quick-guide-to-running-the-tests

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-01-25 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  2:50 [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing Murphy Zhou
2022-01-25 10:56 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye/XYWGiAEdzuhLT@pevik \
    --to=pvorel@suse.cz \
    --cc=jencce.kernel@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.