From: Christoph Hellwig <hch@infradead.org>
To: ira.weiny@intel.com
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] highmem: Document kunmap_local()
Date: Mon, 24 Jan 2022 04:28:53 -0800 [thread overview]
Message-ID: <Ye6bhQG6b6caYurD@infradead.org> (raw)
In-Reply-To: <20220124013045.806718-1-ira.weiny@intel.com>
On Sun, Jan 23, 2022 at 05:30:44PM -0800, ira.weiny@intel.com wrote:
> + * __addr is often an address returned from kmap_local_page(). However,
> + * this address can be any address within the mapped page. It does not need to
> + * be the exact address returned from kmap_local_page()
> + */
I'd word this a little different:
> + * __addr is often an address returned from kmap_local_page(). However,
> + * this address can be any address within the mapped page. It does not need to
> + * be the exact address returned from kmap_local_page()
> + */
* @__addr can be any address within the mapped page. Commonly it is the
* address return from kmap_local_page(), but it can also include offsets.
But documenting this definitively is a good idea!
next prev parent reply other threads:[~2022-01-24 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 1:30 [PATCH] highmem: Document kunmap_local() ira.weiny
2022-01-24 12:28 ` Christoph Hellwig [this message]
2022-01-24 18:21 ` [PATCH V2] " ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye6bhQG6b6caYurD@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.