From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16F9C433F5 for ; Mon, 24 Jan 2022 17:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244532AbiAXR0g (ORCPT ); Mon, 24 Jan 2022 12:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244304AbiAXR0g (ORCPT ); Mon, 24 Jan 2022 12:26:36 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4314CC061401; Mon, 24 Jan 2022 09:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YalnhBnkU6wZ0N4VJgHQSOBIP0tBgxl1/ZtUR64V9oA=; b=fOFHPIrYVgBUmRQ1wEyMQVl1Oj J17+8bX+a2m4lyf00SWK0SbxEgp4DFByKGkICOOLjjK5UDLiqO0o5EVQO60/0NmnRCNDgSCJTRL2+ XlcIantWF1sVzawTxf32wDMyo3ml8qMUfx464lpZ/WeCAVULy2M6DtMrb333/zQzYrzEJeJlrBH6J 2t5dPHHaevgk7AsspzzLGYVLLoqF4ORiPBfhHCZ/hQFbo110/Rxr3gTd9zg/l621X8XcZ8++f1KH+ TL6vTH/S0VvymwuILV4s/TRFyIzUyYPzKtW4H7+VwBdgNnM87UoKIhFI4sC9TtHoSQ23YH4dDregg qVLdckRA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56842) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nC36d-0000eK-0B; Mon, 24 Jan 2022 17:26:15 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nC36X-0001nW-Kl; Mon, 24 Jan 2022 17:26:09 +0000 Date: Mon, 24 Jan 2022 17:26:09 +0000 From: "Russell King (Oracle)" To: Florian Fainelli Cc: Andrew Lunn , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , DENG Qingfang , Luiz Angelo Daros de Luca , Matthias Brugger , John Crispin , Siddhant Gupta , Ilya Lipnitskiy , Sergio Paracuellos , Felix Fietkau , Sean Wang , Mark Lee , Jakub Kicinski , David Miller , =?iso-8859-1?Q?Ren=E9?= van Dorst , "moderated list:ARM/Mediatek SoC support" , netdev , linux-mips@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , openwrt-devel@lists.openwrt.org, erkin.bozoglu@xeront.com Subject: Re: MT7621 SoC Traffic Won't Flow on RGMII2 Bus/2nd GMAC Message-ID: References: <83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@arinc9.com> <02ecce91-7aad-4392-c9d7-f45ca1b31e0b@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Jan 24, 2022 at 09:13:38AM -0800, Florian Fainelli wrote: > On 1/23/2022 7:26 AM, Andrew Lunn wrote: > > On Sun, Jan 23, 2022 at 11:33:04AM +0300, Arınç ÜNAL wrote: > > > Hey Deng, > > > > > > On 23/01/2022 09:51, DENG Qingfang wrote: > > > > Hi, > > > > > > > > Do you set the ethernet pinmux correctly? > > > > > > > > ðernet { > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&rgmii1_pins &rgmii2_pins &mdio_pins>; > > > > }; > > > > > > This fixed it! We did have &rgmii2_pins on the gmac1 node (it was originally > > > on external_phy) so we never thought to investigate the pinctrl > > > configuration further! Turns out &rgmii2_pins needs to be defined on the > > > ethernet node instead. > > > > PHYs are generally external, so pinmux on them makes no sense. PHYs in > > DT are not devices in the usual sense, so i don't think the driver > > core will handle pinmux for them, even if you did list them. > > Not sure I understand your comment here, this is configuring the pinmux on > the SoC side in order for the second RGMII interface's data path to work. The pinmux configuration was listed under the external PHY node, which is qutie unusual. In the case of phylib and external ethernet PHYs, this can be a problem. The pinmux configuration is normally handled at device probe time by the device model, but remember phylib bypasses that when it attaches the generic PHY driver - meaning you don't get the pinmux configured. What this means is that pinmux configuration in ethernet PHY nodes is unreliable. It will only happen if we have a specific driver for the PHY and the driver model binds that driver. Of course, if we killed the generic driver, that would get around this issue by requiring every PHY to have its own specific driver, but there would be many complaints because likely lots would stop working. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 077CAC433F5 for ; Mon, 24 Jan 2022 17:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aEADoF4GaqV1AZMuNk8MgABmc47vHUmJAj0wntM72zg=; b=MZu3KGE8wV8Kyp YXAvkv/Z+qlRfsW9Puj6WHw+rO5v5O+BQfd61vW/Ibl+aCTwJlMiIgTRmAj1e1njOLb9uqXC0EikJ fGayc3b4PSyAbUr5nYU8wtVKIPx8e+p1cx1IMQH2Ho4mgeCZcIxnBbqHIjGn7jyazgtH3+kVKZlH6 nqX8AxJU/MkvIdx9FTLIMC/Sief9LFSbLp8f4S/tQ5L9iTNVjk/SUUifNPSLuBocam9LoTGCnkk/Z F8ihHRrIDY4QRUUcXvyDkFLpZo9D1Egb59il+LcV7h2wl36C4jCISOu9g6IGSjsLtQgYdpvuccP4J +qqDWnOpxOuddd6LnStw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC36x-004D42-IP; Mon, 24 Jan 2022 17:26:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nC36u-004D3M-PY for linux-mediatek@lists.infradead.org; Mon, 24 Jan 2022 17:26:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YalnhBnkU6wZ0N4VJgHQSOBIP0tBgxl1/ZtUR64V9oA=; b=fOFHPIrYVgBUmRQ1wEyMQVl1Oj J17+8bX+a2m4lyf00SWK0SbxEgp4DFByKGkICOOLjjK5UDLiqO0o5EVQO60/0NmnRCNDgSCJTRL2+ XlcIantWF1sVzawTxf32wDMyo3ml8qMUfx464lpZ/WeCAVULy2M6DtMrb333/zQzYrzEJeJlrBH6J 2t5dPHHaevgk7AsspzzLGYVLLoqF4ORiPBfhHCZ/hQFbo110/Rxr3gTd9zg/l621X8XcZ8++f1KH+ TL6vTH/S0VvymwuILV4s/TRFyIzUyYPzKtW4H7+VwBdgNnM87UoKIhFI4sC9TtHoSQ23YH4dDregg qVLdckRA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56842) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nC36d-0000eK-0B; Mon, 24 Jan 2022 17:26:15 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nC36X-0001nW-Kl; Mon, 24 Jan 2022 17:26:09 +0000 Date: Mon, 24 Jan 2022 17:26:09 +0000 From: "Russell King (Oracle)" To: Florian Fainelli Cc: Andrew Lunn , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , DENG Qingfang , Luiz Angelo Daros de Luca , Matthias Brugger , John Crispin , Siddhant Gupta , Ilya Lipnitskiy , Sergio Paracuellos , Felix Fietkau , Sean Wang , Mark Lee , Jakub Kicinski , David Miller , =?iso-8859-1?Q?Ren=E9?= van Dorst , "moderated list:ARM/Mediatek SoC support" , netdev , linux-mips@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , openwrt-devel@lists.openwrt.org, erkin.bozoglu@xeront.com Subject: Re: MT7621 SoC Traffic Won't Flow on RGMII2 Bus/2nd GMAC Message-ID: References: <83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@arinc9.com> <02ecce91-7aad-4392-c9d7-f45ca1b31e0b@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_092632_854273_327D0737 X-CRM114-Status: GOOD ( 20.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMjQsIDIwMjIgYXQgMDk6MTM6MzhBTSAtMDgwMCwgRmxvcmlhbiBGYWluZWxs aSB3cm90ZToKPiBPbiAxLzIzLzIwMjIgNzoyNiBBTSwgQW5kcmV3IEx1bm4gd3JvdGU6Cj4gPiBP biBTdW4sIEphbiAyMywgMjAyMiBhdCAxMTozMzowNEFNICswMzAwLCBBcsSxbsOnIMOcTkFMIHdy b3RlOgo+ID4gPiBIZXkgRGVuZywKPiA+ID4gCj4gPiA+IE9uIDIzLzAxLzIwMjIgMDk6NTEsIERF TkcgUWluZ2Zhbmcgd3JvdGU6Cj4gPiA+ID4gSGksCj4gPiA+ID4gCj4gPiA+ID4gRG8geW91IHNl dCB0aGUgZXRoZXJuZXQgcGlubXV4IGNvcnJlY3RseT8KPiA+ID4gPiAKPiA+ID4gPiAmZXRoZXJu ZXQgewo+ID4gPiA+ICAgICAgIHBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gPiA+ID4gICAg ICAgcGluY3RybC0wID0gPCZyZ21paTFfcGlucyAmcmdtaWkyX3BpbnMgJm1kaW9fcGlucz47Cj4g PiA+ID4gfTsKPiA+ID4gCj4gPiA+IFRoaXMgZml4ZWQgaXQhIFdlIGRpZCBoYXZlICZyZ21paTJf cGlucyBvbiB0aGUgZ21hYzEgbm9kZSAoaXQgd2FzIG9yaWdpbmFsbHkKPiA+ID4gb24gZXh0ZXJu YWxfcGh5KSBzbyB3ZSBuZXZlciB0aG91Z2h0IHRvIGludmVzdGlnYXRlIHRoZSBwaW5jdHJsCj4g PiA+IGNvbmZpZ3VyYXRpb24gZnVydGhlciEgVHVybnMgb3V0ICZyZ21paTJfcGlucyBuZWVkcyB0 byBiZSBkZWZpbmVkIG9uIHRoZQo+ID4gPiBldGhlcm5ldCBub2RlIGluc3RlYWQuCj4gPiAKPiA+ IFBIWXMgYXJlIGdlbmVyYWxseSBleHRlcm5hbCwgc28gcGlubXV4IG9uIHRoZW0gbWFrZXMgbm8g c2Vuc2UuIFBIWXMgaW4KPiA+IERUIGFyZSBub3QgZGV2aWNlcyBpbiB0aGUgdXN1YWwgc2Vuc2Us IHNvIGkgZG9uJ3QgdGhpbmsgdGhlIGRyaXZlcgo+ID4gY29yZSB3aWxsIGhhbmRsZSBwaW5tdXgg Zm9yIHRoZW0sIGV2ZW4gaWYgeW91IGRpZCBsaXN0IHRoZW0uCj4gCj4gTm90IHN1cmUgSSB1bmRl cnN0YW5kIHlvdXIgY29tbWVudCBoZXJlLCB0aGlzIGlzIGNvbmZpZ3VyaW5nIHRoZSBwaW5tdXgg b24KPiB0aGUgU29DIHNpZGUgaW4gb3JkZXIgZm9yIHRoZSBzZWNvbmQgUkdNSUkgaW50ZXJmYWNl J3MgZGF0YSBwYXRoIHRvIHdvcmsuCgpUaGUgcGlubXV4IGNvbmZpZ3VyYXRpb24gd2FzIGxpc3Rl ZCB1bmRlciB0aGUgZXh0ZXJuYWwgUEhZIG5vZGUsIHdoaWNoCmlzIHF1dGllIHVudXN1YWwuIElu IHRoZSBjYXNlIG9mIHBoeWxpYiBhbmQgZXh0ZXJuYWwgZXRoZXJuZXQgUEhZcywKdGhpcyBjYW4g YmUgYSBwcm9ibGVtLgoKVGhlIHBpbm11eCBjb25maWd1cmF0aW9uIGlzIG5vcm1hbGx5IGhhbmRs ZWQgYXQgZGV2aWNlIHByb2JlIHRpbWUgYnkKdGhlIGRldmljZSBtb2RlbCwgYnV0IHJlbWVtYmVy IHBoeWxpYiBieXBhc3NlcyB0aGF0IHdoZW4gaXQgYXR0YWNoZXMKdGhlIGdlbmVyaWMgUEhZIGRy aXZlciAtIG1lYW5pbmcgeW91IGRvbid0IGdldCB0aGUgcGlubXV4IGNvbmZpZ3VyZWQuCgpXaGF0 IHRoaXMgbWVhbnMgaXMgdGhhdCBwaW5tdXggY29uZmlndXJhdGlvbiBpbiBldGhlcm5ldCBQSFkg bm9kZXMgaXMKdW5yZWxpYWJsZS4gSXQgd2lsbCBvbmx5IGhhcHBlbiBpZiB3ZSBoYXZlIGEgc3Bl Y2lmaWMgZHJpdmVyIGZvciB0aGUKUEhZIGFuZCB0aGUgZHJpdmVyIG1vZGVsIGJpbmRzIHRoYXQg ZHJpdmVyLgoKT2YgY291cnNlLCBpZiB3ZSBraWxsZWQgdGhlIGdlbmVyaWMgZHJpdmVyLCB0aGF0 IHdvdWxkIGdldCBhcm91bmQgdGhpcwppc3N1ZSBieSByZXF1aXJpbmcgZXZlcnkgUEhZIHRvIGhh dmUgaXRzIG93biBzcGVjaWZpYyBkcml2ZXIsIGJ1dCB0aGVyZQp3b3VsZCBiZSBtYW55IGNvbXBs YWludHMgYmVjYXVzZSBsaWtlbHkgbG90cyB3b3VsZCBzdG9wIHdvcmtpbmcuCgotLSAKUk1LJ3Mg UGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNo ZXMvCkZUVFAgaXMgaGVyZSEgNDBNYnBzIGRvd24gMTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2 aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW1lZGlhdGVrCg==