From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C68EC433EF for ; Tue, 25 Jan 2022 00:25:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C31532827; Tue, 25 Jan 2022 01:25:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C31532827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1643070352; bh=/llhb3MadjMXQlQrGtqBgDz99ZgxYlm1hYqabdKqxrw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uxldiuZ0H8ViTvEhU7kbMdtIT9U84mc2vMheseD0FTUgrgVFnLtPj/C/pDwplFn84 a8bKhy5S6TVUU33IQ+d1ND4cyybGdVkwnjY95wG/D7fraTqCeAwk9Gw9ug/3mdwmWf 39WGGMVBp9gqW3fIv8Nl+A5Yl0M6SG0t9WgA16Es= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 644C9F80163; Tue, 25 Jan 2022 01:25:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B37C4F8027C; Tue, 25 Jan 2022 01:24:59 +0100 (CET) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D9650F800E9 for ; Tue, 25 Jan 2022 01:24:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D9650F800E9 Received: by mail-ot1-f44.google.com with SMTP id g15-20020a9d6b0f000000b005a062b0dc12so3182710otp.4 for ; Mon, 24 Jan 2022 16:24:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hKgu9rmUk95J97wO8FZCJYIlIG/PvU+dGhgzBVkVwN8=; b=4LTovXP2D1GwClMpqzWscOoWr+b4uaFUuaha7jtIX7E2dbQaGitzO0m1zjyFbXODiM 3WRLUleG2H5/Kz9rS6zrQhb2/KvKXIMS44R18/X7AeCCA6xHQbzuMUfUb5c+W3pRGJm8 k7/nVKEQYJaEtyD2fjl4wGU6fIVjc2zNZgI/it5vDQ3qXgdsDjpXPlB8xkwwu0BM1a5F 5M1louYYTyP+2egLsVYfBfJetkg1AtFssa0fh1ogIcH8Q8/2TF1CZOzl8o94ArK6Eb/5 nLLsA4aDUwHbo9zFg61D8pNaaQA3jdy0wVsY8vXf2UxRIqXc5w9JUHTk+Ub81uvP2ql1 oupg== X-Gm-Message-State: AOAM531v0kcjCqKeQbGb+R/NwO+ahuuwq5XDCYO3D2YYbvp9EX3bP+2D PAHYg+tl8iGLebzquoBxBg== X-Google-Smtp-Source: ABdhPJwBQlZsDWkm3dE9/hvTrL4jN/68Lxk+HhTDBRoQqFgYwJwB6VNNcUYx1ZcvnXNEAfY0RZ18Zg== X-Received: by 2002:a9d:5c86:: with SMTP id a6mr7103969oti.163.1643070291812; Mon, 24 Jan 2022 16:24:51 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id a19sm2751280otf.27.2022.01.24.16.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 16:24:51 -0800 (PST) Received: (nullmailer pid 809305 invoked by uid 1000); Tue, 25 Jan 2022 00:24:50 -0000 Date: Mon, 24 Jan 2022 18:24:50 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [RFC 5/6] ASoC: dt-bindings: samsung,snow: convert to dtschema Message-ID: References: <20220124170336.164320-1-krzysztof.kozlowski@canonical.com> <20220124170336.164320-5-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124170336.164320-5-krzysztof.kozlowski@canonical.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Jonathan Bakker , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Jan 24, 2022 at 06:03:35PM +0100, Krzysztof Kozlowski wrote: > Convert the audio complex on Google Snow boards with Samsung Exynos SoC > to DT schema format. > > Signed-off-by: Krzysztof Kozlowski > > --- > > TODO: The DTS do not pass cleanly. cpu/sound-dai should be fixed. > --- > .../bindings/sound/samsung,snow.yaml | 78 +++++++++++++++++++ > .../devicetree/bindings/sound/snow.txt | 31 -------- > 2 files changed, 78 insertions(+), 31 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/samsung,snow.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/snow.txt > > diff --git a/Documentation/devicetree/bindings/sound/samsung,snow.yaml b/Documentation/devicetree/bindings/sound/samsung,snow.yaml > new file mode 100644 > index 000000000000..df969b384839 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/samsung,snow.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/samsung,snow.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google Snow audio complex with MAX9809x codec > + > +maintainers: > + - Krzysztof Kozlowski > + - Sylwester Nawrocki > + > +properties: > + compatible: > + enum: > + - google,snow-audio-max98090 > + - google,snow-audio-max98091 > + - google,snow-audio-max98095 > + > + codec: > + type: object > + properties: > + sound-dai: > + description: List of phandles to the CODEC and HDMI IP nodes. > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - description: Phandle to the MAX98090, MAX98091 or MAX98095 CODEC. > + - description: Phandle to the HDMI IP block node. Thinking about this and the issue you raised some more, we should make sure there's a common definition for sound-dai. And then here, it should just be the number of entries ('maxItems: 1'). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDC9C433EF for ; Tue, 25 Jan 2022 00:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359151AbiAYAcu (ORCPT ); Mon, 24 Jan 2022 19:32:50 -0500 Received: from mail-ot1-f46.google.com ([209.85.210.46]:34791 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3409082AbiAYAYz (ORCPT ); Mon, 24 Jan 2022 19:24:55 -0500 Received: by mail-ot1-f46.google.com with SMTP id m8-20020a9d4c88000000b00592bae7944bso24618688otf.1; Mon, 24 Jan 2022 16:24:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hKgu9rmUk95J97wO8FZCJYIlIG/PvU+dGhgzBVkVwN8=; b=MZE5ndUCCOr/b4NI4VHdNhqVZNbcnfNVW+pUDQlubdmhX9/QaRvzE1/y6iiu5Kr/a0 NbYQPtaQPHFxKq2RPmErQsxnl/ur1plF+nnuPyA7HnGTOm4Vurflsqrvtbt2NO0qQs26 d0pj8unzscOwT1TKYeqbKyBD8BI7I7HC5ZOrExMbGN8ORAeTa4CPVl7QG1ivPvz2a7yh CK0HLgtFgFZHhr8+3ysq6JiHwv8AnkbjR8Frte41Oh5ZSSYhMsSJlyEwkhgPcrkkGclS +2oMOy6k4xTyOWkdIaTYGlPP+UFUudAT/mJoGuRxLvwsmibBlbH5r6AnIZnkb1Nh3WLv EUCQ== X-Gm-Message-State: AOAM531oUs1mqAOcvcdIDosnWbAY5WmN6j6q2ZEx5AE3dHR7brRSihDT wQcoL//ydUwFDYNYDfxFbQ== X-Google-Smtp-Source: ABdhPJwBQlZsDWkm3dE9/hvTrL4jN/68Lxk+HhTDBRoQqFgYwJwB6VNNcUYx1ZcvnXNEAfY0RZ18Zg== X-Received: by 2002:a9d:5c86:: with SMTP id a6mr7103969oti.163.1643070291812; Mon, 24 Jan 2022 16:24:51 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id a19sm2751280otf.27.2022.01.24.16.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 16:24:51 -0800 (PST) Received: (nullmailer pid 809305 invoked by uid 1000); Tue, 25 Jan 2022 00:24:50 -0000 Date: Mon, 24 Jan 2022 18:24:50 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Sylwester Nawrocki , Jonathan Bakker , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/6] ASoC: dt-bindings: samsung,snow: convert to dtschema Message-ID: References: <20220124170336.164320-1-krzysztof.kozlowski@canonical.com> <20220124170336.164320-5-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124170336.164320-5-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 24, 2022 at 06:03:35PM +0100, Krzysztof Kozlowski wrote: > Convert the audio complex on Google Snow boards with Samsung Exynos SoC > to DT schema format. > > Signed-off-by: Krzysztof Kozlowski > > --- > > TODO: The DTS do not pass cleanly. cpu/sound-dai should be fixed. > --- > .../bindings/sound/samsung,snow.yaml | 78 +++++++++++++++++++ > .../devicetree/bindings/sound/snow.txt | 31 -------- > 2 files changed, 78 insertions(+), 31 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/samsung,snow.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/snow.txt > > diff --git a/Documentation/devicetree/bindings/sound/samsung,snow.yaml b/Documentation/devicetree/bindings/sound/samsung,snow.yaml > new file mode 100644 > index 000000000000..df969b384839 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/samsung,snow.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/samsung,snow.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google Snow audio complex with MAX9809x codec > + > +maintainers: > + - Krzysztof Kozlowski > + - Sylwester Nawrocki > + > +properties: > + compatible: > + enum: > + - google,snow-audio-max98090 > + - google,snow-audio-max98091 > + - google,snow-audio-max98095 > + > + codec: > + type: object > + properties: > + sound-dai: > + description: List of phandles to the CODEC and HDMI IP nodes. > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - description: Phandle to the MAX98090, MAX98091 or MAX98095 CODEC. > + - description: Phandle to the HDMI IP block node. Thinking about this and the issue you raised some more, we should make sure there's a common definition for sound-dai. And then here, it should just be the number of entries ('maxItems: 1'). Rob