All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Stanislav Jakubek <stano.jakubek@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: trivial-devices: fix comment indentation
Date: Fri, 14 Jan 2022 09:21:52 -0600	[thread overview]
Message-ID: <YeGVEMl5aKgIHZIv@robh.at.kernel.org> (raw)
In-Reply-To: <ea7e6b645fb1c2612f14ca62471180a38d51e9f9.1642080090.git.stano.jakubek@gmail.com>

On Thu, Jan 13, 2022 at 02:39:40PM +0100, Stanislav Jakubek wrote:
> Indent comments the same as the content they describe.
> Fixes yamllint warnings like:
> 32:13     warning  comment not indented like content  (comments-indentation)

But that's not a warning we enable or is this something new in newer 
yamllint?

In any case, a change like this can only be done at the end of the merge 
window just before rc1. Otherwise, it is merge conflict hell. I would do 
that, but I really prefer it the way it is. The reason is it makes the 
'-' stand out more and those are easy to miss in yaml. For example, 
these look the same but are a bit different:

- items:
  - const: foo

- items:
    const: foo

> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
>  .../devicetree/bindings/trivial-devices.yaml  | 314 +++++++++---------
>  1 file changed, 157 insertions(+), 157 deletions(-)

  reply	other threads:[~2022-01-14 15:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 13:38 [PATCH 0/3] dt-bindings: trivial-devices: misc (whitespace) fixes Stanislav Jakubek
2022-01-13 13:39 ` [PATCH 1/3] dt-bindings: trivial-devices: fix swapped comments Stanislav Jakubek
2022-01-14 15:11   ` Rob Herring
2022-01-13 13:39 ` [PATCH 2/3] dt-bindings: trivial-devices: fix double spaces in comments Stanislav Jakubek
2022-01-14 15:11   ` Rob Herring
2022-01-13 13:39 ` [PATCH 3/3] dt-bindings: trivial-devices: fix comment indentation Stanislav Jakubek
2022-01-14 15:21   ` Rob Herring [this message]
2022-01-14 16:50     ` Stanislav Jakubek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeGVEMl5aKgIHZIv@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stano.jakubek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.