From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
Date: Fri, 14 Jan 2022 17:29:52 +0200 [thread overview]
Message-ID: <YeGW8IgkxFN/r7WR@abelvesa> (raw)
In-Reply-To: <CAL_Jsq+XNNVbUiJeqPvDrz_oZoV1PTxRcE9O5ovEAHQZ37cn9g@mail.gmail.com>
On 21-12-21 09:43:39, Rob Herring wrote:
> On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@nxp.com> wrote:
> >
> > Add i.MX8DXL lpuart compatible to the bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >
> > This is a resend of the following, but as a separate patch.
> >
> > https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/
> >
> > Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 6e04e3848261..1f482e166467 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -30,6 +30,10 @@ properties:
> > - items:
> > - const: fsl,imx8qm-lpuart
> > - const: fsl,imx8qxp-lpuart
> > + - items:
> > + - const: fsl,imx8dxl-lpuart
> > + - const: fsl,imx8qxp-lpuart
> > + - const: fsl,imx7ulp-lpuart
>
> It doesn't really make sense that imx8qm and imx8dxl are backwards
> compatible with imx8qxp, but only imx8qm is backwards compatible to
> imx7ulp. Ir only makes sense if some feature/quirk specific to
> fsl,imx7ulp-lpuart is gone in imx8qm.
>
Actually, I'll just drop the imx7ulp from the imx8dxl dts nodes and then
from this patch.
The imx7ulp compatible is not needed anymore because the following
commit:
b4b844930f27bf7019 ("tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"
got reverted by:
4e9679738a918d8a48 ('Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"')
Will resend with proper changes.
> Rob
prev parent reply other threads:[~2022-01-14 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 11:16 [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible Abel Vesa
2021-12-21 13:43 ` Rob Herring
2022-01-14 15:29 ` Abel Vesa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeGW8IgkxFN/r7WR@abelvesa \
--to=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.