From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Kristen Carlson Accardi <kristen@linux.intel.com>,
linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86/sgx: account backing pages
Date: Sat, 15 Jan 2022 02:58:08 +0200 [thread overview]
Message-ID: <YeIcIMNUK/ujMTMQ@iki.fi> (raw)
In-Reply-To: <3b7e79ea-18f2-afe2-be4e-401524b481f7@intel.com>
On Fri, Jan 14, 2022 at 03:55:43PM -0800, Dave Hansen wrote:
> On 1/14/22 3:52 PM, Jarkko Sakkinen wrote:
> >> I can understand your hesitation, but I agree with Dave here that
> >> wrapping the function makes the code more clear. I would prefer to keep
> >> this the way it is.
> > What if sgx_encl_get_backing() was changed as "static inline", if the
> > only motivation is encapsulation?
>
> What would the purpose be of adding an 'inline' to the function definition?
Agreed, not much sense to do this. I just had troubles to get the way
things were encapsulated before your response.
/Jarkko
next prev parent reply other threads:[~2022-01-15 0:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 18:16 [PATCH v2 0/2] x86/sgx: Limit EPC overcommit Kristen Carlson Accardi
2022-01-07 18:16 ` [PATCH v2 1/2] x86/sgx: Add accounting for tracking overcommit Kristen Carlson Accardi
2022-01-07 18:46 ` Dave Hansen
2022-01-07 19:16 ` Kristen Carlson Accardi
2022-01-11 14:20 ` Haitao Huang
2022-01-11 15:43 ` Dave Hansen
2022-01-11 16:33 ` Haitao Huang
2022-01-11 17:39 ` Dave Hansen
2022-01-14 17:45 ` Kristen Carlson Accardi
2022-01-08 15:59 ` Jarkko Sakkinen
2022-01-14 17:47 ` Kristen Carlson Accardi
2022-01-07 18:16 ` [PATCH v2 2/2] x86/sgx: account backing pages Kristen Carlson Accardi
2022-01-08 16:05 ` Jarkko Sakkinen
2022-01-14 17:51 ` Kristen Carlson Accardi
2022-01-14 17:55 ` Dave Hansen
2022-01-14 23:57 ` Jarkko Sakkinen
2022-01-15 0:16 ` Dave Hansen
2022-01-15 0:56 ` Jarkko Sakkinen
2022-01-14 23:52 ` Jarkko Sakkinen
2022-01-14 23:55 ` Dave Hansen
2022-01-15 0:58 ` Jarkko Sakkinen [this message]
2022-01-15 18:57 ` [PATCH v2 0/2] x86/sgx: Limit EPC overcommit Jarkko Sakkinen
2022-01-15 19:02 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeIcIMNUK/ujMTMQ@iki.fi \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.