From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
Denis Kenzior <denkenz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
James Morris <james.morris@microsoft.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/3] KEYS: asym_tpm: fix incorrect comment
Date: Sat, 15 Jan 2022 21:12:53 +0200 [thread overview]
Message-ID: <YeMctWTFlQJcElV6@iki.fi> (raw)
In-Reply-To: <20220113235440.90439-3-ebiggers@kernel.org>
On Thu, Jan 13, 2022 at 03:54:39PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> tpm_key_create() doesn't actually load the key into the TPM. Fix the
> comment to describe what the function does.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
This asym_tpm has not been properly reviewed as far as I can tell.
For starters, I do not get who needed new TPM 1.x features in 2018...
It's long after SHA1 was declared as insecure and world was mostly
settled with TPM2.
BR, Jarkko
next prev parent reply other threads:[~2022-01-15 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 23:54 [PATCH 0/3] KEYS: fixes for asym_tpm keys Eric Biggers
2022-01-13 23:54 ` [PATCH 1/3] KEYS: asym_tpm: fix buffer overreads in extract_key_parameters() Eric Biggers
2022-01-15 21:40 ` Jarkko Sakkinen
2022-01-19 0:59 ` Eric Biggers
2022-01-26 14:21 ` Jarkko Sakkinen
2022-01-26 14:22 ` Jarkko Sakkinen
2022-01-28 19:00 ` Eric Biggers
2022-02-08 9:30 ` Jarkko Sakkinen
2022-01-13 23:54 ` [PATCH 2/3] KEYS: asym_tpm: fix incorrect comment Eric Biggers
2022-01-15 19:12 ` Jarkko Sakkinen [this message]
2022-01-13 23:54 ` [PATCH 3/3] KEYS: asym_tpm: rename derive_pub_key() Eric Biggers
2022-01-15 19:09 ` Jarkko Sakkinen
2022-01-14 14:54 ` [PATCH 0/3] KEYS: fixes for asym_tpm keys Denis Kenzior
2022-01-15 21:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeMctWTFlQJcElV6@iki.fi \
--to=jarkko@kernel.org \
--cc=denkenz@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=james.morris@microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.