From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org, sean.wang@mediatek.com
Subject: Re: [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module
Date: Sun, 16 Jan 2022 21:58:42 +0100 [thread overview]
Message-ID: <YeSHAhI5HzjKsuKx@lore-desk> (raw)
In-Reply-To: <5fdb8db1f02ffdacd554b7db531cf7719399cbdd.camel@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]
> On Sun, 2022-01-16 at 13:43 +0100, Lorenzo Bianconi wrote:
> > Move HE radiotap parsing code in mt76-connac module since it is
> > shared
> > between mt7921 and mt7915 drivers.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > .../net/wireless/mediatek/mt76/mt76_connac.h | 2 +
> > .../wireless/mediatek/mt76/mt76_connac_mac.c | 168 ++++++++++++++++
> > .../wireless/mediatek/mt76/mt76_connac_mac.h | 4 +
> > .../net/wireless/mediatek/mt76/mt7915/mac.c | 175 +---------------
> > -
>
> [...]
>
> > +mt76_connac_mac_decode_he_mu_radiotap(struct sk_buff *skb, __le32
> > *rxv)
> > +{
> > + struct mt76_rx_status *status = (struct mt76_rx_status *)skb-
> > >cb;
> > + static const struct ieee80211_radiotap_he_mu mu_known = {
> > + .flags1 = HE_BITS(MU_FLAGS1_SIG_B_MCS_KNOWN) |
> > + HE_BITS(MU_FLAGS1_SIG_B_DCM_KNOWN) |
> > + HE_BITS(MU_FLAGS1_CH1_RU_KNOWN) |
> > + HE_BITS(MU_FLAGS1_SIG_B_SYMS_USERS_KNOWN) |
> > + HE_BITS(MU_FLAGS1_SIG_B_COMP_KNOWN),
> > + .flags2 = HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) |
> > + HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN),
>
> I think hardware doesn't report MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN and
> MU_FLAGS1_SIG_B_COMP_KNOWN. Should align mt7915 here.
ack, thx for point this out.
@Sean: can you please confirm it?
Regards,
Lorenzo
>
> Ryder
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-16 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 12:43 [PATCH 0/5] move shared mac code in mt76_connac module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 1/5] mt76: connac: move mt76_connac_lmac_mapping in mt76-connac module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 2/5] mt76: connac: move common mac defs in mt76_connac_mac.h Lorenzo Bianconi
2022-01-17 9:42 ` Felix Fietkau
2022-01-17 10:55 ` Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 3/5] mt76: connac: move mt76_connac_reverse_frag0_hdr_trans in common module Lorenzo Bianconi
2022-01-16 12:43 ` [PATCH 4/5] mt76: connac: move he radiotap parsing in connac module Lorenzo Bianconi
2022-01-16 17:55 ` Ryder Lee
2022-01-16 20:58 ` Lorenzo Bianconi [this message]
2022-01-16 12:43 ` [PATCH 5/5] mt76: connac: move mt76_connac_mac_write_txwi " Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeSHAhI5HzjKsuKx@lore-desk \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.