From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59D21173 for ; Mon, 17 Jan 2022 09:00:51 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id 25-20020a05600c231900b003497473a9c4so22597573wmo.5 for ; Mon, 17 Jan 2022 01:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uNxywBtauiiSbb3v20qOTEdwlBSnjvT+NFkq6wnHG6A=; b=uYkZcRpC+5iTrpZNb91jTzRJhL0QSKUVPAyDMv1MG/vmYA1FaYKyiluW/8H3cbEl5m AaABkXSAwpn+YTH/gjQedlKZvEa1Emvw20NgSd0XkVIsPqPVji1WIBqEoREbb6BEdK24 FdFfy750P7/grkZOpaMbXeyRhj+mO8lML2jBMN+2FWkTrjgvQvn2YEVR8UIejpaVMls7 WDLyypu2FSvzLEiLNjYzS+HFluXWbjErYbfVSP6HBN3Nxmg0nbFfLl3c6Y6sWrETTzoo fiw76/uA19CPZUGjm5ZKngbUmtqZqRoluJCyBWWYLCjhMynacVRLur9kUB8jD/D1zBTB 4YbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uNxywBtauiiSbb3v20qOTEdwlBSnjvT+NFkq6wnHG6A=; b=Ac5PirEI/o1nNSJMd2uHZ3P6e7hRcz0DAKv0UbzT629LVtWTUdSWJF3Nq652SJObJd wHj0jMFmmMF2PBsLSW71OmcgqgMxEeo+zkLSi2K45JWoLDZMFgyAL8PH2PLoN6j/5DcS PW5G0m0eWELDTVLW/914eZuQ8GtXFcRs3DFxAkfZLsXa5a1YKY6Aj8gBRI1j89rhJNEI yy5OL3R8bsrV9w6wrn+fBSlqS8FPaPMQKVEPv6Fk3LgeVK5px1IB0rTKBTX15+E1lUuN o6VZljLs0a03oIWd5HHmfgAWWcqZptFflXuoUHZkKuWPKWwtxwtvrd54IVgzyRh3VSjC YygA== X-Gm-Message-State: AOAM530BeIpb1JnqZKEQwa2kmAJ1a261puUlKWl0euYDkiT6fZwDAetu laGGGXA/aA++Jw3Ur++gusCugA== X-Google-Smtp-Source: ABdhPJy38hNJCJT4tL2Qb1TkrATt+lRfqvgALC0NS55iT+Qdy/srg+77wndo1Hj9NAop5w193ZmUqg== X-Received: by 2002:adf:f390:: with SMTP id m16mr18858434wro.651.1642410049663; Mon, 17 Jan 2022 01:00:49 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id i6sm8859710wrf.21.2022.01.17.01.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 01:00:49 -0800 (PST) Date: Mon, 17 Jan 2022 09:00:49 +0000 From: Lee Jones To: Evgeny Boger Cc: Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, Jernej Skrabec , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40 Message-ID: References: <20211119191456.510435-1-boger@wirenboard.com> <20211119191456.510435-2-boger@wirenboard.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211119191456.510435-2-boger@wirenboard.com> On Fri, 19 Nov 2021, Evgeny Boger wrote: > R40 SoC has touchscreen controller also serving as general-purpose ADC. > The hardware is very similar to A31, except that R40 has separate > calibrated thermal sensor IP (handled by sun8i_thermal). > > Despite the temperature sensor in the RTP is never mentioned in > the R40 family user manuals, it appears to be working. However, > it's not very useful as it lacks calibration data and there is another > fully functioning temperature sensor anyway. > > This patch disables the temperature sensor in RTP/GPADC IP on R40. > > The reason for disabling the temperature sensor is that the IP > needs to be switched back and forth between RTP and GPADC modes for > temperature measurements. Not only this introduces delays, but it also > disturbs external circuitry by injecting current into ADC inputs. > > Signed-off-by: Evgeny Boger > --- > drivers/iio/adc/sun4i-gpadc-iio.c | 32 +++++++++++++++++++++++-------- > drivers/mfd/sun4i-gpadc.c | 17 ++++++++++++++++ Please split these out. They don't *need* to go in via a single tree. > 2 files changed, 41 insertions(+), 8 deletions(-) -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47BAFC433EF for ; Mon, 17 Jan 2022 09:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S4LF9njlsAkBmJTFQGUGLObRkJlovifkBGshge/zd08=; b=zzWAC/1pGyA8vp muUkP5STq3vFt+rIB3hpFq/Exd/tiItf/l8x6GRuREEhs5/8fv17DgjlTKbBUQD8+h+dQtiHCVHzT IN8wl8YFjxNIm8OaZYVpTrZF/pnqYh8KCM/L+DD6rWQf1vcugmlzducFhc599Feqd4NnKxLje4VEu o+7g7krL5aK/PHj5m/Q7FuBsZRWmUbS9cINoKtpG1S0R8KzxN8wUZNOM71T3ZW2mg7sojoOfbAcNL +IBc27/JNZlJdKlPjuw29YO3qYk7h1OMCY1lb4Ii4lN9jSQF0qF8oJNmvIqTl84ULEsbMI2I8meKA jm5nIwPHe3uOJoulNwHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9Nsn-00EByd-41; Mon, 17 Jan 2022 09:00:57 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9Nsj-00EBwV-Ho for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 09:00:54 +0000 Received: by mail-wm1-x32d.google.com with SMTP id d18-20020a05600c251200b0034974323cfaso22595831wma.4 for ; Mon, 17 Jan 2022 01:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uNxywBtauiiSbb3v20qOTEdwlBSnjvT+NFkq6wnHG6A=; b=uYkZcRpC+5iTrpZNb91jTzRJhL0QSKUVPAyDMv1MG/vmYA1FaYKyiluW/8H3cbEl5m AaABkXSAwpn+YTH/gjQedlKZvEa1Emvw20NgSd0XkVIsPqPVji1WIBqEoREbb6BEdK24 FdFfy750P7/grkZOpaMbXeyRhj+mO8lML2jBMN+2FWkTrjgvQvn2YEVR8UIejpaVMls7 WDLyypu2FSvzLEiLNjYzS+HFluXWbjErYbfVSP6HBN3Nxmg0nbFfLl3c6Y6sWrETTzoo fiw76/uA19CPZUGjm5ZKngbUmtqZqRoluJCyBWWYLCjhMynacVRLur9kUB8jD/D1zBTB 4YbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uNxywBtauiiSbb3v20qOTEdwlBSnjvT+NFkq6wnHG6A=; b=Dl9cwMB+keRLqMw6fE06wBY9wHehRzuMHfEj6rR37u7DmXW7bRlhPOiq5mwskFcV0i tq0TBpczOK1YSg4PQQfYJ/U/HVsajWOIOdYCYNzsNqu3TCp2i/LD9DzhktugPny8Wb19 LV6VvZtGTMwuMNoGtvmeJqKevIAcuFW6+EzDdKB91hrTgnNUnvB951XQsHd6EnVep8+Q tlxkbB1ZADND1sY44Vd/8FxIscpFuOIKul4IRB+pPRjCNXY2gefYOgVxjSfQZCWUYYYH 81VssE7erura+eEBjDu6s3ere05uBnbPvb2lLrIh9q75ojB+ehoFxHAVZYpY53xwbK52 sN+A== X-Gm-Message-State: AOAM530G9RpP9obUVL8vWKB/XDDge/L3RVgVtEFdD8TQODu3lTHD9nE2 j0gvUgXcqdJABDPLuAK+LcqKBQ== X-Google-Smtp-Source: ABdhPJy38hNJCJT4tL2Qb1TkrATt+lRfqvgALC0NS55iT+Qdy/srg+77wndo1Hj9NAop5w193ZmUqg== X-Received: by 2002:adf:f390:: with SMTP id m16mr18858434wro.651.1642410049663; Mon, 17 Jan 2022 01:00:49 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id i6sm8859710wrf.21.2022.01.17.01.00.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 01:00:49 -0800 (PST) Date: Mon, 17 Jan 2022 09:00:49 +0000 From: Lee Jones To: Evgeny Boger Cc: Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, Jernej Skrabec , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] iio: adc: sun4i-gpadc-iio: no temp sensor on R40 Message-ID: References: <20211119191456.510435-1-boger@wirenboard.com> <20211119191456.510435-2-boger@wirenboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211119191456.510435-2-boger@wirenboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_010053_616668_016D1357 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxOSBOb3YgMjAyMSwgRXZnZW55IEJvZ2VyIHdyb3RlOgoKPiBSNDAgU29DIGhhcyB0 b3VjaHNjcmVlbiBjb250cm9sbGVyIGFsc28gc2VydmluZyBhcyBnZW5lcmFsLXB1cnBvc2UgQURD Lgo+IFRoZSBoYXJkd2FyZSBpcyB2ZXJ5IHNpbWlsYXIgdG8gQTMxLCBleGNlcHQgdGhhdCBSNDAg aGFzIHNlcGFyYXRlCj4gY2FsaWJyYXRlZCB0aGVybWFsIHNlbnNvciBJUCAoaGFuZGxlZCBieSBz dW44aV90aGVybWFsKS4KPiAKPiBEZXNwaXRlIHRoZSB0ZW1wZXJhdHVyZSBzZW5zb3IgaW4gdGhl IFJUUCBpcyBuZXZlciBtZW50aW9uZWQgaW4KPiB0aGUgUjQwIGZhbWlseSB1c2VyIG1hbnVhbHMs IGl0IGFwcGVhcnMgdG8gYmUgd29ya2luZy4gSG93ZXZlciwKPiBpdCdzIG5vdCB2ZXJ5IHVzZWZ1 bCBhcyBpdCBsYWNrcyBjYWxpYnJhdGlvbiBkYXRhIGFuZCB0aGVyZSBpcyBhbm90aGVyCj4gZnVs bHkgZnVuY3Rpb25pbmcgdGVtcGVyYXR1cmUgc2Vuc29yIGFueXdheS4KPiAKPiBUaGlzIHBhdGNo IGRpc2FibGVzIHRoZSB0ZW1wZXJhdHVyZSBzZW5zb3IgaW4gUlRQL0dQQURDIElQIG9uIFI0MC4K PiAKPiBUaGUgcmVhc29uIGZvciBkaXNhYmxpbmcgdGhlIHRlbXBlcmF0dXJlIHNlbnNvciBpcyB0 aGF0IHRoZSBJUAo+IG5lZWRzIHRvIGJlIHN3aXRjaGVkIGJhY2sgYW5kIGZvcnRoIGJldHdlZW4g UlRQIGFuZCBHUEFEQyBtb2RlcyBmb3IKPiB0ZW1wZXJhdHVyZSBtZWFzdXJlbWVudHMuIE5vdCBv bmx5IHRoaXMgaW50cm9kdWNlcyBkZWxheXMsIGJ1dCBpdCBhbHNvCj4gZGlzdHVyYnMgZXh0ZXJu YWwgY2lyY3VpdHJ5IGJ5IGluamVjdGluZyBjdXJyZW50IGludG8gQURDIGlucHV0cy4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBFdmdlbnkgQm9nZXIgPGJvZ2VyQHdpcmVuYm9hcmQuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2lpby9hZGMvc3VuNGktZ3BhZGMtaWlvLmMgfCAzMiArKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tCj4gIGRyaXZlcnMvbWZkL3N1bjRpLWdwYWRjLmMgICAgICAgICB8IDE3 ICsrKysrKysrKysrKysrKysKClBsZWFzZSBzcGxpdCB0aGVzZSBvdXQuCgpUaGV5IGRvbid0ICpu ZWVkKiB0byBnbyBpbiB2aWEgYSBzaW5nbGUgdHJlZS4KCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDEg aW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K UHJpbmNpcGFsIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg 4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNl Ym9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==