All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [COMMITTED][PATCH] ci/wiki-mirror: Fix triggering CI
Date: Mon, 17 Jan 2022 11:13:43 +0100	[thread overview]
Message-ID: <YeVBV8D3jNtGAxYa@pevik> (raw)
In-Reply-To: <61E534C5.6060005@fujitsu.com>

Hi Xu,

> > FYI ba99b81708 ("doc: Fix typo missing s in .all_filesystems")
> > verified it's working:

> > https://github.com/linux-test-project/ltp/actions/runs/1707090366

> I found this problem when doc/* patch isn't the last patch of a
> patchset.  But here it is a single patch.
Path check was removed in 820cfe539b ("ci/wiki-mirror: Don't check path").

Paths should be working not only on last commit, IMHO it evaluates all files in
push
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
"When using the push and pull_request events, you can configure a workflow to
run based on what file paths are changed. Path filters are not evaluated for
pushes of tags."

=> it should be working even If I revert 820cfe539b, because running that
workflow does not take long.


Verification it's working on my local repo:

I pushed few commits in my local branch:
https://github.com/pevik/ltp/commits/tmp
the last commit was on .github/workflows/wiki-mirror.yml adding:
+    paths:
+      - 'doc/**'

commit only in that branch (not in upstream):
aa7ec06d22 ("Revert "ci/wiki-mirror: Don't check path"")

Other commit was modifying repo to 'pevik/ltp'

https://github.com/pevik/ltp/actions/runs/1699238259/workflow
...
on:
  push:
    branches:
      - master
      - tmp
    paths:
      - 'doc/**'

jobs:
  mirror:
    runs-on: ubuntu-latest
    if: ${{ github.repository == 'pevik/ltp' }}
...

and that push triggered CI:
https://github.com/pevik/ltp/actions/runs/1699228985
(failed because my local repo does not have rights)

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-01-17 10:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17  9:07 [LTP] [COMMITTED][PATCH] ci/wiki-mirror: Fix triggering CI Petr Vorel
2022-01-17  9:19 ` xuyang2018.jy
2022-01-17 10:13   ` Petr Vorel [this message]
2022-01-18  1:11     ` xuyang2018.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeVBV8D3jNtGAxYa@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.