From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DB1C433F5 for ; Mon, 17 Jan 2022 15:36:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C4B2249F24; Mon, 17 Jan 2022 10:36:19 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armlinux.org.uk Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GnDenAhvNLVn; Mon, 17 Jan 2022 10:36:18 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 96F2E49F03; Mon, 17 Jan 2022 10:36:18 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ED0B049DED for ; Mon, 17 Jan 2022 10:36:16 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hyRcp+XayH7T for ; Mon, 17 Jan 2022 10:36:15 -0500 (EST) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id BDD7343C96 for ; Mon, 17 Jan 2022 10:36:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6wdb+RSfOYtXVx2QzAjSPlhmXyeOp04Xz18+mlcDwiY=; b=MAi5evp5V1emr8iC5rBW99L0Kd aYrxpLT61TZn/0Hc2idjx6aGbcXjB3PM12uzncY/pc2UqCWXrlWPD54bsBLZUpu2v/9gL7VuTQOVk DKOcWU5DSOuqVfODoMdkJxx7aX8+O6ZZ8Q87Y0vJ9wu4N0c6VTEnXnw2g95Ild0pmFU/4WBMW9le7 1WQyUuxf9N0hHDc5cp6RlfdkjIQf8piKdoz4bXZK3yX4jr9JAaKgMbxupaPq7mAE1zvrF4+tXAc7x RIxs5IhegTeFvFFnF6nVQzvlE+m7PpElvBZhBZrSAPcOY3yk1u4wQFlAM/hojf67GDw0PHlNrWwPj 7RZkDfKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56726) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9U3J-0002ma-F8; Mon, 17 Jan 2022 15:36:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n9U3F-0003Q2-4W; Mon, 17 Jan 2022 15:36:09 +0000 Date: Mon, 17 Jan 2022 15:36:09 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Subject: Re: [PATCH v5 01/69] KVM: arm64: Save PSTATE early on exit Message-ID: References: <20211129200150.351436-1-maz@kernel.org> <20211129200150.351436-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129200150.351436-2-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , kvmarm@lists.cs.columbia.edu, Ganapatrao Kulkarni , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Nov 29, 2021 at 08:00:42PM +0000, Marc Zyngier wrote: > In order to be able to use primitives such as vcpu_mode_is_32bit(), > we need to synchronize the guest PSTATE. However, this is currently > done deep into the bowels of the world-switch code, and we do have > helpers evaluating this much earlier (__vgic_v3_perform_cpuif_access > and handle_aarch32_guest, for example). > > Move the saving of the guest pstate into the early fixups, which > cures the first issue. The second one will be addressed separately. > > Tested-by: Fuad Tabba > Reviewed-by: Fuad Tabba > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEF79C433F5 for ; Mon, 17 Jan 2022 15:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8LbSnTdk1WXuzb9arTv7VEPtIt7Jj7I1u7IVX8B0caw=; b=uLw4LPRWKZ8ud7 kcAbuWNNwtohIu5BwrR7DX00xMBuJcQ0T8m+HNAqwfhqtOuV4QCY5RoDDnt6iOygbr2gyVjH4N5JO e1Fc/PlJK+W6mKdryCtoHmAkv0Uxx1Dlgz4BDBuLcX4oUZzCbFTe2/L2DDwCf5/pm7pjpSuEJYDfM lQ1bkSnlm4WqwtNK8LpK5znRK6+ZUCXJfSCQITZ6G7WWL6jQhUbNumdEJJGRM8w3uBBz+cYRssGsa di/kV7yDCi1LD6TRDDI9ClGx/PMvSSrbfFKedG6CBaeRTsJuvlZjO2wRpc0s/6AVyICqvVazmkuW3 AoEyEiJ6TQTmFolvrwwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9U3S-00FPKV-Bf; Mon, 17 Jan 2022 15:36:22 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9U3N-00FPHR-P9 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 15:36:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6wdb+RSfOYtXVx2QzAjSPlhmXyeOp04Xz18+mlcDwiY=; b=MAi5evp5V1emr8iC5rBW99L0Kd aYrxpLT61TZn/0Hc2idjx6aGbcXjB3PM12uzncY/pc2UqCWXrlWPD54bsBLZUpu2v/9gL7VuTQOVk DKOcWU5DSOuqVfODoMdkJxx7aX8+O6ZZ8Q87Y0vJ9wu4N0c6VTEnXnw2g95Ild0pmFU/4WBMW9le7 1WQyUuxf9N0hHDc5cp6RlfdkjIQf8piKdoz4bXZK3yX4jr9JAaKgMbxupaPq7mAE1zvrF4+tXAc7x RIxs5IhegTeFvFFnF6nVQzvlE+m7PpElvBZhBZrSAPcOY3yk1u4wQFlAM/hojf67GDw0PHlNrWwPj 7RZkDfKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56726) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9U3J-0002ma-F8; Mon, 17 Jan 2022 15:36:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n9U3F-0003Q2-4W; Mon, 17 Jan 2022 15:36:09 +0000 Date: Mon, 17 Jan 2022 15:36:09 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH v5 01/69] KVM: arm64: Save PSTATE early on exit Message-ID: References: <20211129200150.351436-1-maz@kernel.org> <20211129200150.351436-2-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129200150.351436-2-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_073617_851284_88606993 X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 08:00:42PM +0000, Marc Zyngier wrote: > In order to be able to use primitives such as vcpu_mode_is_32bit(), > we need to synchronize the guest PSTATE. However, this is currently > done deep into the bowels of the world-switch code, and we do have > helpers evaluating this much earlier (__vgic_v3_perform_cpuif_access > and handle_aarch32_guest, for example). > > Move the saving of the guest pstate into the early fixups, which > cures the first issue. The second one will be addressed separately. > > Tested-by: Fuad Tabba > Reviewed-by: Fuad Tabba > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36069C433EF for ; Mon, 17 Jan 2022 15:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240508AbiAQPgV (ORCPT ); Mon, 17 Jan 2022 10:36:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240510AbiAQPgR (ORCPT ); Mon, 17 Jan 2022 10:36:17 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62C37C061574 for ; Mon, 17 Jan 2022 07:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6wdb+RSfOYtXVx2QzAjSPlhmXyeOp04Xz18+mlcDwiY=; b=MAi5evp5V1emr8iC5rBW99L0Kd aYrxpLT61TZn/0Hc2idjx6aGbcXjB3PM12uzncY/pc2UqCWXrlWPD54bsBLZUpu2v/9gL7VuTQOVk DKOcWU5DSOuqVfODoMdkJxx7aX8+O6ZZ8Q87Y0vJ9wu4N0c6VTEnXnw2g95Ild0pmFU/4WBMW9le7 1WQyUuxf9N0hHDc5cp6RlfdkjIQf8piKdoz4bXZK3yX4jr9JAaKgMbxupaPq7mAE1zvrF4+tXAc7x RIxs5IhegTeFvFFnF6nVQzvlE+m7PpElvBZhBZrSAPcOY3yk1u4wQFlAM/hojf67GDw0PHlNrWwPj 7RZkDfKg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56726) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9U3J-0002ma-F8; Mon, 17 Jan 2022 15:36:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n9U3F-0003Q2-4W; Mon, 17 Jan 2022 15:36:09 +0000 Date: Mon, 17 Jan 2022 15:36:09 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH v5 01/69] KVM: arm64: Save PSTATE early on exit Message-ID: References: <20211129200150.351436-1-maz@kernel.org> <20211129200150.351436-2-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211129200150.351436-2-maz@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Nov 29, 2021 at 08:00:42PM +0000, Marc Zyngier wrote: > In order to be able to use primitives such as vcpu_mode_is_32bit(), > we need to synchronize the guest PSTATE. However, this is currently > done deep into the bowels of the world-switch code, and we do have > helpers evaluating this much earlier (__vgic_v3_perform_cpuif_access > and handle_aarch32_guest, for example). > > Move the saving of the guest pstate into the early fixups, which > cures the first issue. The second one will be addressed separately. > > Tested-by: Fuad Tabba > Reviewed-by: Fuad Tabba > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!