From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Keith Busch <kbusch@kernel.org>,
kw@linux.com, mariusz.tkaczyk@linux.intel.com,
helgaas@kernel.org, lukas@wunner.de, pavel@ucw.cz,
linux-cxl@vger.kernel.org, martin.petersen@oracle.com,
James.Bottomley@hansenpartnership.com,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RFC PATCH 1/3] Add support for seven more indicators in enclosure driver
Date: Tue, 18 Jan 2022 07:16:40 +0100 [thread overview]
Message-ID: <YeZbSGPqHaSnNurq@kroah.com> (raw)
In-Reply-To: <de41441fa835af52ac53a08013534e0cdd448aa9.1642460765.git.stuart.w.hayes@gmail.com>
On Mon, Jan 17, 2022 at 10:17:56PM -0600, Stuart Hayes wrote:
> This patch adds support for seven additional indicators (ok, rebuild,
> prdfail, hotspare, ica, ifa, disabled) to the enclosure driver, which
> currently only supports three (fault, active, locate). It also reduces
> duplicated code for the set and show functions for the sysfs attributes
> for all of the indicators, and allows users of the driver to provide
> common get_led and set_led callbacks to control all indicators (though
> it continues to support the existing callbacks for the three currently
> supported indicators, so it does not require any changes to code that
> already uses the enclosure driver).
>
> This will be used by the pcie_em driver.
>
> Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
> ---
> drivers/misc/enclosure.c | 189 ++++++++++++++++++++++----------------
> include/linux/enclosure.h | 22 +++++
> 2 files changed, 133 insertions(+), 78 deletions(-)
You did not document your new sysfs files in Documentation/ABI/ anywhere
:(
next prev parent reply other threads:[~2022-01-18 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 4:17 [RFC PATCH 0/3] Add PCIe enclosure management support Stuart Hayes
2022-01-18 4:17 ` [RFC PATCH 1/3] Add support for seven more indicators in enclosure driver Stuart Hayes
2022-01-18 6:16 ` Greg Kroah-Hartman [this message]
2022-01-18 4:17 ` [RFC PATCH 2/3] Add PCIe enclosure management auxiliary driver Stuart Hayes
2022-01-31 11:59 ` Mariusz Tkaczyk
2022-02-02 17:54 ` stuart hayes
2022-01-18 4:17 ` [RFC PATCH 3/3] Register auxiliary device for PCIe enclosure management Stuart Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeZbSGPqHaSnNurq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=kw@linux.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=martin.petersen@oracle.com \
--cc=pavel@ucw.cz \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.