From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBDE9C433EF for ; Thu, 20 Jan 2022 07:09:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2DF842FD1; Thu, 20 Jan 2022 08:08:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2DF842FD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642662552; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=abgoRIWGB5seEFqVx4/OF7w2mn1NsrdZv4kjS3hBnbTkYF+/Q5SfIV1fR2o5DTm91 LwOBSrgwRUQ5HIO7wZy+pknypAKSRabJGFqE/ABRvpJliQXIEWBmot4uQP9bXnpZL1 +VwKq4cd498PjyTsb34x7QVTuj2ttIIlAojqakcc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 552A2F80567; Thu, 20 Jan 2022 08:03:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9EC6EF8023B; Tue, 18 Jan 2022 10:33:00 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C2F5CF800CE for ; Tue, 18 Jan 2022 10:32:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C2F5CF800CE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IYXMJ0VP" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1F41611D6; Tue, 18 Jan 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> X-Mailman-Approved-At: Thu, 20 Jan 2022 08:03:35 +0100 Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, linux-spi@vger.kernel.org, Lee Jones , openipmi-developer@lists.sourceforge.net, Khuong Dinh , Florian Fainelli , Matthias Schiffer , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , linux-pwm@vger.kernel.org, Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Sebastian Reichel , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Tony Luck , Mun Yew Tham , Eric Auger , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Sergey Shtylyov , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0E5C4332F for ; Tue, 18 Jan 2022 09:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238998AbiARJc6 (ORCPT ); Tue, 18 Jan 2022 04:32:58 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:51592 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235807AbiARJc5 (ORCPT ); Tue, 18 Jan 2022 04:32:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9DC1B81223; Tue, 18 Jan 2022 09:32:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Tony Luck , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , Matthias Brugger , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Sergey Shtylyov , Richard Weinberger , Mun Yew Tham , Hans de Goede , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56650C4167D for ; Tue, 18 Jan 2022 09:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q5SiNGkT0AfUawO5TF8zljCmG7uC83Wu6qG3AD7fA4w=; b=JZXeIS+9VXxaGA Ia0YNd90Lp8fAiUrqFsvv8O4LdTsIkq5S3TbAWiX4A9U6QPIWdhkrCnyDiZonmR6bd+tK6A7tPTDd 3Tc1dCp5siFQuza+oqOGaxH9c7JYkr7/UF6ZkMirDpUh56a8GMaFzKQ3pime4sBr8tBBCpVvLQjMW HjAZKCR2jeWgDB03Qax/JY6rjc3JdhTz+ATwb4PjohnbRKhwUxWqal6kV8OoFglH0K/vDu2NKxXSR sw1y0wRsIbgATaDETDC2yLp8OdBdvxUcDdpoOLBblzp/2PscyNpbz+uLy5M/qcz6xdJo3W1YlGO6w yfnotpdZGAHX2fKru7OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krK-000uv4-He; Tue, 18 Jan 2022 09:32:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krG-000utz-Q3; Tue, 18 Jan 2022 09:32:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1F41611D6; Tue, 18 Jan 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Tony Luck , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , Matthias Brugger , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Sergey Shtylyov , Richard Weinberger , Mun Yew Tham , Hans de Goede , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_013254_949056_89950E90 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users = are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > = > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9363C433EF for ; Tue, 18 Jan 2022 09:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uXk0pzn5j6c3uwr7ok+Yob65HDZqVsdZePbSVjEg/k=; b=aEPs1llxP2wa2m I5t9tuOPGBb1q5sVt4/Z02TAWTUPjlKNkZacN4PcVi3SZEHLkkSBFWOFfNShWGyC6iJy3kVjNSDTr I2LK1GiC4I/Dipc/Zo5DZHIukXgvc8TC8eP9OTgVKr415VfY7t5yWY8QWNeJzD1W7Xrsb7zHQ0ICb IVrpnt1dsI79+QjvT9enu6SQRqK6BjvWBMdbLn7PXHpCs77LHau9YL9YFK4yqbrthzrtA5Y7qHAkI PsB0ZC+bRE8PPiydBEfftvGt4GoNKMFcV16mSRcNurh+kGFbcavY0oEIw+lwEZ4q0CRr5XMxXmfQb E+/7xyIqSYDMiReCFu1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krL-000uvC-Ju; Tue, 18 Jan 2022 09:32:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krG-000utz-Q3; Tue, 18 Jan 2022 09:32:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1F41611D6; Tue, 18 Jan 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Tony Luck , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , Matthias Brugger , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Sergey Shtylyov , Richard Weinberger , Mun Yew Tham , Hans de Goede , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_013254_949056_89950E90 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users = are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > = > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88316C433F5 for ; Tue, 18 Jan 2022 09:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bIrvh9pp+/bXHaTr7vi4AEqLJIPDvF4F3lHMkDdqCUA=; b=fRReqiQxODtABh skwoxaH+m4dUvn1+PC+9Y+b3px0tHU83AG3/jdOt6iIVXW0jMgPII1OZzSdPh9xNqK4gaON5VQxq3 8oCLvowqbMlUI8u/mGdI4YkSFNAQebWm3f+kzGk/+UbH3pPO5I/Be9yJQwjX+kxeTS0fvN+UrIWjJ 4ihBogdLDQdjksboPMHfEJlB+J3l4okKXYq/IryXI2wO7FqaRqkLn+dWZ5SRnPQ8X3JMlh5FJkS86 EuZ/+lM5N5e1CEVRWEmCIWhRsWwrZ/iXrNK9WG2BvHq6uVmqrMmQSbqXX/QEBpWH6doFGtQWXIYkB WZH+UKYMJcfWCc/Cb8mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krY-000uzO-Ud; Tue, 18 Jan 2022 09:33:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9krG-000utz-Q3; Tue, 18 Jan 2022 09:32:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1F41611D6; Tue, 18 Jan 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C83C00446; Tue, 18 Jan 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642498373; bh=DQsfwtJhv3xPa9stElQYzBQziBxi/lTSvFxbATxprog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IYXMJ0VPjFYSJY4NvlXmFWheHw/XkPbDg6jYdIXLJdD1zglfnvz6feJDneqRQF/Y7 Xd4h6nOb3hzFwTMGSfrGLMZs9cs+U1HvQaFyP49TIVznh2RAxc+V/DqmrD1t1xwr2a 25A0Y8zcDbS1ew90c5vIYgg7oo/j34B2Guk1t+0Y= Date: Tue, 18 Jan 2022 10:32:50 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , kvm@vger.kernel.org, "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , alsa-devel@alsa-project.org, Liam Girdwood , Guenter Roeck , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal , linux-phy@lists.infradead.org, Lee Jones , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , Bartosz Golaszewski , Daniel Lezcano , Tony Luck , Kishon Vijay Abraham I , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Jakub Kicinski , Zhang Rui , Matthias Brugger , platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org, Robert Richter , Saravanan Sekar , Corey Minyard , linux-pm@vger.kernel.org, Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , linux-gpio@vger.kernel.org, Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , openipmi-developer@lists.sourceforge.net, Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Sergey Shtylyov , Richard Weinberger , Mun Yew Tham , Hans de Goede , netdev@vger.kernel.org, Yoshihiro Shimoda , Cornelia Huck , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) Message-ID: References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_013254_949056_89950E90 X-CRM114-Status: GOOD ( 23.16 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, Jan 18, 2022 at 10:18:19AM +0100, Uwe Kleine-K=F6nig wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-K=F6nig wrote: > > > A possible compromise: We can have both. We rename > > > platform_get_irq_optional() to platform_get_irq_silent() (or > > > platform_get_irq_silently() if this is preferred) and once all users = are > > > are changed (which can be done mechanically), we reintroduce a > > > platform_get_irq_optional() with Sergey's suggested semantic (i.e. > > > return 0 on not-found, no error message printking). > > = > > Please do not do that as anyone trying to forward-port an old driver > > will miss the abi change of functionality and get confused. Make > > build-breaking changes, if the way a function currently works is > > changed in order to give people a chance. > = > Fine for me. I assume this is a Nack for Sergey's patch? This set of patches is going nowhere as-is, sorry. The thread is too confusing and people are not agreeing at all. greg k-h -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy