From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
lorenzo.bianconi@redhat.com, davem@davemloft.net,
kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
shayagr@amazon.com, john.fastabend@gmail.com, dsahern@kernel.org,
brouer@redhat.com, echaudro@redhat.com, jasowang@redhat.com,
alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
tirthendu.sarkar@intel.com, toke@redhat.com
Subject: Re: [PATCH v22 bpf-next 12/23] bpf: add multi-frags support to the bpf_xdp_adjust_tail() API
Date: Tue, 18 Jan 2022 23:25:08 +0100 [thread overview]
Message-ID: <Yec+REpSiOLthoVx@lore-desk> (raw)
In-Reply-To: <20220118202041.uk6ann4w366v4xlf@ast-mbp.dhcp.thefacebook.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
> On Mon, Jan 17, 2022 at 06:28:24PM +0100, Lorenzo Bianconi wrote:
> > BPF_CALL_2(bpf_xdp_adjust_tail, struct xdp_buff *, xdp, int, offset)
> > {
> > void *data_hard_end = xdp_data_hard_end(xdp); /* use xdp->frame_sz */
> > void *data_end = xdp->data_end + offset;
> >
> > + if (unlikely(xdp_buff_has_frags(xdp))) { /* xdp multi-frags */
> > + if (offset < 0)
> > + return bpf_xdp_multi_frags_shrink_tail(xdp, -offset);
> > +
> > + return bpf_xdp_multi_frags_increase_tail(xdp, offset);
> > + }
>
> "multi frags" isn't quite correct here and in other places.
> It sounds like watery water.
> Saying "xdp frags" is enough to explain that xdp has fragments.
> Either multiple fragments or just one fragment doesn't matter.
> I think it would be cleaner to drop "multi".
ack, I will fix it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-18 22:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 17:28 [PATCH v22 bpf-next 00/23] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 01/23] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 02/23] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 03/23] net: mvneta: update multi-frags bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 04/23] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 05/23] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 06/23] net: marvell: rely on " Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 07/23] xdp: add multi-frags support to xdp_return_{buff/frame} Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 08/23] net: mvneta: add multi-frags support to XDP_TX Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 09/23] bpf: introduce BPF_F_XDP_HAS_FRAGS flag in prog_flags loading the ebpf program Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 10/23] net: mvneta: enable jumbo frames if the loaded XDP program support multi-frags Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 11/23] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 12/23] bpf: add multi-frags support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2022-01-18 20:20 ` Alexei Starovoitov
2022-01-18 22:25 ` Lorenzo Bianconi [this message]
2022-01-17 17:28 ` [PATCH v22 bpf-next 13/23] bpf: add multi-frags support to xdp copy helpers Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 14/23] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 15/23] bpf: introduce multi-frags support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 16/23] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 17/23] bpf: selftests: update xdp_adjust_tail selftest to include multi-frags Lorenzo Bianconi
2022-01-18 20:16 ` Alexei Starovoitov
2022-01-18 22:23 ` Lorenzo Bianconi
2022-01-18 22:30 ` Alexei Starovoitov
2022-01-17 17:28 ` [PATCH v22 bpf-next 18/23] libbpf: Add SEC name for xdp multi-frags programs Lorenzo Bianconi
2022-01-18 20:14 ` Alexei Starovoitov
2022-01-18 22:31 ` Lorenzo Bianconi
2022-01-18 22:33 ` Alexei Starovoitov
2022-01-19 1:11 ` Andrii Nakryiko
2022-01-19 9:38 ` Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 19/23] bpf: generalise tail call map compatibility check Lorenzo Bianconi
2022-01-18 20:23 ` Alexei Starovoitov
2022-01-18 22:13 ` Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 20/23] net: xdp: introduce bpf_xdp_pointer utility routine Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 21/23] bpf: selftests: introduce bpf_xdp_{load,store}_bytes selftest Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 22/23] bpf: selftests: add CPUMAP/DEVMAP selftests for xdp multi-frags Lorenzo Bianconi
2022-01-17 17:28 ` [PATCH v22 bpf-next 23/23] xdp: disable XDP_REDIRECT " Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yec+REpSiOLthoVx@lore-desk \
--to=lorenzo@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.