From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFB32C433F5 for ; Tue, 18 Jan 2022 20:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uyeqlb4FsbNnSAddpFZXaT6/DpdOugdPCDw56GHolw0=; b=V7DSL5mN2hyIUH czaqGS0Eso6ckszlHPtsCpie+ggNRTKQg58qzIZI/YtMn/BRIzKtWuNzMPWpDKiamcqR/T2NxE+yX 9nmPjKBA9OZej1y0My3Kyuh7YvJovpcekXxk8ChkPMc6dA7NCwwNZp4v503mB3va5Ss7V0lKm6Bch WXTGIaWVS6lBPWgoNwrXMRZTuyl/PXqbJUzIpiFwb4yYIsxvb8PSJKrl9s5d8qmH+S0no8ekgdkSL NbWG/ka3NONDg7gEQMFiiucRaZcKvZZsxqQCtkkX0MBbAOL7txPQYjfnyk4fjVW0fVycmFUIrSx9S PAl307guY63xicNKp5aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9vOr-002vfA-Js; Tue, 18 Jan 2022 20:48:17 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9vOn-002vdP-NE; Tue, 18 Jan 2022 20:48:15 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AAF5A14C3; Tue, 18 Jan 2022 21:48:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642538887; bh=PiLgNaz1zZmzJhD5V79Sl741bXKE9AAuqWKWE1i4D78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bp3SGAX4t0+qm8zzxPxJ7gZ02CZCDEzE/hofaRHApDTHVj+eke//sRwgD76r/i2Fi GkvaMB+6zE6To1L965c/5QPjWF27RS15CSEaQRTWwpH57dzRlZPRmxX6OYl/iqUj7k Kbplfpa07WsujVY70Kw+ztofAZ3oMz4fcc3dGsTU= Date: Tue, 18 Jan 2022 22:47:53 +0200 From: Laurent Pinchart To: Florian Fainelli Cc: Jean-Michel Hautbois , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson , Maxime Ripard Subject: Re: [PATCH v3] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: References: <20211231115109.94626-1-uwe@kleine-koenig.org> <2540edbe-084e-802f-3533-0aa66ddc20ec@ideasonboard.com> <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_124813_951599_55E57363 X-CRM114-Status: GOOD ( 29.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRmxvcmlhbiwKCk9uIFR1ZSwgSmFuIDE4LCAyMDIyIGF0IDEyOjAwOjUwUE0gLTA4MDAsIEZs b3JpYW4gRmFpbmVsbGkgd3JvdGU6Cj4gT24gMS8xOC8yMiAxMTo0NSBBTSwgSmVhbi1NaWNoZWwg SGF1dGJvaXMgd3JvdGU6Cj4gPiBPbiAzMS8xMi8yMDIxIDEyOjUxLCBVd2UgS2xlaW5lLUvDtm5p ZyB3cm90ZToKPiA+PiBUaGUgY200LWlvIGJvYXJkIGNvbWVzIHdpdGggYW4gUENGODUwNjMuIEFk ZCBpdCB0byB0aGUgZGV2aWNlIHRyZWUgdG8KPiA+PiBtYWtlCj4gPj4gaXQgdXNhYmxlLiBUaGUg aTJjMCBidXMgY2FuIHVzZSB0d28gZGlmZmVyZW50IHBpbm11eCBzZXR0aW5ncyB0byB1c2UKPiA+ PiBkaWZmZXJlbnQgcGlucy4gVG8ga2VlcCB0aGUgYnVzIGFwcGVhcmluZyBvbiB0aGUgdXN1YWwg cGluIHBhaXIgKGdwaW8wICsKPiA+PiBncGlvMSkgdXNlIGEgcGluY3RybC1tdXhlZCBzZXR0aW5n IGFzIHRoZSB2ZW5kb3IgZHRzIGRvZXMuCj4gPj4KPiA+PiBOb3RlIHRoYXQgaWYgeW91IG1vZGlm aWVkIHRoZSBkdHMgYmVmb3JlIHRvIGFkZCBkZXZpY2VzIHRvIHRoZSBpMmMgYnVzCj4gPj4gYXBw ZWFyaW5nIG9uIHBpbnMgZ3BpbzAgKyBncGlvMSAoZWl0aGVyIGRpcmVjdGx5IGluIHRoZSBkdHMg b3IgdXNpbmcgYW4KPiA+PiBvdmVybGF5KSwgeW91IGhhdmUgdG8gcHV0IHRoZXNlIGludG8gdGhl IGkyY0AwIG5vZGUgaW50cm9kdWNlZCBoZXJlIG5vdy4KPiA+Pgo+ID4+IFJldmlld2VkLWJ5OiBN YXhpbWUgUmlwYXJkIDxtYXhpbWVAY2Vybm8udGVjaD4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBVd2Ug S2xlaW5lLUvDtm5pZyA8dXdlQGtsZWluZS1rb2VuaWcub3JnPgo+ID4+IC0tLQo+ID4+IEhlbGxv LAo+ID4+Cj4gPj4gY2hhbmdlcyBzaW5jZSB2MiAoMjAyMTEyMTYyMTI5NDgubnJmbW00anBiaG9r bmZyNUBwZW5ndXRyb25peC5kZSk6Cj4gPj4KPiA+PiDCoCAtIGFkZCBNYXhpbWUncyBSLWIgdGFn Cj4gPj4gwqAgLSBjaGFuZ2UgdGhlIGNvbW1pdCBsb2cgd29yZGluZyB0byBzYXkgdmVuZG9yIGR0 cyBpbnN0ZWFkIG9mIHVwc3RyZWFtCj4gPj4gwqDCoMKgIGR0cwo+ID4+IMKgIC0gQWRkIGEgcGFy YWdyYXBoIHRvIHRoZSBjb21taXQgbG9nIGFib3V0IGJyZWFrYWdlIHRoaXMgY29tbWl0cwo+ID4+ IMKgwqDCoCBpbnRyb2R1Y2VzLgo+ID4+Cj4gPj4gQmVzdCByZWdhcmRzCj4gPj4gVXdlCj4gPj4K PiA+PiDCoCBhcmNoL2FybS9ib290L2R0cy9iY20yNzExLXJwaS1jbTQtaW8uZHRzIHwgMzUgKysr KysrKysrKysrKysrKysrKysrKysrCj4gPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlv bnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9iY20yNzExLXJw aS1jbTQtaW8uZHRzCj4gPj4gYi9hcmNoL2FybS9ib290L2R0cy9iY20yNzExLXJwaS1jbTQtaW8u ZHRzCj4gPj4gaW5kZXggMTk2MDBiNjI5YmU1Li41ZGRhZDE0NmI1NDEgMTAwNjQ0Cj4gPj4gLS0t IGEvYXJjaC9hcm0vYm9vdC9kdHMvYmNtMjcxMS1ycGktY200LWlvLmR0cwo+ID4+ICsrKyBiL2Fy Y2gvYXJtL2Jvb3QvZHRzL2JjbTI3MTEtcnBpLWNtNC1pby5kdHMKPiA+PiBAQCAtMTgsNiArMTgs NDEgQEAgbGVkLXB3ciB7Cj4gPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGludXgsZGVm YXVsdC10cmlnZ2VyID0gImRlZmF1bHQtb24iOwo+ID4+IMKgwqDCoMKgwqDCoMKgwqDCoCB9Owo+ ID4+IMKgwqDCoMKgwqAgfTsKPiA+PiArCj4gPj4gK8KgwqDCoCBpMmMwbXV4IHsKPiA+PiArwqDC oMKgwqDCoMKgwqAgY29tcGF0aWJsZSA9ICJpMmMtbXV4LXBpbmN0cmwiOwo+ID4+ICvCoMKgwqDC oMKgwqDCoCAjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+PiArwqDCoMKgwqDCoMKgwqAgI3NpemUt Y2VsbHMgPSA8MD47Cj4gPj4gKwo+ID4+ICvCoMKgwqDCoMKgwqDCoCBpMmMtcGFyZW50ID0gPCZp MmMwPjsKPiA+PiArCj4gPj4gK8KgwqDCoMKgwqDCoMKgIHBpbmN0cmwtbmFtZXMgPSAiaTJjMCIs ICJpMmMwLXZjIjsKPiA+PiArwqDCoMKgwqDCoMKgwqAgcGluY3RybC0wID0gPCZpMmMwX2dwaW8w PjsKPiA+PiArwqDCoMKgwqDCoMKgwqAgcGluY3RybC0xID0gPCZpMmMwX2dwaW80ND47Cj4gPj4g Kwo+ID4+ICvCoMKgwqDCoMKgwqDCoCBpMmNAMCB7Cj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqAgcmVnID0gPDA+Owo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICNhZGRyZXNzLWNlbGxz ID0gPDE+Owo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICNzaXplLWNlbGxzID0gPDA+Owo+ ID4+ICvCoMKgwqDCoMKgwqDCoCB9Owo+ID4+ICsKPiA+PiArwqDCoMKgwqDCoMKgwqAgaTJjQDEg ewo+ID4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJlZyA9IDwxPjsKPiA+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAjc2l6ZS1jZWxscyA9IDwwPjsKPiA+PiArCj4gPj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgcnRjQDUxIHsKPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC8qIEF0 dGVudGlvbjogQW4gYWxhcm0gcmVzZXRzIHRoZSBtYWNoaW5lICovCj4gPj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBjb21wYXRpYmxlID0gIm54cCxwY2Y4NTA2MyI7Cj4gPj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZWcgPSA8MHg1MT47Cj4gPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgfTsKPiA+PiArwqDCoMKgwqDCoMKgwqAgfTsKPiA+PiArwqDCoMKgIH07 Cj4gPj4gK307Cj4gPiAKPiA+IFRoaXMgaXMgYWxzbyBuZWVkZWQgZm9yIGNhbWVyYSBhbmQgZGlz cGxheSBzdXBwb3J0Lgo+ID4gSSB0ZXN0ZWQgaXQgc3VjY2Vzc2Z1bGx5IHdpdGggaW14MjE5ICsg dW5pY2FtIG9uIG1haW5saW5lLgo+IAo+IFRoYW5rcyBmb3IgdGVzdGluZywgY2FuIHlvdSByZXBs eSB3aXRoIGEgVGVzdGVkLWJ5IHRhZyBzbyBpdCBjb3VsZCBiZQo+IGFwcGxpZWQgdG8gdGhlIGNv bW1pdCBtZXNzYWdlIHdoZW4gdGhpcyBnZXRzIHBpY2tlZCB1cD8KCldlbGwsIHRoaXMgYWxzbyBw b2ludHMgb3V0IHRoYXQgdGhlcmUncyBhbiBpc3N1ZTogaWYgdGhlIG11eCBpcyBuZWVkZWQKZm9y IG90aGVyIGRldmljZXMsIGl0IHNob3VsZG4ndCBiZSBpbiBiY20yNzExLXJwaS1jbTQtaW8uZHRz IDotKSBXZQpjb3VsZCBtb3ZlIGl0IHRvIGJjbTI3MTEtcnBpLmR0c2kgKHNvIGZhciBhbGwgYmNt MjcxMS1iYXNlZCBib2FyZHMgdXNlCmVpdGhlciBJL08gcGlucyAwKzEgb3IgNDQrNDUpLCBvciBt b3ZlIGl0IHRvIHBlci1ib2FyZCBmaWxlcy4gSW4gdGhlCmxhdHRlciBjYXNlLCBpbnN0ZWFkIG9m IGR1cGxpY2F0aW5nIHRoZSBzYW1lIGJsb2NrIGV2ZXJ5d2hlcmUsIGl0IGNvdWxkCmJlIG1vdmVk IHRvIGEgLmR0c2kgaW5jbHVkZWQgaW4gdGhvc2UgYm9hcmQgZmlsZXMuIFRoaXMgaXMgd2hhdCB0 aGUKZG93bnN0cmVhbSBrZXJuZWwgZG9lcy4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFy dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A2DC433F5 for ; Tue, 18 Jan 2022 20:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237622AbiARUsK (ORCPT ); Tue, 18 Jan 2022 15:48:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233264AbiARUsJ (ORCPT ); Tue, 18 Jan 2022 15:48:09 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1A5AC061574 for ; Tue, 18 Jan 2022 12:48:09 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AAF5A14C3; Tue, 18 Jan 2022 21:48:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642538887; bh=PiLgNaz1zZmzJhD5V79Sl741bXKE9AAuqWKWE1i4D78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bp3SGAX4t0+qm8zzxPxJ7gZ02CZCDEzE/hofaRHApDTHVj+eke//sRwgD76r/i2Fi GkvaMB+6zE6To1L965c/5QPjWF27RS15CSEaQRTWwpH57dzRlZPRmxX6OYl/iqUj7k Kbplfpa07WsujVY70Kw+ztofAZ3oMz4fcc3dGsTU= Date: Tue, 18 Jan 2022 22:47:53 +0200 From: Laurent Pinchart To: Florian Fainelli Cc: Jean-Michel Hautbois , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson , Maxime Ripard Subject: Re: [PATCH v3] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: References: <20211231115109.94626-1-uwe@kleine-koenig.org> <2540edbe-084e-802f-3533-0aa66ddc20ec@ideasonboard.com> <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Florian, On Tue, Jan 18, 2022 at 12:00:50PM -0800, Florian Fainelli wrote: > On 1/18/22 11:45 AM, Jean-Michel Hautbois wrote: > > On 31/12/2021 12:51, Uwe Kleine-König wrote: > >> The cm4-io board comes with an PCF85063. Add it to the device tree to > >> make > >> it usable. The i2c0 bus can use two different pinmux settings to use > >> different pins. To keep the bus appearing on the usual pin pair (gpio0 + > >> gpio1) use a pinctrl-muxed setting as the vendor dts does. > >> > >> Note that if you modified the dts before to add devices to the i2c bus > >> appearing on pins gpio0 + gpio1 (either directly in the dts or using an > >> overlay), you have to put these into the i2c@0 node introduced here now. > >> > >> Reviewed-by: Maxime Ripard > >> Signed-off-by: Uwe Kleine-König > >> --- > >> Hello, > >> > >> changes since v2 (20211216212948.nrfmm4jpbhoknfr5@pengutronix.de): > >> > >>   - add Maxime's R-b tag > >>   - change the commit log wording to say vendor dts instead of upstream > >>     dts > >>   - Add a paragraph to the commit log about breakage this commits > >>     introduces. > >> > >> Best regards > >> Uwe > >> > >>   arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts | 35 ++++++++++++++++++++++++ > >>   1 file changed, 35 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > >> b/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > >> index 19600b629be5..5ddad146b541 100644 > >> --- a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > >> +++ b/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > >> @@ -18,6 +18,41 @@ led-pwr { > >>               linux,default-trigger = "default-on"; > >>           }; > >>       }; > >> + > >> +    i2c0mux { > >> +        compatible = "i2c-mux-pinctrl"; > >> +        #address-cells = <1>; > >> +        #size-cells = <0>; > >> + > >> +        i2c-parent = <&i2c0>; > >> + > >> +        pinctrl-names = "i2c0", "i2c0-vc"; > >> +        pinctrl-0 = <&i2c0_gpio0>; > >> +        pinctrl-1 = <&i2c0_gpio44>; > >> + > >> +        i2c@0 { > >> +            reg = <0>; > >> +            #address-cells = <1>; > >> +            #size-cells = <0>; > >> +        }; > >> + > >> +        i2c@1 { > >> +            reg = <1>; > >> +            #address-cells = <1>; > >> +            #size-cells = <0>; > >> + > >> +            rtc@51 { > >> +                /* Attention: An alarm resets the machine */ > >> +                compatible = "nxp,pcf85063"; > >> +                reg = <0x51>; > >> +            }; > >> +        }; > >> +    }; > >> +}; > > > > This is also needed for camera and display support. > > I tested it successfully with imx219 + unicam on mainline. > > Thanks for testing, can you reply with a Tested-by tag so it could be > applied to the commit message when this gets picked up? Well, this also points out that there's an issue: if the mux is needed for other devices, it shouldn't be in bcm2711-rpi-cm4-io.dts :-) We could move it to bcm2711-rpi.dtsi (so far all bcm2711-based boards use either I/O pins 0+1 or 44+45), or move it to per-board files. In the latter case, instead of duplicating the same block everywhere, it could be moved to a .dtsi included in those board files. This is what the downstream kernel does. -- Regards, Laurent Pinchart