From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Rewrite statx04 test
Date: Wed, 19 Jan 2022 12:45:47 +0100 [thread overview]
Message-ID: <Yef56y6oyGepGfpO@pevik> (raw)
In-Reply-To: <0bd9af6b-9750-134a-8740-8017103ca4ee@suse.cz>
> On 19. 01. 22 12:23, Petr Vorel wrote:
> > Hi Martin,
> >> ...
> > I'd put this into commit message (can be done during merge).
> Sure.
> >> + for (i = 0, expected_mask = 0; i < ARRAY_SIZE(attr_list); i++)
> > Before merge we should cast to prevent "comparison of integer expressions of
> > different signedness" warning:
> > for (i = 0, expected_mask = 0; i < (int)ARRAY_SIZE(attr_list); i++)
> It's better to fix that by changing the type of "i" to size_t or
+1
> unsigned int. But GCC could easily deduce that one of the values is a
> constant well within the range of signed int and not bother us with the
> warning...
Agree :).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-19 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 11:15 [LTP] [PATCH v2] Rewrite statx04 test Martin Doucha
2022-01-19 11:23 ` Petr Vorel
2022-01-19 11:28 ` Martin Doucha
2022-01-19 11:45 ` Petr Vorel [this message]
2022-01-19 15:52 ` Cyril Hrubis
2022-01-20 7:18 ` Li Wang
2022-01-20 7:30 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yef56y6oyGepGfpO@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.