Re: [PATCH v2 1/1] net/tap: add a check that Rx/Tx have the same num of queues

[Nobuhiro MIKI <nmiki@yahoo-corp.jp>]

On Tue, Jan 18, 2022 at 12:31:51PM +0000, Ferruh Yigit wrote:
> On 1/12/2022 7:23 AM, Nobuhiro MIKI wrote:
> > Users can create the desired number of RxQ and TxQ in DPDK. For
> > example, if the number of RxQ = 2 and the number of TxQ = 5,
> > a total of 8 file descriptors will be created for a tap device,
> > including RxQ, TxQ, and one for keepalive. The RxQ and TxQ
> > with the same ID are paired by dup(2).
> > 
> > In this scenario, Kernel will have 3 RxQ where packets are
> > incoming but not read. The reason for this is that there are only
> > 2 RxQ that are polled by DPDK, while there are 5 queues in Kernel.
> > This patch add a checking if DPDK has appropriate numbers of
> > queues to avoid unexpected packet drop.
> > 
> > Signed-off-by: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
> 
> 
> It makes sense to add this check, since the driver logic seem already has
> the assumption that Rx & Tx queue numbers will be same.
> 
> But can you please update the tap documentation for this limitation/restriction?
> 'doc/guides/nics/tap.rst'.

Thanks for the review.
I've updated doc/guides/nics/tap.rst and sent v3 patch.