From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] Rewrite statx04 test
Date: Wed, 19 Jan 2022 11:55:33 +0100 [thread overview]
Message-ID: <YefuJcfsDpuYeQ3X@pevik> (raw)
In-Reply-To: <20220118170243.22496-1-mdoucha@suse.cz>
Hi Martin,
> statx04 is supposed verify that inode attribute support in statx() matches
> what should actually be implemented. However, we already have functional tests
> for this in statx08 and lack a test of the stx_attribute_mask field which
> reports inode attribute support to userspace.
> Rewrite the test to drop the duplicate code and add the missing coverage.
LGTM, thanks! BTW you'd deserve your (or SUSE) copyright for this change :).
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> * xfs filesystem doesn't support STATX_ATTR_COMPRESSED flag, so we only test
> * three other flags.
I'd maybe add "known-fail" for xfs, as user hit this when running -s.
Maybe document like this also btrfs.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-19 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 17:02 [LTP] [PATCH] Rewrite statx04 test Martin Doucha
2022-01-19 10:55 ` Petr Vorel [this message]
2022-01-19 11:04 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YefuJcfsDpuYeQ3X@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.