From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFAECC4332F for ; Thu, 20 Jan 2022 07:16:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E647730DB; Thu, 20 Jan 2022 08:15:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E647730DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642662987; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=SMBoNmN5AlnUBGbLRjJ+UqXdP5hADnadrMXUeN1ar9Sr2oRJPujOTr9BBrX5cqjzz CO64EB7YHmUZZNM+v8EZqIsT9BHgH5CHxZ+LsnP5SMVdp5GiTutiyHSDQIp19WX8kb pp8Pq5FNJZTq2nfcY5UwDQRVtwANUIOas2rmr6mA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 222B7F80612; Thu, 20 Jan 2022 08:04:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 330CCF801F7; Wed, 19 Jan 2022 20:20:45 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 25A41F80100 for ; Wed, 19 Jan 2022 20:20:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 25A41F80100 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lADTRv+c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642620043; x=1674156043; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=lADTRv+cQZZn5h5L2yVGIqkgr6FSsQkShz2X1QYLAdAqAMfE4rTfT+q/ pgNN2KeW9xgAv0xZEeiW1PphTJR50Qu+Tv8rEGNNR/xru4xwdF3eP2sUG 25srJEetSWq/3Pfu+S5cfaEUnHz8EAEBiTWSJeFrxGNdm0Q7oJlTkTtL2 msUhqAMOu40xuaKM6txZs7BlWubduu2IhmE0G2dZ8jlwHqFEMpFEUxWxW NkwBXTyAmZhpu+MI+EA9hlPlDvrS7csgik38beHCvLkMLqOFyLXre9Q5z YNvYyHMNm+HHB8XMfdIsBbNd+Z+8PuA7FxzwPZoyNOCiPDmLo+91hz/QJ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225144330" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="225144330" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailman-Approved-At: Thu, 20 Jan 2022 08:03:35 +0100 Cc: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , "open list:GPIO SUBSYSTEM" , Miquel Raynal , linux-phy@lists.infradead.org, netdev@vger.kernel.org, linux-spi , Jiri Slaby , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , bcm-kernel-feedback-list , Zhang Rui , platform-driver-x86@vger.kernel.org, Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , John Garry , Takashi Iwai , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Mark Brown , Borislav Petkov , Jakub Kicinski , Matthias Brugger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , Pengutronix Kernel Team , Linux ARM , linux-edac@vger.kernel.org, Tony Luck , Richard Weinberger , Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , Yoshihiro Shimoda , Cornelia Huck , Linux MMC List , Joakim Zhang , Linux Kernel Mailing List , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-König wrote: > > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > > Hm... I'm afraid that with this #define they would never get fixed... :-) Agree. The problems I have listed in another reply should be fixed at once by the same series. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 739BAC433F5 for ; Wed, 19 Jan 2022 19:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238948AbiASTS1 (ORCPT ); Wed, 19 Jan 2022 14:18:27 -0500 Received: from mga01.intel.com ([192.55.52.88]:38080 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbiASTS1 (ORCPT ); Wed, 19 Jan 2022 14:18:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619906; x=1674155906; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=jAA0eUdJ2LIrYzRKlLUNuqbIEXZQ58QHs42RuYwZZHobRIia1r4dtoes aEyZ/j1WZPaDU8cQlTzfRUaon6w0vJ3TezEJ11da6zlxu6tvEfzXUoTq5 R0meXV8NOWY8dfEzDBb2+TXswnx8BNUdOJEdyG9IO+hM91Wd4B8DNpEBh dxzrbZFFrZi5mrLmR8f1IuoxhYb9FK5zlF2UaC0CNcvwZxta4cRaBZf9B jp4YmdWs2YG1GzVZr7sbonMZOUg5xbnj+If+oNNnbTp/gwl8HlALyj+Et RbwYCy7F0PJrOzZ8Kvg92QlxVDVY9PO94sTCTlxST29tb2VumCDK7pCHM Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269556994" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269556994" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , Miquel Raynal , linux-phy@lists.infradead.org, Jiri Slaby , openipmi-developer@lists.sourceforge.net, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Yoshihiro Shimoda , bcm-kernel-feedback-list , Zhang Rui , Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Tony Luck , Borislav Petkov , Sebastian Reichel , Jakub Kicinski , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , Linux ARM , linux-edac@vger.kernel.org, Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Cornelia Huck , Linux MMC List , Linux Kernel Mailing List , linux-spi , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-König wrote: > > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > > Hm... I'm afraid that with this #define they would never get fixed... :-) Agree. The problems I have listed in another reply should be fixed at once by the same series. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0CFDC433EF for ; Wed, 19 Jan 2022 19:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uAdevrZAU3mQQ+rShO/neXPP2v3a2JG4f6X7LP1y8nw=; b=3w7C6Nfn4L/+i0 BXsDSa3puYJ4uVvK44S+U3zXruCcbnVK5Bz3rfRrRYaHgKYYsdIMWgWqM209BPNeMMSg+Oorq+opS rnLQprgaArszOuBNkMqZys+IGb9KzY6awxghQK64CO8rxzblZ4vWzSCyxrrlMKTZWaKyleQVpw+Ht zxuTzryCM6toyTFB6HcOrg+9+al9oVT+Tb5rGO636hEqku0Wd8HKdwMyJnMxX07yEDDm3PpLMfzhJ 1rWjLaaZcoWL3Saov/r/JkWYoeSlXuaKpL+xEmBFbxXnP0SD3ZJ89evJZ8oGRDehf9PpzjTlIIGWa w/rlr4H63B8Y3hnvkmGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTU-006zqD-EI; Wed, 19 Jan 2022 19:18:28 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTR-006zoG-RS; Wed, 19 Jan 2022 19:18:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619905; x=1674155905; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=NfvhPhZgrtFp890V0t/2jXId82C5EwBbbMwDWDQ+eZJIrirl4TdpDn+v 7kYqFhPJdylWbtFAKZ+v5UTG2CUGIiGp/UaWPYLd8nhdjoWJfBVyHmqKl 9p9d8Dh8p5t3c3tiG6LULiTJUKcmBkSUPsasajBQNt9dIaHyYA+0b952s AsxvyeLi+aqfJ5joxQS/1Rxj3pxBhUHAcDAkJuFcXf6wr2YgQxtGDWaYE UX0WlzYLjcY/XQF0+gYL6xcJ6kap7099PSQk5+Wc3qNKOnW8hGsTgcXX1 ZQhzIYK2PsPXhaWD+oCUa8arFMEL2QDJUBSe944y2fUHeTkzmIKS+L9e4 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269556995" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269556995" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , Miquel Raynal , linux-phy@lists.infradead.org, Jiri Slaby , openipmi-developer@lists.sourceforge.net, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Yoshihiro Shimoda , bcm-kernel-feedback-list , Zhang Rui , Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Tony Luck , Borislav Petkov , Sebastian Reichel , Jakub Kicinski , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , Linux ARM , linux-edac@vger.kernel.org, Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Cornelia Huck , Linux MMC List , Linux Kernel Mailing List , linux-spi , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_111825_976796_ABA2B4BD X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-K=F6nig wrote: > = > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > = > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > = > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > = > Hm... I'm afraid that with this #define they would never get fixed... = :-) Agree. The problems I have listed in another reply should be fixed at once = by the same series. -- = With Best Regards, Andy Shevchenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA016C433EF for ; Wed, 19 Jan 2022 19:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LiNrO/z+chtugA/wq9YyS+opJozYeXIX9/E8LWDkzyU=; b=qj+4IFDMd9iQjp mdkkEnDNhNcK05r2ItosRQnLVWSjy8ZVO4cSmt6HcZUt2DNUchkNGVDQM4Nx6d6X6G208ZOctZ8MA hVs59tzoKCHvoqhWzDWCjB3rXReqwh7oZRpj6ExqjX4H6/5wfsbJQW2kexjshEsAn3L1gavUJqrld AfHXnbDbAbcvtTtt29/CvkAeHdWleRKx2SSlXyh+lxVBm9jfbIvojlCHt4CNgmTtJqirdP99lqwKm eof1/gzU0oE7DoOtIFcqPkr+Vfz64lMwqG6+7dpN659WCAxIoudrGieoNOBKbQUS2E4FByD0iaKJn lkQbcX0RojyBhuZ2/P0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTW-006zr6-RN; Wed, 19 Jan 2022 19:18:31 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTR-006zoG-RS; Wed, 19 Jan 2022 19:18:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619905; x=1674155905; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=NfvhPhZgrtFp890V0t/2jXId82C5EwBbbMwDWDQ+eZJIrirl4TdpDn+v 7kYqFhPJdylWbtFAKZ+v5UTG2CUGIiGp/UaWPYLd8nhdjoWJfBVyHmqKl 9p9d8Dh8p5t3c3tiG6LULiTJUKcmBkSUPsasajBQNt9dIaHyYA+0b952s AsxvyeLi+aqfJ5joxQS/1Rxj3pxBhUHAcDAkJuFcXf6wr2YgQxtGDWaYE UX0WlzYLjcY/XQF0+gYL6xcJ6kap7099PSQk5+Wc3qNKOnW8hGsTgcXX1 ZQhzIYK2PsPXhaWD+oCUa8arFMEL2QDJUBSe944y2fUHeTkzmIKS+L9e4 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269556995" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269556995" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , Miquel Raynal , linux-phy@lists.infradead.org, Jiri Slaby , openipmi-developer@lists.sourceforge.net, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Yoshihiro Shimoda , bcm-kernel-feedback-list , Zhang Rui , Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Tony Luck , Borislav Petkov , Sebastian Reichel , Jakub Kicinski , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , Linux ARM , linux-edac@vger.kernel.org, Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Cornelia Huck , Linux MMC List , Linux Kernel Mailing List , linux-spi , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_111825_976796_ABA2B4BD X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-K=F6nig wrote: > = > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > = > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > = > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > = > Hm... I'm afraid that with this #define they would never get fixed... = :-) Agree. The problems I have listed in another reply should be fixed at once = by the same series. -- = With Best Regards, Andy Shevchenko ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEFE2C43217 for ; Wed, 19 Jan 2022 19:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ym1J2y+YSxucJIQumxXpwUptzyycXF/si27ke6u3p9g=; b=AJQZApl4wlTWb9 RVAgppLY7xj9oSY3MT0t5HM8z/+ONTeP5mq4+9aAQd0CS6McYbCyr0X9A23mKCaxz9WXRhjwIljRB nWrDieC3S+2cyq+rFPfSLVhw9ciBwan1WQCeM6/Ixqy/vXSMDf5smbDRlZ4wQFEFoqWc4zk6uJs2o kUfXQpPDultD7YPSnt66KpvLBeuShAZZimQVY+IOqiba3gRq4EJ1wYWZfO+Cv/1PWy3RwhOpgHAjO c6u0nNZRQSQj/tNBN6CK6sqBVZOMFHI+CLt+5UbZ+5WyWPOS0wPBjAf0qFENyVeHb6l08vNG3fhuK kQPOqt72y5DVlyge/XqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTU-006zq3-6l; Wed, 19 Jan 2022 19:18:28 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAGTR-006zoG-RS; Wed, 19 Jan 2022 19:18:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642619905; x=1674155905; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zlzvt2tofvnyzs6MO7mvQPsbaGbCXyngZOE6fETrI9A=; b=NfvhPhZgrtFp890V0t/2jXId82C5EwBbbMwDWDQ+eZJIrirl4TdpDn+v 7kYqFhPJdylWbtFAKZ+v5UTG2CUGIiGp/UaWPYLd8nhdjoWJfBVyHmqKl 9p9d8Dh8p5t3c3tiG6LULiTJUKcmBkSUPsasajBQNt9dIaHyYA+0b952s AsxvyeLi+aqfJ5joxQS/1Rxj3pxBhUHAcDAkJuFcXf6wr2YgQxtGDWaYE UX0WlzYLjcY/XQF0+gYL6xcJ6kap7099PSQk5+Wc3qNKOnW8hGsTgcXX1 ZQhzIYK2PsPXhaWD+oCUa8arFMEL2QDJUBSe944y2fUHeTkzmIKS+L9e4 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269556995" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269556995" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:58 -0800 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="672273896" Received: from smile.fi.intel.com ([10.237.72.61]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 10:53:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nAG4L-00CE4x-6e; Wed, 19 Jan 2022 20:52:29 +0200 Date: Wed, 19 Jan 2022 20:52:28 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , KVM list , "Rafael J. Wysocki" , linux-iio@vger.kernel.org, Linus Walleij , Amit Kucheria , ALSA Development Mailing List , Jaroslav Kysela , Guenter Roeck , Thierry Reding , MTD Maling List , Linux I2C , Miquel Raynal , linux-phy@lists.infradead.org, Jiri Slaby , openipmi-developer@lists.sourceforge.net, "David S. Miller" , Khuong Dinh , Florian Fainelli , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Lee Jones , Bartosz Golaszewski , Daniel Lezcano , Kishon Vijay Abraham I , Geert Uytterhoeven , "open list:SERIAL DRIVERS" , Yoshihiro Shimoda , bcm-kernel-feedback-list , Zhang Rui , Linux PWM List , Robert Richter , Saravanan Sekar , Corey Minyard , Linux PM list , Liam Girdwood , Mauro Carvalho Chehab , John Garry , Peter Korsgaard , William Breathitt Gray , Mark Gross , Hans de Goede , Alex Williamson , Tony Luck , Borislav Petkov , Sebastian Reichel , Jakub Kicinski , Matthias Brugger , Takashi Iwai , platform-driver-x86@vger.kernel.org, Benson Leung , Linux ARM , linux-edac@vger.kernel.org, Mun Yew Tham , Eric Auger , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Cornelia Huck , Linux MMC List , Linux Kernel Mailing List , linux-spi , Linux-Renesas , Vinod Koul , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-mediatek@lists.infradead.org, Brian Norris , netdev@vger.kernel.org Subject: Re: [PATCH] driver core: platform: Rename platform_get_irq_optional() to platform_get_irq_silent() Message-ID: References: <20220112085009.dbasceh3obfok5dc@pengutronix.de> <20220112213121.5ruae5mxwj6t3qiy@pengutronix.de> <20220113110831.wvwbm75hbfysbn2d@pengutronix.de> <20220113194358.xnnbhsoyetihterb@pengutronix.de> <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <386a7f56-38c8-229c-4fec-4b38a77c4121@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220119_111825_976796_ABA2B4BD X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jan 14, 2022 at 10:45:38PM +0300, Sergey Shtylyov wrote: > On 1/13/22 10:43 PM, Uwe Kleine-K=F6nig wrote: > = > > The subsystems regulator, clk and gpio have the concept of a dummy > > resource. For regulator, clk and gpio there is a semantic difference > > between the regular _get() function and the _get_optional() variant. > > (One might return the dummy resource, the other won't. Unfortunately > > which one implements which isn't the same for these three.) The > > difference between platform_get_irq() and platform_get_irq_optional() is > > only that the former might emit an error message and the later won't. > > = > > To prevent people's expectations that there is a semantic difference > > between these too, rename platform_get_irq_optional() to > > platform_get_irq_silent() to make the actual difference more obvious. > > = > > The #define for the old name can and should be removed once all patches > > currently in flux still relying on platform_get_irq_optional() are > > fixed. > = > Hm... I'm afraid that with this #define they would never get fixed... = :-) Agree. The problems I have listed in another reply should be fixed at once = by the same series. -- = With Best Regards, Andy Shevchenko -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy