From: "Hongren (Zenithal) Zheng" <i@zenithal.me>
To: Thomas Huth <thuth@redhat.com>
Cc: contact@canokeys.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples
Date: Thu, 20 Jan 2022 10:40:18 +0800 [thread overview]
Message-ID: <YejLkkImI0LunIxM@Sun> (raw)
In-Reply-To: <9d866ab9-ccfc-5bbd-004e-9ffbf8f14836@redhat.com>
On Tue, Jan 18, 2022 at 10:28:49AM +0100, Thomas Huth wrote:
> On 13/01/2022 19.11, Hongren (Zenithal) Zheng wrote:
> > Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> > ---
> > docs/system/devices/usb.rst | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst
> > index afb7d6c226..341694403a 100644
> > --- a/docs/system/devices/usb.rst
> > +++ b/docs/system/devices/usb.rst
> > @@ -199,6 +199,9 @@ option or the ``device_add`` monitor command. Available devices are:
> > ``u2f-{emulated,passthru}``
> > Universal Second Factor device
> > +``canokey``
> > + An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Just an additional idea: It might be helpful for the users if you put a link
> to the separate documentation from the previous patch here?
Will be added in the next version.
>
> Thomas
>
next prev parent reply other threads:[~2022-01-20 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 18:08 [PATCH v3 0/6] Introduce CanoKey QEMU Hongren (Zenithal) Zheng
2022-01-13 18:10 ` [PATCH v3 1/6] hw/usb: Add CanoKey Implementation Hongren (Zenithal) Zheng
2022-01-13 18:10 ` [PATCH v3 2/6] hw/usb/canokey: Add trace events Hongren (Zenithal) Zheng
2022-01-13 18:11 ` [PATCH v3 3/6] meson: Add CanoKey Hongren (Zenithal) Zheng
2022-01-13 18:11 ` [PATCH v3 4/6] docs: Add CanoKey documentation Hongren (Zenithal) Zheng
2022-01-13 18:11 ` [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples Hongren (Zenithal) Zheng
2022-01-18 9:28 ` Thomas Huth
2022-01-20 2:40 ` Hongren (Zenithal) Zheng [this message]
2022-01-13 18:12 ` [PATCH v3 6/6] MAINTAINERS: add myself as CanoKey maintainer Hongren (Zenithal) Zheng
2022-01-14 7:23 ` Hongren (Zenithal) Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YejLkkImI0LunIxM@Sun \
--to=i@zenithal.me \
--cc=contact@canokeys.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.