From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <balbi@kernel.org>,
devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Peter Chen <peter.chen@kernel.org>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Roger Quadros <rogerq@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v20 2/5] driver core: Export device_is_bound()
Date: Thu, 20 Jan 2022 16:36:48 +0100 [thread overview]
Message-ID: <YemBkNhvfPukCB6C@kroah.com> (raw)
In-Reply-To: <Yel+0DrtWm5I9JrL@google.com>
On Thu, Jan 20, 2022 at 07:25:04AM -0800, Matthias Kaehlcke wrote:
> On Thu, Jan 20, 2022 at 08:45:24AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 19, 2022 at 11:29:18PM -0800, Christoph Hellwig wrote:
> > > On Wed, Jan 19, 2022 at 12:43:42PM -0800, Matthias Kaehlcke wrote:
> > > > Export device_is_bound() to enable its use by drivers that are
> > > > built as modules.
> > > >
> > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > >
> > > Didn't Greg clearly NAK this the last few times it came up?
> >
> > Yes, which is why this series is _WAY_ on the bottom of my list for
> > reviews...
>
> I wasn't aware of that prior discussion, it would have helped to know
> that this is a major concern for you ...
Sorry, that was on a different thread for a different feature, I thought
it was this one. Too many reviews at times.
>
> If using device_is_bound() is a no-go then _find_onboard_hub() of
> the onboard_hub driver could make it's decision based on the
> presence (or absence) of drvdata, which is what the function ultimately
> returns.
That suffers from the same problem. I'll take a look at this later
after -rc1 is out and see what can be done here...
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-20 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 20:43 [PATCH v20 0/5] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2022-01-19 20:43 ` [PATCH v20 1/5] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2022-01-19 20:43 ` [PATCH v20 2/5] driver core: Export device_is_bound() Matthias Kaehlcke
2022-01-20 7:29 ` Christoph Hellwig
2022-01-20 7:45 ` Greg Kroah-Hartman
2022-01-20 15:25 ` Matthias Kaehlcke
2022-01-20 15:36 ` Greg Kroah-Hartman [this message]
2022-02-08 0:38 ` Doug Anderson
2022-01-19 20:43 ` [PATCH v20 3/5] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2022-02-08 10:47 ` Greg Kroah-Hartman
2022-02-08 10:56 ` Greg Kroah-Hartman
2022-02-08 19:17 ` Matthias Kaehlcke
2022-02-15 18:02 ` Doug Anderson
2022-01-19 20:43 ` [PATCH v20 4/5] usb: core: hcd: Create platform devices for onboard hubs in probe() Matthias Kaehlcke
2022-01-19 20:43 ` [PATCH v20 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2022-02-08 10:57 ` Greg Kroah-Hartman
2022-02-08 19:21 ` Matthias Kaehlcke
2022-02-15 17:54 ` Doug Anderson
2022-02-15 18:55 ` Greg Kroah-Hartman
2022-02-15 19:03 ` Doug Anderson
2022-02-16 7:36 ` Krzysztof Kozlowski
2022-02-16 19:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YemBkNhvfPukCB6C@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=hadess@hadess.net \
--cc=hch@infradead.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=mka@chromium.org \
--cc=peter.chen@kernel.org \
--cc=rafael@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.