From: Johannes Weiner <hannes@cmpxchg.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: peterz@infradead.org, mingo@redhat.com, ebiggers@kernel.org,
tj@kernel.org, willy@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] psi: Fix "defined but not used" warnings when CONFIG_PROC_FS=n
Date: Thu, 20 Jan 2022 10:54:50 -0500 [thread overview]
Message-ID: <YemFypC3TKwpuUvm@cmpxchg.org> (raw)
In-Reply-To: <20220119223940.787748-3-surenb@google.com>
On Wed, Jan 19, 2022 at 02:39:40PM -0800, Suren Baghdasaryan wrote:
> When CONFIG_PROC_FS is disabled psi code generates the following warnings:
>
> kernel/sched/psi.c:1364:30: warning: 'psi_cpu_proc_ops' defined but not used [-Wunused-const-variable=]
> 1364 | static const struct proc_ops psi_cpu_proc_ops = {
> | ^~~~~~~~~~~~~~~~
> kernel/sched/psi.c:1355:30: warning: 'psi_memory_proc_ops' defined but not used [-Wunused-const-variable=]
> 1355 | static const struct proc_ops psi_memory_proc_ops = {
> | ^~~~~~~~~~~~~~~~~~~
> kernel/sched/psi.c:1346:30: warning: 'psi_io_proc_ops' defined but not used [-Wunused-const-variable=]
> 1346 | static const struct proc_ops psi_io_proc_ops = {
> | ^~~~~~~~~~~~~~~
>
> Make definitions of these structures and related functions conditional on
> CONFIG_PROC_FS config.
>
> Fixes: 0e94682b73bf ("psi: introduce psi monitor")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2022-01-20 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 22:39 [PATCH 0/2] Fix warnings in psi Suren Baghdasaryan
2022-01-19 22:39 ` [PATCH 1/2] psi: Fix "no previous prototype" warnings when CONFIG_CGROUPS=n Suren Baghdasaryan
2022-01-20 15:53 ` Johannes Weiner
2022-01-28 7:40 ` [tip: sched/core] " tip-bot2 for Suren Baghdasaryan
2022-01-19 22:39 ` [PATCH 2/2] psi: Fix "defined but not used" warnings when CONFIG_PROC_FS=n Suren Baghdasaryan
2022-01-20 15:54 ` Johannes Weiner [this message]
2022-01-28 7:40 ` [tip: sched/core] " tip-bot2 for Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YemFypC3TKwpuUvm@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ebiggers@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.