From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B108C433EF for ; Thu, 20 Jan 2022 22:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243835AbiATWiT (ORCPT ); Thu, 20 Jan 2022 17:38:19 -0500 Received: from mail-oi1-f170.google.com ([209.85.167.170]:36467 "EHLO mail-oi1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233963AbiATWiS (ORCPT ); Thu, 20 Jan 2022 17:38:18 -0500 Received: by mail-oi1-f170.google.com with SMTP id r138so11101637oie.3; Thu, 20 Jan 2022 14:38:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JdY5i/vcjbMJ0CM6vrTsc2SV9D4UAPr/paJ/LZ4quKU=; b=hGgdyJa1yMHhTz5S6JTDzJO6IEnMFP9U3/5udsMm3SSqOkWl7zB7VWTI7NoDg8k6eP RPoNksF25A9SqHzcAwDOLe4j9ZwXgqP9gcq8yAqTL3XAd4SC52LW/L6V6VBrZ1ZXK848 4S6ljmX+DhZHldmPXsMkf3RebrbVDHsRlMvrjVB2TC3k9R8txBWhlvxa4kv9FEI7qFym 51vgf04+Lq2gmu7ge/xxf0pAX5z/9MQwLolS7O+j4GSfXIUjp7xhH/3Mu3DcxDA3WD+7 XOfBQPPZpMO2d6E+zKNQS7xYerzoOwWd1V7I87hh/zdC1p87NrckSc09XTpTZc/t8bNl sz3w== X-Gm-Message-State: AOAM5324G+LR8MnOOGfeTSz1imkB1o8Ce9xedQ+7r/K+yt7CVQHsx/KB h2aEBVWOyGpoXMr1hregKQ== X-Google-Smtp-Source: ABdhPJyl7JvGUpPUz9KEz1EogbtYVo2DcE2eLMLcKFmUHz9O/XaZ0ejP62Kqpwa0ZPL4skeK9sz7OQ== X-Received: by 2002:a05:6808:1a23:: with SMTP id bk35mr9736209oib.52.1642718297796; Thu, 20 Jan 2022 14:38:17 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o12sm235957ooi.18.2022.01.20.14.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 14:38:17 -0800 (PST) Received: (nullmailer pid 2067772 invoked by uid 1000); Thu, 20 Jan 2022 22:38:15 -0000 Date: Thu, 20 Jan 2022 16:38:15 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Lee Jones , Benson Leung , Guenter Roeck , Andi Shyti , Mark Brown , Sam Protsenko , Pratyush Yadav , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, Alim Akhtar Subject: Re: [PATCH v5 3/4] mfd: dt-bindings: google,cros-ec: reference Samsung SPI bindings Message-ID: References: <20220120175747.43403-1-krzysztof.kozlowski@canonical.com> <20220120175747.43403-4-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220120175747.43403-4-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Jan 20, 2022 at 06:57:46PM +0100, Krzysztof Kozlowski wrote: > The ChromeOS Embedded Controller appears on boards with Samsung Exynos > SoC, where Exynos SPI bindings expect controller-data node. Reference > newly added dtschema for this property. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/mfd/google,cros-ec.yaml | 29 ++++++++++--------- > 1 file changed, 16 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 58a1a9405228..66a995bbbbe9 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -31,7 +31,7 @@ properties: > > controller-data: > description: > - SPI controller data, see bindings/spi/spi-samsung.txt > + SPI controller data, see bindings/spi/samsung,spi-peripheral-props.yaml > type: object We should be able to drop all of this if unevaluatedProperties is used. > > google,cros-ec-spi-pre-delay: > @@ -148,18 +148,21 @@ patternProperties: > required: > - compatible > > -if: > - properties: > - compatible: > - contains: > - enum: > - - google,cros-ec-i2c > - - google,cros-ec-rpmsg > -then: > - properties: > - google,cros-ec-spi-pre-delay: false > - google,cros-ec-spi-msg-delay: false > - spi-max-frequency: false > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - google,cros-ec-i2c > + - google,cros-ec-rpmsg > + then: > + properties: > + google,cros-ec-spi-pre-delay: false > + google,cros-ec-spi-msg-delay: false > + spi-max-frequency: false > + > + - $ref: /schemas/spi/samsung,spi-peripheral-props.yaml SPI device schemas should reference spi-peripheral-props.yaml only. spi-peripheral-props.yaml in turn should reference all the vendor specific peripheral property schemas. You should be able to do just: else: $ref: /schemas/spi/spi-peripheral-props.yaml Can you please hold off sending anything referencing spi-peripheral-props.yaml until after the merge window. Otherwise, the checks fail (though I trust you've run validation). Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CFFDC433F5 for ; Thu, 20 Jan 2022 22:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r77e6C5AS3wPKChHgIpMeQfxcPG+O2vME/ScN1ClaOk=; b=0709Db+UyLtRKY c+jQp+0M9xB9OgDhNrvKuube+H7nn4bsFzOqve/tdyp78TN7JL0VfhQUpSgyjcE0cEpkHwA8Ea+E7 OcLh52Is9Ita+q14ep95tPs0sylj2ClJujkXFrIvFUuHrMwbYFYk/tV75gkstKEegUAl7GhWQTELC ggZV40j7opgnMSwqgYtdTg6yNv+QjOrpi9JFlzJtYYkw5jct1KClFrgbNT0Yz8fLlLEh0CWLK6dyn diwFZMp79arABX+Ous/FIyGWF6HHYVBVNF0GYHs+Lm31K5oSOjFntb1zh99zoXe6MERkb/ftKyd8s o9dcZXsHa+Dt8lJUZcbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAg4V-00DJQw-G8; Thu, 20 Jan 2022 22:38:23 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAg4Q-00DJQ3-NQ for linux-arm-kernel@lists.infradead.org; Thu, 20 Jan 2022 22:38:20 +0000 Received: by mail-oi1-f175.google.com with SMTP id e81so11062938oia.6 for ; Thu, 20 Jan 2022 14:38:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JdY5i/vcjbMJ0CM6vrTsc2SV9D4UAPr/paJ/LZ4quKU=; b=UltRTeda1oBGWyEG4z1uAQSa9F4fq4aje12eP125IDD/amObhmYLGeurT0A65Jj8VG pOZd/dxYtUPdx8wHlwXxjastDwyCjgMs+DbZmcHfecFRDbqBQ/Awwe33tnRWY2hFLaLC HDYsgfnpreQ1kQbbSqwAVNoYIFQwV+1FCBJ21OoLmryxHLj2pSNHQz6wrxhrL1Wnzgu+ SFBFKDBTz4+mT/0gxaSDF/tm0UHpvjx4ESF6iCJkNKZmK7zLF4uauIrlJFIdkuqXkjYT gAU6zTt19EYiOTRXsnXym1OejxbentuWyrw/lZ8qyi9unMNs8XvQ0bz6qIsoJdUTLLo2 EzbA== X-Gm-Message-State: AOAM5324Wf5oBUKnKeTqJ6crdilooeLE7Vsc6IY6pxYuing/e0tHPdaB dth+NqykJrl/Oak2AOhXug== X-Google-Smtp-Source: ABdhPJyl7JvGUpPUz9KEz1EogbtYVo2DcE2eLMLcKFmUHz9O/XaZ0ejP62Kqpwa0ZPL4skeK9sz7OQ== X-Received: by 2002:a05:6808:1a23:: with SMTP id bk35mr9736209oib.52.1642718297796; Thu, 20 Jan 2022 14:38:17 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o12sm235957ooi.18.2022.01.20.14.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 14:38:17 -0800 (PST) Received: (nullmailer pid 2067772 invoked by uid 1000); Thu, 20 Jan 2022 22:38:15 -0000 Date: Thu, 20 Jan 2022 16:38:15 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Lee Jones , Benson Leung , Guenter Roeck , Andi Shyti , Mark Brown , Sam Protsenko , Pratyush Yadav , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, Alim Akhtar Subject: Re: [PATCH v5 3/4] mfd: dt-bindings: google,cros-ec: reference Samsung SPI bindings Message-ID: References: <20220120175747.43403-1-krzysztof.kozlowski@canonical.com> <20220120175747.43403-4-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220120175747.43403-4-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220120_143818_797028_633A0B92 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 20, 2022 at 06:57:46PM +0100, Krzysztof Kozlowski wrote: > The ChromeOS Embedded Controller appears on boards with Samsung Exynos > SoC, where Exynos SPI bindings expect controller-data node. Reference > newly added dtschema for this property. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/mfd/google,cros-ec.yaml | 29 ++++++++++--------- > 1 file changed, 16 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 58a1a9405228..66a995bbbbe9 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -31,7 +31,7 @@ properties: > > controller-data: > description: > - SPI controller data, see bindings/spi/spi-samsung.txt > + SPI controller data, see bindings/spi/samsung,spi-peripheral-props.yaml > type: object We should be able to drop all of this if unevaluatedProperties is used. > > google,cros-ec-spi-pre-delay: > @@ -148,18 +148,21 @@ patternProperties: > required: > - compatible > > -if: > - properties: > - compatible: > - contains: > - enum: > - - google,cros-ec-i2c > - - google,cros-ec-rpmsg > -then: > - properties: > - google,cros-ec-spi-pre-delay: false > - google,cros-ec-spi-msg-delay: false > - spi-max-frequency: false > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - google,cros-ec-i2c > + - google,cros-ec-rpmsg > + then: > + properties: > + google,cros-ec-spi-pre-delay: false > + google,cros-ec-spi-msg-delay: false > + spi-max-frequency: false > + > + - $ref: /schemas/spi/samsung,spi-peripheral-props.yaml SPI device schemas should reference spi-peripheral-props.yaml only. spi-peripheral-props.yaml in turn should reference all the vendor specific peripheral property schemas. You should be able to do just: else: $ref: /schemas/spi/spi-peripheral-props.yaml Can you please hold off sending anything referencing spi-peripheral-props.yaml until after the merge window. Otherwise, the checks fail (though I trust you've run validation). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel