All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	bhelgaas@google.com, koba.ko@canonical.com,
	Lukas Wunner <lukas@wunner.de>,
	Stuart Hayes <stuart.w.hayes@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/portdrv: Skip enabling AER on external facing ports
Date: Fri, 21 Jan 2022 14:44:31 +0200	[thread overview]
Message-ID: <Yeqqr1YXTNBkpz5C@lahna> (raw)
In-Reply-To: <CAAd53p4ej6FA0dM4ahngnGAccSLe=-bsUVkt-eGb2jZkms1UYA@mail.gmail.com>

Hi,

On Fri, Jan 21, 2022 at 08:31:27PM +0800, Kai-Heng Feng wrote:
> Hi Mika,
> 
> On Fri, Jan 21, 2022 at 6:55 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > Hi Kai-Heng,
> >
> > On Fri, Jan 07, 2022 at 12:09:57PM +0800, Kai-Heng Feng wrote:
> > > Only from root ports of thunderbolt devices.
> > >
> > > The error occurs as soon as the root port is runtime suspended to D3cold.
> > >
> > > Runtime suspend the AER service can resolve the issue. I wonder if
> > > it's the right thing to do here?
> >
> > I think you are right here. It seems that AER "service driver" is
> > completely missing PM hooks. Probably because it is more used in server
> > type of systems where power management is not priority.
> 
> Here is my previous attempt to suspend AER:
> https://lore.kernel.org/linux-pci/20210127173101.446940-1-kai.heng.feng@canonical.com/

That's great!

I think we should do the same for runtime PM paths too, though. Will you
take care of that as well? :)

  reply	other threads:[~2022-01-21 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  6:06 [PATCH] PCI/portdrv: Skip enabling AER on external facing ports Kai-Heng Feng
2022-01-05 20:12 ` Bjorn Helgaas
2022-01-07  4:09   ` Kai-Heng Feng
2022-01-21 10:55     ` Mika Westerberg
2022-01-21 12:31       ` Kai-Heng Feng
2022-01-21 12:44         ` Mika Westerberg [this message]
2022-01-21 14:25           ` Kai-Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yeqqr1YXTNBkpz5C@lahna \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=koba.ko@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.