From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH 3/3] tools/xenstore: drop DEFINE_HASHTABLE_* macros and usage intro
Date: Fri, 21 Jan 2022 15:13:16 +0000 [thread overview]
Message-ID: <YerNjEld2pe9hSoI@perard> (raw)
In-Reply-To: <20220120120236.13826-4-jgross@suse.com>
On Thu, Jan 20, 2022 at 01:02:36PM +0100, Juergen Gross wrote:
> The DEFINE_HASHTABLE_* macros are used nowhere, so drop them. The usage
> intro isn't needed either with those macros dropped.
The first part of the intro "Example of use:" doesn't speak about the
macro, so removing the macro part doesn't mean that the first part
should be removed. But it is probably not necessary as the documentation
for the functions are probably good enough to figure out how to use
hashtable. Can you reword that last sentence?
Thanks,
--
Anthony PERARD
prev parent reply other threads:[~2022-01-21 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 12:02 [PATCH 0/3] tools/xenstore: simplify hashtable implementation Juergen Gross
2022-01-20 12:02 ` [PATCH 1/3] tools/xenstore: merge hashtable_private.h into hashtable.c Juergen Gross
2022-01-21 14:40 ` Anthony PERARD
2022-01-20 12:02 ` [PATCH 2/3] tools/xenstore: fix hashtable_expand() zeroing new area Juergen Gross
2022-01-21 14:55 ` Anthony PERARD
2022-01-20 12:02 ` [PATCH 3/3] tools/xenstore: drop DEFINE_HASHTABLE_* macros and usage intro Juergen Gross
2022-01-21 15:13 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YerNjEld2pe9hSoI@perard \
--to=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.