All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Christy Lee <christylee@fb.com>,
	Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Christy Lee <christyc.y.lee@gmail.com>, bpf <bpf@vger.kernel.org>,
	"linux-perf-use." <linux-perf-users@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>, Wang Nan <wangnan0@huawei.com>,
	Wang ShaoBo <bobo.shaobowang@huawei.com>,
	YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH bpf-next v4 0/2] perf: stop using deprecated bpf APIs
Date: Sat, 22 Jan 2022 17:01:50 -0300	[thread overview]
Message-ID: <YexirjnVa7KpvrP9@kernel.org> (raw)
In-Reply-To: <CAEf4BzbODQmEH+wuFsEPFdtRoZ1Y-vDJKAKkBLsUDBLoQOmrvg@mail.gmail.com>

Em Thu, Jan 20, 2022 at 02:58:29PM -0800, Andrii Nakryiko escreveu:
> On Wed, Jan 19, 2022 at 3:09 PM Christy Lee <christylee@fb.com> wrote:
> >
> > libbpf's bpf_load_program() and bpf__object_next() APIs are deprecated.
> > remove perf's usage of these deprecated functions. After this patch
> > set, the only remaining libbpf deprecated APIs in perf would be
> > bpf_program__set_prep() and bpf_program__nth_fd().
> >
> 
> Arnaldo, do you want to take this through perf tree or should we apply
> this to bpf-next? If the latter, can you give your ack as well?
> Thanks!

I'd love to be able to test it with the containers, after I push the
current batch to Linus.

- Arnaldo
 
> > Changelog:
> > ----------
> > v3 -> v4:
> > * Fixed commit title
> > * Added weak definition for deprecated function
> >
> > v2 -> v3:
> > https://lore.kernel.org/all/20220106200032.3067127-1-christylee@fb.com/
> >
> > Patch 2/2:
> > Fixed commit message to use upstream perf
> >
> > v1 -> v2:
> > https://lore.kernel.org/all/20211216222108.110518-1-christylee@fb.com/
> >
> > Patch 1/2:
> > Added missing commit message
> >
> > Patch 2/2:
> > Added more details to commit message and added steps to reproduce
> > original test case.
> >
> > Christy Lee (2):
> >   perf: stop using deprecated bpf_load_program() API
> >   perf: stop using deprecated bpf_object__next() API
> >
> >  tools/perf/tests/bpf.c       | 14 ++-----
> >  tools/perf/util/bpf-event.c  | 16 ++++++++
> >  tools/perf/util/bpf-loader.c | 72 +++++++++++++++++++++++++++---------
> >  tools/perf/util/bpf-loader.h |  1 +
> >  4 files changed, 75 insertions(+), 28 deletions(-)
> >
> > --
> > 2.30.2

-- 

- Arnaldo

  reply	other threads:[~2022-01-22 20:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 23:06 [PATCH bpf-next v4 0/2] perf: stop using deprecated bpf APIs Christy Lee
2022-01-19 23:06 ` [PATCH bpf-next v4 1/2] perf: stop using deprecated bpf_load_program() API Christy Lee
2022-01-19 23:25   ` Andrii Nakryiko
     [not found]   ` <C02B00A0-5760-44CE-B727-90CF601A8437@fb.com>
2022-01-19 23:26     ` Andrii Nakryiko
     [not found]       ` <D753C41C-A70A-4316-8201-9F8369D1E627@fb.com>
2022-01-20  1:01         ` Andrii Nakryiko
2022-01-19 23:06 ` [PATCH bpf-next v4 2/2] perf: stop using deprecated bpf_object__next() API Christy Lee
2022-01-19 23:23   ` Song Liu
2022-01-23 17:06   ` Jiri Olsa
2022-02-02 17:00     ` Jiri Olsa
2022-02-02 17:24       ` Christy Lee
2022-02-09 16:11         ` Andrii Nakryiko
2022-02-12  7:31     ` Andrii Nakryiko
2022-01-20 22:58 ` [PATCH bpf-next v4 0/2] perf: stop using deprecated bpf APIs Andrii Nakryiko
2022-01-22 20:01   ` Arnaldo Carvalho de Melo [this message]
2022-01-22 20:38     ` Arnaldo Carvalho de Melo
2022-01-22 21:07       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YexirjnVa7KpvrP9@kernel.org \
    --to=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bobo.shaobowang@huawei.com \
    --cc=bpf@vger.kernel.org \
    --cc=christyc.y.lee@gmail.com \
    --cc=christylee@fb.com \
    --cc=jolsa@redhat.com \
    --cc=kernel-team@fb.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=wangnan0@huawei.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.