From: Greg KH <gregkh@linuxfoundation.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Miaoqian Lin <linmq006@gmail.com>,
bp@suse.de, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
tzimmermann@suse.de
Subject: Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
Date: Fri, 4 Feb 2022 16:41:48 +0100 [thread overview]
Message-ID: <Yf1JPCD1L4qt0T2c@kroah.com> (raw)
In-Reply-To: <259abc88-58ac-9101-21a1-5130168fcdac@redhat.com>
On Sun, Jan 16, 2022 at 06:31:09PM +0100, Javier Martinez Canillas wrote:
> On 1/16/22 13:16, Miaoqian Lin wrote:
> > Add the missing platform_device_put() before return from
> > sysfb_create_simplefb() in the error handling case.
> >
> > Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > Changes in v2:
> > - Use goto label to avoid duplicating the error code logic.
> > ---
> > drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Does not apply to my tree :(
prev parent reply other threads:[~2022-02-04 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 8:04 [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb Miaoqian Lin
2022-01-13 11:16 ` Javier Martinez Canillas
2022-01-16 12:16 ` [PATCH v2] " Miaoqian Lin
2022-01-16 17:31 ` Javier Martinez Canillas
2022-02-04 15:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf1JPCD1L4qt0T2c@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=javierm@redhat.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.