From: Borislav Petkov <bp@alien8.de>
To: Eliav Farber <farbere@amazon.com>
Cc: mchehab@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, ronenk@amazon.com,
talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com
Subject: Re: [PATCH 1/4] EDAC: Fix calculation of returned address and next offset in edac_align_ptr()
Date: Tue, 25 Jan 2022 15:37:11 +0100 [thread overview]
Message-ID: <YfALFy7LGGIOS2Fv@zn.tnic> (raw)
In-Reply-To: <20220113100622.12783-2-farbere@amazon.com>
On Thu, Jan 13, 2022 at 10:06:19AM +0000, Eliav Farber wrote:
> Do alignment logic properly and use 'ptr' for calculating the remainder
> of the alignment.
>
> This became an issue because 'struct edac_mc_layer' has a size that is
> not zero modulo eight, and the next offset that was prepared for the
> private-data was unaligned, causing an alignment exception.
How exactly did this "become an issue"?
I'm asking because I have been hearing about weird bugs with that
pointer alignment contraption and have never managed to reproduce them
myself or hear a proper explanation from people.
And that thing is an abomination, frankly, and I'd like to get rid of it
but maybe some other time...
So, please explain more verbosely, a specific example or how I could
reproduce it, would be even better.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-01-25 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 10:06 [PATCH 0/4] edac_align_ptr() bug fix and refactoring Eliav Farber
2022-01-13 10:06 ` [PATCH 1/4] EDAC: Fix calculation of returned address and next offset in edac_align_ptr() Eliav Farber
2022-01-25 14:37 ` Borislav Petkov [this message]
2022-01-27 9:58 ` Farber, Eliav
2022-02-15 12:34 ` Borislav Petkov
2022-02-15 13:06 ` Farber, Eliav
2022-01-13 10:06 ` [PATCH 2/4] EDAC: Remove unnecessary cast to char* in edac_align_ptr() function Eliav Farber
2022-01-26 18:46 ` Borislav Petkov
2022-01-13 10:06 ` [PATCH 3/4] EDAC: Refactor edac_align_ptr() to use u8/u16/u32/u64 data types Eliav Farber
2022-02-15 16:55 ` Borislav Petkov
2022-01-13 10:06 ` [PATCH 4/4] EDAC: Refactor edac_align_ptr() flow Eliav Farber
2022-02-15 17:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfALFy7LGGIOS2Fv@zn.tnic \
--to=bp@alien8.de \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.