Re: [PATCH] docs: expand firmware descriptor to allow flash without NVRAM

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Jan 25, 2022 at 08:50:54AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > >   { 'struct' : 'FirmwareMappingFlash',
> > > -  'data'   : { 'executable'     : 'FirmwareFlashFile',
> > > -               'nvram-template' : 'FirmwareFlashFile' } }
> > > +  'data'   : { 'mode': 'FirmwareFlashMode',
> > > +               'executable'     : 'FirmwareFlashFile',
> > > +               '*nvram-template' : 'FirmwareFlashFile' } }
> 
> I think for backward compatibility reasons we want 'mode' be optional,
> with 'mode' = 'split' being assumed in case it is not present.
> 
> otherwise looks sane to me.

Opps, yes, I even documented that it was optional but then failed
to mark it optional.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|