All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abdun Nihaal <abdun.nihaal@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	straube.linux@gmail.com, martin@kaiser.cx,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] staging: r8188eu: remove unneeded ret variables
Date: Tue, 25 Jan 2022 16:10:57 +0100	[thread overview]
Message-ID: <YfATARBq6FJ2e3HE@kroah.com> (raw)
In-Reply-To: <c9c24c13d2823ccaadbbce33613d1242531dbe86.1641551261.git.abdun.nihaal@gmail.com>

On Fri, Jan 07, 2022 at 04:05:40PM +0530, Abdun Nihaal wrote:
> Remove unneeded return variables in ioctl_linux.c that are initialized
> to 0 and are not assigned after. Instead, return 0 directly.

Many, if not most, of these functions should either be having their
return value checked, or be void functions as no one checks their return
value and they can not fail.  Please split this up and look at each
function to determine which is is and how to fix it up properly.  Just
returning 0 all the time is not the correct thing to do all the time.

One example would be rtw_p2p_get_status()  It can not fail, so why does
it return anything?

thanks,

greg k-h

  reply	other threads:[~2022-01-25 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 10:35 [PATCH v3 0/2] staging: r8188eu: remove unneeded ret variables Abdun Nihaal
2022-01-07 10:35 ` [PATCH v3 1/2] " Abdun Nihaal
2022-01-25 15:10   ` Greg KH [this message]
2022-01-27 15:25     ` Abdun Nihaal
2022-01-27 15:51       ` Greg KH
2022-01-29 10:20         ` Abdun Nihaal
2022-01-07 10:35 ` [PATCH v3 2/2] staging: r8188eu: change functions to return void Abdun Nihaal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfATARBq6FJ2e3HE@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abdun.nihaal@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.