From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFE6DC433F5 for ; Tue, 25 Jan 2022 22:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vmiyu0nZtqdCHpIPP3Xnt9BOxXWhabm1xncad1GopIU=; b=bPQt8sZgx7NpXp 5ESx8QzNp6GDPmg5QdMztyrg4k36h+aaEyqnxndpuWGKPt2E0cRadgpabcE5Q2q12pLmqVWmyZ6DO /cfnPjHQqVpDm4AL56MFTo3yTL4crTQ/5gojgyyQAVOaaLnsPxd95/gDJiLrOvvAZdEn7i7XR/hnZ UC1huC6ta/1GFx9SpIgYGnNjFWqQFyLSfzVrTA4TnPRKxOY7HoD/bQufg9fhHcORjR20BQyS/Jh2U B+PGfe5IwEkrqH3A4mxH0XNPxLboiZ6q2EfRJXHOERm3G8kEk8tx8/opIE2TptTgo7oT4gHr0T+AH 1QdBG7ynaP6hZl+UGjug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCULa-009dip-Ru; Tue, 25 Jan 2022 22:31:31 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCULX-009diG-P4 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 22:31:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GqNmRcbIdcR0lkfAVtnAna+7uu5s/9KhZCPTpg6gW2o=; b=eAYD8V1pKf5FniCp1ZOXlFPHYo T4qZh9jHM/326fW33sOnTFWI9W3uO7UWjCm/iy4gNq2oRLgByu8WCKD+sy88lKO9hJZpT617KGds8 tHyi9iBqEllOS/LPoXWlthqgSKYysvcwMvJyfYgM8p/N8kSp89DKGVn6m1NFK78m2Ayk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCUL5-002ifq-RF; Tue, 25 Jan 2022 23:30:59 +0100 Date: Tue, 25 Jan 2022 23:30:59 +0100 From: Andrew Lunn To: nick.hawkins@hpe.com Cc: verdun@hpe.com, Rob Herring , Russell King , Krzysztof Kozlowski , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Linus Walleij , Hao Fang , Arnd Bergmann , "Russell King (Oracle)" , Geert Uytterhoeven , Mark Rutland , Ard Biesheuvel , Anshuman Khandual , Lukas Bulwahn , Masahiro Yamada , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Adding architectural support for HPE's GXP BMC. This is the first of a series of patches to support HPE's BMC with Linux Kernel. Message-ID: References: <20220125194609.32314-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220125194609.32314-1-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_143127_841448_E875B9A1 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + mdio0: mdio@c0004080 { > + compatible = "hpe,gxp-umac-mdio"; > + reg = <0xc0004080 0x10>; > + #address-cells = <1>; > + #size-cells = <0>; > + ext_phy0: ethernt-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; c22 is the default, so you don't strictly need this. > + phy-mode = "sgmii"; > + reg = <0>; > + }; > + }; > + > + mdio1: mdio@c0005080 { > + compatible = "hpe,gxp-umac-mdio"; > + reg = <0xc0005080 0x10>; > + #address-cells = <1>; > + #size-cells = <0>; > + int_phy0: ethernt-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + phy-mode = "gmii"; > + reg = <0>; > + }; > + int_phy1: ethernt-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + phy-mode = "gmii"; > + reg = <1>; > + }; > + }; > + > + umac0: umac@c0004000 { > + compatible = "hpe, gxp-umac"; A space in a compatible? > + reg = <0xc0004000 0x80>; > + interrupts = <10>; > + interrupt-parent = <&vic0>; > + mac-address = [94 18 82 16 04 d8]; That is pretty unusual. Normally you leave the bootloader to fill this in with a per board MAC address. The danger with listing it here is that you have multiple boards in the same network using this MAC address, and then bad things happen. > + phy-handle = <&ext_phy0>; > + int-phy-handle = <&int_phy0>; Two phy-handles? Some very odd going on here! > + xreg_kyes: xreg_keys { > + compatible = "gpio-keys-polled"; > + poll-interval = <100>; > + > + IdButton { > + label = "ID Button"; > + linux,code = <200>; include/dt-bindings/input/linux-event-codes.h However #define KEY_PLAYCD 200 A BMC has a CD player? Maybe i have this wrong? > + PortOwner@0 { > + label = "Port Owner"; > + linux,code = <200>; > + gpios = <&gpio 250 1>; Two CD players? > + }; > + > + PortOwner@1 { > + label = "Port Owner"; > + linux,code = <201>; #define KEY_PAUSECD 201 And you can pause the second player? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93138C43219 for ; Tue, 25 Jan 2022 22:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbiAYWbn (ORCPT ); Tue, 25 Jan 2022 17:31:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54038 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233863AbiAYWbZ (ORCPT ); Tue, 25 Jan 2022 17:31:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GqNmRcbIdcR0lkfAVtnAna+7uu5s/9KhZCPTpg6gW2o=; b=eAYD8V1pKf5FniCp1ZOXlFPHYo T4qZh9jHM/326fW33sOnTFWI9W3uO7UWjCm/iy4gNq2oRLgByu8WCKD+sy88lKO9hJZpT617KGds8 tHyi9iBqEllOS/LPoXWlthqgSKYysvcwMvJyfYgM8p/N8kSp89DKGVn6m1NFK78m2Ayk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCUL5-002ifq-RF; Tue, 25 Jan 2022 23:30:59 +0100 Date: Tue, 25 Jan 2022 23:30:59 +0100 From: Andrew Lunn To: nick.hawkins@hpe.com Cc: verdun@hpe.com, Rob Herring , Russell King , Krzysztof Kozlowski , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Linus Walleij , Hao Fang , Arnd Bergmann , "Russell King (Oracle)" , Geert Uytterhoeven , Mark Rutland , Ard Biesheuvel , Anshuman Khandual , Lukas Bulwahn , Masahiro Yamada , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Adding architectural support for HPE's GXP BMC. This is the first of a series of patches to support HPE's BMC with Linux Kernel. Message-ID: References: <20220125194609.32314-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220125194609.32314-1-nick.hawkins@hpe.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > + mdio0: mdio@c0004080 { > + compatible = "hpe,gxp-umac-mdio"; > + reg = <0xc0004080 0x10>; > + #address-cells = <1>; > + #size-cells = <0>; > + ext_phy0: ethernt-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; c22 is the default, so you don't strictly need this. > + phy-mode = "sgmii"; > + reg = <0>; > + }; > + }; > + > + mdio1: mdio@c0005080 { > + compatible = "hpe,gxp-umac-mdio"; > + reg = <0xc0005080 0x10>; > + #address-cells = <1>; > + #size-cells = <0>; > + int_phy0: ethernt-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + phy-mode = "gmii"; > + reg = <0>; > + }; > + int_phy1: ethernt-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + phy-mode = "gmii"; > + reg = <1>; > + }; > + }; > + > + umac0: umac@c0004000 { > + compatible = "hpe, gxp-umac"; A space in a compatible? > + reg = <0xc0004000 0x80>; > + interrupts = <10>; > + interrupt-parent = <&vic0>; > + mac-address = [94 18 82 16 04 d8]; That is pretty unusual. Normally you leave the bootloader to fill this in with a per board MAC address. The danger with listing it here is that you have multiple boards in the same network using this MAC address, and then bad things happen. > + phy-handle = <&ext_phy0>; > + int-phy-handle = <&int_phy0>; Two phy-handles? Some very odd going on here! > + xreg_kyes: xreg_keys { > + compatible = "gpio-keys-polled"; > + poll-interval = <100>; > + > + IdButton { > + label = "ID Button"; > + linux,code = <200>; include/dt-bindings/input/linux-event-codes.h However #define KEY_PLAYCD 200 A BMC has a CD player? Maybe i have this wrong? > + PortOwner@0 { > + label = "Port Owner"; > + linux,code = <200>; > + gpios = <&gpio 250 1>; Two CD players? > + }; > + > + PortOwner@1 { > + label = "Port Owner"; > + linux,code = <201>; #define KEY_PAUSECD 201 And you can pause the second player? Andrew