From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 652A3C433EF for ; Tue, 25 Jan 2022 22:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bK018AdyChe0ZFCezzpSnKxLVv4AQvnZxIuCt+tHwsE=; b=v2GAY26eAbRM5i sI0agCrtWUtxo8vhAY7woYSbEj5/XhWATbHb5MgNZyBqreo5UDQMngyIYEtj3IOzW9A6cfnQUg8Ca gADsgam4wvOk5qDKu5x7mHJsIKCTeNvuwqA19FbK2S468pKoVetwkzqKlCc2sVlh4z5LxozViHoXx ituyT57jidY/1BJMOSeVvlPeaDYtDeqZy66YVAjOthhm8kAfiKfT2d0RchYFfzgUCN4Ow1VqEwfBU 5vlXHjdjK1tw+MwZOTiq4U+pHUUzD9ngeOzpQ+h5WfawYI0wzE+A2lE7tM+2CsZ2k8igNk1hHCSh6 3Q9GrAZnq4k+huNN6Nrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCUaj-009ebc-13; Tue, 25 Jan 2022 22:47:09 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCUag-009ead-FR for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 22:47:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=k9ztBqKotNbQORGVCT2yV1IoZPY2YsBdgTZyhwhHWaI=; b=s5+z/ky0lF06aNRAoie37oxf4b +UN0ENOaYGYd2VSlC7mAvBX5Z30YcH+xy4OmNCLCFWEU7PUiMyzm3obQRNaOD77bCbc+E3+5Xfjmz tH8wGQeNLxADNWRMl5ZbAmQbRkJzWbQ2Ff0VDEm/Ddajp6DeugRjIBp//n63Xn+vTXF4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCUaM-002ilJ-Lp; Tue, 25 Jan 2022 23:46:46 +0100 Date: Tue, 25 Jan 2022 23:46:46 +0100 From: Andrew Lunn To: nick.hawkins@hpe.com Cc: verdun@hpe.com, Rob Herring , Russell King , Krzysztof Kozlowski , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Linus Walleij , Hao Fang , Arnd Bergmann , "Russell King (Oracle)" , Geert Uytterhoeven , Mark Rutland , Ard Biesheuvel , Anshuman Khandual , Lukas Bulwahn , Masahiro Yamada , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Adding architectural support for HPE's GXP BMC. This is the first of a series of patches to support HPE's BMC with Linux Kernel. Message-ID: References: <20220125194609.32314-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220125194609.32314-1-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_144706_541059_3750272E X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + umac0: umac@c0004000 { > + compatible = "hpe, gxp-umac"; > + reg = <0xc0004000 0x80>; > + interrupts = <10>; > + interrupt-parent = <&vic0>; > + mac-address = [94 18 82 16 04 d8]; > + phy-handle = <&ext_phy0>; > + int-phy-handle = <&int_phy0>; > + }; I suggest you don't add any DT for drivers which have not been accepted yet. When you MAC driver is posted to netdev, the DT binding will get reviewed. And i expect int-phy-handle will be rejected. Often the first dtsi and dts submission for a new SoC have just the CPUs and the serial port, since none of the other drivers have been reviewed yet, unless they reuse existing drivers. The additional nodes are then added one by one as the drivers get accepted. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1D4C433EF for ; Tue, 25 Jan 2022 22:47:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234102AbiAYWrF (ORCPT ); Tue, 25 Jan 2022 17:47:05 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54076 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234071AbiAYWrE (ORCPT ); Tue, 25 Jan 2022 17:47:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=k9ztBqKotNbQORGVCT2yV1IoZPY2YsBdgTZyhwhHWaI=; b=s5+z/ky0lF06aNRAoie37oxf4b +UN0ENOaYGYd2VSlC7mAvBX5Z30YcH+xy4OmNCLCFWEU7PUiMyzm3obQRNaOD77bCbc+E3+5Xfjmz tH8wGQeNLxADNWRMl5ZbAmQbRkJzWbQ2Ff0VDEm/Ddajp6DeugRjIBp//n63Xn+vTXF4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCUaM-002ilJ-Lp; Tue, 25 Jan 2022 23:46:46 +0100 Date: Tue, 25 Jan 2022 23:46:46 +0100 From: Andrew Lunn To: nick.hawkins@hpe.com Cc: verdun@hpe.com, Rob Herring , Russell King , Krzysztof Kozlowski , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Linus Walleij , Hao Fang , Arnd Bergmann , "Russell King (Oracle)" , Geert Uytterhoeven , Mark Rutland , Ard Biesheuvel , Anshuman Khandual , Lukas Bulwahn , Masahiro Yamada , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Adding architectural support for HPE's GXP BMC. This is the first of a series of patches to support HPE's BMC with Linux Kernel. Message-ID: References: <20220125194609.32314-1-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220125194609.32314-1-nick.hawkins@hpe.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > + umac0: umac@c0004000 { > + compatible = "hpe, gxp-umac"; > + reg = <0xc0004000 0x80>; > + interrupts = <10>; > + interrupt-parent = <&vic0>; > + mac-address = [94 18 82 16 04 d8]; > + phy-handle = <&ext_phy0>; > + int-phy-handle = <&int_phy0>; > + }; I suggest you don't add any DT for drivers which have not been accepted yet. When you MAC driver is posted to netdev, the DT binding will get reviewed. And i expect int-phy-handle will be rejected. Often the first dtsi and dts submission for a new SoC have just the CPUs and the serial port, since none of the other drivers have been reviewed yet, unless they reuse existing drivers. The additional nodes are then added one by one as the drivers get accepted. Andrew